Bug 279304
| Summary: | net/py-magic-wormhole: Missing dependency to send documents | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Romain Tartière <romain> | ||||||
| Component: | Individual Port(s) | Assignee: | Muhammad Moinur Rahman <bofh> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Only Me | CC: | freebsd, njt | ||||||
| Priority: | --- | Flags: | bugzilla:
maintainer-feedback?
(bofh) |
||||||
| Version: | Latest | ||||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| Attachments: |
|
||||||||
Created attachment 253344 [details]
patch that adds devel/py-iterable-io
patch that adds devel/py-iterable-io
Created attachment 253345 [details]
patch that adds new dependencies for net/py-magic-wormhole
patch that adds new dependencies for net/py-magic-wormhole
I submitted two patches that fixes this. The first adds the devel/py-iterable-io port. The second updates net/py-magic-wormhole to add the new dependencies (archivers/py-zipstream-ng and devel/py-iterable-io). Hello, I am a maintainer for magic-wormhole. Is there some easy-ish tool that I could use in future to gauge how much work I might be making for downstream packagers (when inevitably in the future we consider a new dependency)? Ideally this would be something that could be built into CI, since it's easy to forget about "packaging" and different distributions etc. thanks for the work! meejah Looks like I have missed these patches. Will work on those in my upcoming batch. A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=43d38a139f018245111b029a525b16fcee492610 commit 43d38a139f018245111b029a525b16fcee492610 Author: N.J. Thomas <njt@ayvali.org> AuthorDate: 2024-09-12 13:59:18 +0000 Commit: Muhammad Moinur Rahman <bofh@FreeBSD.org> CommitDate: 2024-09-12 15:09:47 +0000 devel/py-iterable-io: New port iterable-io is a small Python library that provides an adapter so that it's possible to read from iterable objects in the same way as file-like objects. WWW: https://github.com/pR0Ps/iterable-io PR: 279304 devel/Makefile | 1 + devel/py-iterable-io/Makefile (new) | 16 ++++++++++++++++ devel/py-iterable-io/distinfo (new) | 3 +++ devel/py-iterable-io/pkg-descr (new) | 3 +++ 4 files changed, 23 insertions(+) A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=70b550b74187b0f493dc295aff3db7afd9e2819f commit 70b550b74187b0f493dc295aff3db7afd9e2819f Author: N.J. Thomas <njt@ayvali.org> AuthorDate: 2024-09-12 15:08:28 +0000 Commit: Muhammad Moinur Rahman <bofh@FreeBSD.org> CommitDate: 2024-09-12 15:09:48 +0000 net/py-magic-wormhole: Fix missing dependency PR: 279304 Reported by: romain net/py-magic-wormhole/Makefile | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) (In reply to meejah from comment #4) Hi, Normally, if you have a mention in the release notes, most committers will pick it up. Mostly we look at the release notes to take care of such dependency. As it's mostly not easier to look at the src dist. |
``` romain@zappy ~ % wormhole send Traceback (most recent call last): File "/usr/local/bin/wormhole", line 33, in <module> sys.exit(load_entry_point('magic-wormhole==0.14.0', 'console_scripts', 'wormhole')()) File "/usr/local/lib/python3.9/site-packages/click/core.py", line 1157, in __call__ return self.main(*args, **kwargs) File "/usr/local/lib/python3.9/site-packages/click/core.py", line 1078, in main rv = self.invoke(ctx) File "/usr/local/lib/python3.9/site-packages/click/core.py", line 1688, in invoke return _process_result(sub_ctx.command.invoke(sub_ctx)) File "/usr/local/lib/python3.9/site-packages/click/core.py", line 1434, in invoke return ctx.invoke(self.callback, **ctx.params) File "/usr/local/lib/python3.9/site-packages/click/core.py", line 783, in invoke return __callback(*args, **kwargs) File "/usr/local/lib/python3.9/site-packages/click/decorators.py", line 45, in new_func return f(get_current_context().obj, *args, **kwargs) File "/usr/local/lib/python3.9/site-packages/wormhole/cli/cli.py", line 282, in send from . import cmd_send File "/usr/local/lib/python3.9/site-packages/wormhole/cli/cmd_send.py", line 21, in <module> from iterableio import open_iterable ModuleNotFoundError: No module named 'iterableio' ``` Looks like the dependency was added in: https://github.com/magic-wormhole/magic-wormhole/commit/c4c56e1d75a3f25246d785f3635c67a81ea0193d But no port exist for it ATM