Bug 279472

Summary: graphics/opensubdiv: sort out Makefile, pet portclippy, fix build on 32bit
Product: Ports & Packages Reporter: Vladimir Druzenko <vvd>
Component: Individual Port(s)Assignee: Vladimir Druzenko <vvd>
Status: Closed FIXED    
Severity: Affects Some People CC: FreeBSD
Priority: --- Flags: FreeBSD: maintainer-feedback+
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
v1 vvd: maintainer-approval?

Description Vladimir Druzenko freebsd_committer freebsd_triage 2024-06-02 17:29:44 UTC 
Created attachment 251163 [details]
v1

Tested build in poudriere (testport) 13.3 amd64, i386 and on live system 13.3 amd64.

- Remove unnecessary libs from USE_GL and add used.
- Fix build on 32bit ARCHS, upstream issue: https://github.com/PixarAnimationStudios/OpenSubdiv/issues/1198#issuecomment-2143940211
- Make options PTEX and OPENMP (for supported ARCHS) default.
- EXAMPLES and OPENCL can build together without errors.
- Remove NO_GL_TESTS - upstream removed it.
- Sort options and pet portclippy.
Comment 1 Shane 2024-06-03 10:23:20 UTC 
Comment on attachment 251163 [details]
v1

looks ok
Comment 2 commit-hook freebsd_committer freebsd_triage 2024-06-03 10:49:41 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=f251a78efa6eb44e9d97fd520247d3494754f7c8

commit f251a78efa6eb44e9d97fd520247d3494754f7c8
Author:     Vladimir Druzenko <vvd@FreeBSD.org>
AuthorDate: 2024-06-03 10:46:50 +0000
Commit:     Vladimir Druzenko <vvd@FreeBSD.org>
CommitDate: 2024-06-03 10:46:50 +0000

    graphics/opensubdiv: sort out Makefile, pet portclippy, fix build on 32bit

    - Remove unnecessary libs from USE_GL and add required.
    - Fix build on 32bit ARCHS, upstream issue:
    https://github.com/PixarAnimationStudios/OpenSubdiv/issues/1198#issuecomment-2143940211
    - Make options OPENMP (for supported ARCHS) and PTEX default.
    - EXAMPLES and OPENCL can build together without errors.
    - Remove NO_GL_TESTS - upstream removed it.
    - Sort options and pet portclippy.

    PR:             279472
    Approved by:    Shane <FreeBSD@ShaneWare.Biz> (maintainer)

 graphics/opensubdiv/Makefile                       | 51 +++++++++++-----------
 .../files/patch-examples_CMakeLists.txt (gone)     | 12 -----
 .../files/patch-opensubdiv_hbr_mesh.h (new)        | 11 +++++
 .../files/patch-opensubdiv_osd_CMakeLists.txt      |  8 ++--
 .../files/patch-regression_CMakeLists.txt (gone)   | 22 ----------
 .../files/patch-tutorials_CMakeLists.txt (gone)    | 12 -----
 graphics/opensubdiv/pkg-plist                      | 20 ++++-----
 7 files changed, 51 insertions(+), 85 deletions(-)