Bug 279516

Summary: audio/audacity: fresh install reports incompatible plugin
Product: Ports & Packages Reporter: Ed Maste <emaste>
Component: Individual Port(s)Assignee: Vladimir Druzenko <vvd>
Status: Closed FIXED    
Severity: Affects Only Me CC: fernape, tatsuki_makino, vvd, xxjack12xx
Priority: --- Flags: bugzilla: maintainer-feedback? (xxjack12xx)
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Add missing required lv2 dependency
xxjack12xx: maintainer-approval+
Add lv2 has build dependency xxjack12xx: maintainer-approval+

Description Ed Maste freebsd_committer freebsd_triage 2024-06-04 13:21:14 UTC
New install of audacity-3.5.1 reports:

Incompatible plugin(s) found

Audacity has found 1 incompatible plugins which could not be loaded. We have disabled these plugins to avoid any stalling or crashes. If you would still like to attempt to use these plugins, you can enable them using "Manage Plugins." Otherwise, select "Continue".

http://lv2plug.in/plugins/eg-sampler
Comment 1 Jack 2024-06-04 18:17:29 UTC
What options were used in the compilation options? I'll check.
Comment 2 Ed Maste freebsd_committer freebsd_triage 2024-06-04 18:51:44 UTC
This is using the official FreeBSD-provided package (just `pkg install audacity`) so will be the defaults, I expect.
Comment 3 Jack 2024-06-04 18:55:10 UTC
Created attachment 251224 [details]
Add missing required lv2 dependency

lv2 requirement was missing. This should fix lv2 being unable to load on fresh install.
Comment 4 Jack 2024-06-04 22:45:57 UTC
Created attachment 251228 [details]
Add lv2 has build dependency

Add as build depend instead of lib depend
Comment 5 Tatsuki Makino 2024-06-05 01:06:51 UTC
(In reply to Jack from comment #4)

I don't think just pulling it in will fix it.
lilv, suil, and sratom pull it in, so it seems to be present at the time of the build.

I can't find a good example, but it seems normal that plug-ins for things like synthesizers cannot be used from Audacity.
Comment 6 Tatsuki Makino 2024-06-05 01:30:14 UTC
It doesn't matter, but we can increase the number of incompatible plugins by installing rubberband(audio/rubberband) :)
Comment 7 Fernando ApesteguĂ­a freebsd_committer freebsd_triage 2024-06-06 12:21:54 UTC
^Triage: reporter is committer, assign accordingly.
Comment 8 Vladimir Druzenko freebsd_committer freebsd_triage 2024-07-17 13:50:07 UTC
Is it fixed with attached patch?
Comment 9 commit-hook freebsd_committer freebsd_triage 2024-07-17 20:13:01 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=37f9ad12da4ef635e3328207f47cca0d0e227986

commit 37f9ad12da4ef635e3328207f47cca0d0e227986
Author:     Jack <xxjack12xx@gmail.com>
AuthorDate: 2024-07-17 13:47:21 +0000
Commit:     Vladimir Druzenko <vvd@FreeBSD.org>
CommitDate: 2024-07-17 20:12:08 +0000

    audio/audacity: fresh install reports incompatible plugin: lv2 requirement was missing

    PR:     279516
    MFH:    2024Q3

 audio/audacity/Makefile | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
Comment 10 commit-hook freebsd_committer freebsd_triage 2024-07-17 20:24:08 UTC
A commit in branch 2024Q3 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=ac3b1f45687b004e7dfc6ca51877167b550471d1

commit ac3b1f45687b004e7dfc6ca51877167b550471d1
Author:     Jack <xxjack12xx@gmail.com>
AuthorDate: 2024-07-17 13:47:21 +0000
Commit:     Vladimir Druzenko <vvd@FreeBSD.org>
CommitDate: 2024-07-17 20:23:09 +0000

    audio/audacity: fresh install reports incompatible plugin: lv2 requirement was missing

    PR:     279516
    MFH:    2024Q3
    (cherry picked from commit 37f9ad12da4ef635e3328207f47cca0d0e227986)

 audio/audacity/Makefile | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
Comment 11 Tatsuki Makino 2024-07-18 22:53:43 UTC
If the fix would not cause the problem, it would not have occurred if it had been built in an environment where it was already installed.

However, this problem will be reproduced again and again by pressing the rescan button in the plugin manager.

eg-sampler seems to be incompatible because it returns false in the following line.
https://github.com/audacity/audacity/blob/6b4cbde95fb12ad1d3384b21e967245575b4a4db/libraries/lib-lv2/LV2EffectBase.cpp#L131

From here on out, it's still unexplored due to my poor ability to read c++ :)
Comment 12 Vladimir Druzenko freebsd_committer freebsd_triage 2024-07-19 13:36:58 UTC
Incompatible plugin(s) found:
/usr/local/lib/ladspa/bandpass_a_iir_1893.so
/usr/local/lib/ladspa/bandpass_iir_1892.so
/usr/local/lib/ladspa/butterworth_1902.so
/usr/local/lib/ladspa/highpass_iir_1890.so
/usr/local/lib/ladspa/lowpass_iir_1891.so
/usr/local/lib/ladspa/notch_iir_1894.so
http://breakfastquay.com/rdf/lv2-rubberband#mono
http://breakfastquay.com/rdf/lv2-rubberband#r3mono
http://breakfastquay.com/rdf/lv2-rubberband#r3stereo
http://breakfastquay.com/rdf/lv2-rubberband#stereo
Comment 13 Tatsuki Makino 2024-07-20 05:46:17 UTC
When I used 3.6.0 with the old ports dependent, I got more incompatible plugins.

http: //breakfastquay.com/rdf/lv2-rubberband#mono
http: //breakfastquay.com/rdf/lv2-rubberband#r3mono
http: //breakfastquay.com/rdf/lv2-rubberband#r3stereo
http: //breakfastquay.com/rdf/lv2-rubberband#stereo
http: //lv2plug.in/plugins/eg-amp
http: //lv2plug.in/plugins/eg-fifths
http: //lv2plug.in/plugins/eg-metro
http: //lv2plug.in/plugins/eg-midigate
http: //lv2plug.in/plugins/eg-params
http: //lv2plug.in/plugins/eg-sampler
http: //lv2plug.in/plugins/eg-scope#Mono
http: //lv2plug.in/plugins/eg-scope#Stereo

I can't test in my environment yet to see if the problem doesn't occur if all the ports are latest.