Bug 279522

Summary: x11-toolkits/pango: Update to 1.52.2
Product: Ports & Packages Reporter: Tijl Coosemans <tijl>
Component: Individual Port(s)Assignee: freebsd-desktop (Team) <desktop>
Status: Closed FIXED    
Severity: Affects Only Me CC: arrowd, sunpoet
Priority: --- Keywords: patch
Version: Latest   
Hardware: Any   
OS: Any   
Bug Depends on: 279548    
Bug Blocks:    
Attachments:
Description Flags
patch none

Description Tijl Coosemans freebsd_committer freebsd_triage 2024-06-04 16:17:58 UTC
Created attachment 251218 [details]
patch

x11-toolkist/pango: Update to 1.52.2
Comment 1 Gleb Popov freebsd_committer freebsd_triage 2024-06-04 16:23:15 UTC
LGTM except fonts being in TEST_DEPENDS. If you're sure this is not a typo, please push.
Comment 2 commit-hook freebsd_committer freebsd_triage 2024-06-05 15:19:28 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=af2c0a4d9bd4609ee357ac0a12f330708362cb33

commit af2c0a4d9bd4609ee357ac0a12f330708362cb33
Author:     Tijl Coosemans <tijl@FreeBSD.org>
AuthorDate: 2024-05-20 18:53:17 +0000
Commit:     Tijl Coosemans <tijl@FreeBSD.org>
CommitDate: 2024-06-05 14:51:47 +0000

    x11-toolkits/pango: Update to 1.52.2

    PR:             279522
    Reviewed by:    arrowd

 x11-toolkits/pango/Makefile | 29 +++++++++++++----------------
 x11-toolkits/pango/distinfo |  6 +++---
 2 files changed, 16 insertions(+), 19 deletions(-)
Comment 3 Tijl Coosemans freebsd_committer freebsd_triage 2024-06-05 15:25:15 UTC
(In reply to Gleb Popov from comment #1)
One of the tests uses the Cantarell font.  There's still one test that fails by the way.  The output is slightly different from what is expected.  I suspect it is caused by changes in recent versions of freetype.
Comment 4 Po-Chuan Hsieh freebsd_committer freebsd_triage 2024-06-06 06:16:44 UTC
@arrowd,

I've prepared a patch [1] to fix PLIST issue. Please take a look.
Thanks.

[1] https://people.freebsd.org/~sunpoet/patch/x11-toolkits-pango.txt
Comment 5 Gleb Popov freebsd_committer freebsd_triage 2024-06-06 06:18:08 UTC
Maybe we should just do PORTDOCS= * in the Makefile.

The patch looks OK nevertheless.
Comment 6 Po-Chuan Hsieh freebsd_committer freebsd_triage 2024-06-06 06:47:15 UTC
(In reply to Gleb Popov from comment #5)

Fixed in ports d3c709b70f8a80846369a368dafa42d86d199279. Thanks.
Comment 7 commit-hook freebsd_committer freebsd_triage 2024-06-06 06:47:18 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=d3c709b70f8a80846369a368dafa42d86d199279

commit d3c709b70f8a80846369a368dafa42d86d199279
Author:     Po-Chuan Hsieh <sunpoet@FreeBSD.org>
AuthorDate: 2024-06-06 06:46:06 +0000
Commit:     Po-Chuan Hsieh <sunpoet@FreeBSD.org>
CommitDate: 2024-06-06 06:46:06 +0000

    x11-toolkits/pango: Fix PLIST

    - While I'm here, sort PLIST
    - Bump PORTREVISION for package change

    PR:             279522, 279548
    Approved by:    arrowd (desktop)

 x11-toolkits/pango/Makefile  | 1 +
 x11-toolkits/pango/pkg-plist | 8 ++++++--
 2 files changed, 7 insertions(+), 2 deletions(-)