Bug 279568

Summary: [patch] audio/sayonara is missing gstreamer1-plugins-pulse dependency
Product: Ports & Packages Reporter: Harald Schmalzbauer <bugzilla.freebsd>
Component: Individual Port(s)Assignee: Adriaan de Groot <adridg>
Status: Closed FIXED    
Severity: Affects Many People Flags: bugzilla: maintainer-feedback? (adridg)
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Make sayonaras builtin 'pulseaudio' output config working. none

Description Harald Schmalzbauer 2024-06-07 13:27:44 UTC 
Created attachment 251269 [details]
Make sayonaras builtin 'pulseaudio' output config working.

Just stumbled across audio/sayonara and wanted to give it a try - Default 'auto' output configuration didn't work with my pulseaudio based sound DE.  Setting to 'pulseaudio' couldn't change anything because gstreamer1-plugins-pulse wasn't installed.

Upstream distribution includes alsa AND pulse plugins, see https://gitlab.com/luciocarreras/sayonara-player/-/merge_requests/304/diffs?commit_id=d2503164f29f9185ed15fe80d9683273c0d9531d

Please find attached the patch to simply add gstreamer1-plugins-pulse as dependency (USE_GSTREAMER+= pulse)

Thanks for maintaining!  Always nice to have alternatives, even better if they work out of box :-)
Comment 1 commit-hook freebsd_committer freebsd_triage 2024-06-11 22:06:32 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=fcf990eaf36a6e26ef5eade77248c24ea9164e9f

commit fcf990eaf36a6e26ef5eade77248c24ea9164e9f
Author:     Adriaan de Groot <adridg@FreeBSD.org>
AuthorDate: 2024-06-11 21:56:45 +0000
Commit:     Adriaan de Groot <adridg@FreeBSD.org>
CommitDate: 2024-06-11 22:05:29 +0000

    audio/sayonara: enable PulseAudio, repair Python scripts

    Sayonara did not have a dependency on GStreamer PulseAudio plugins,
    so it would use only ALSA for output. PA is installed anyway in
    desktop systems, so enable the plugin. Thanks Harald for the
    simple patch.

    While here, repair the Python scripts, which need pydbus --
    add the dependency, then repair the code to work with the
    version of pydbus that we have in ports.

    Reported-by:    Harald Schmalzbauer <bugzilla.freebsd@omnilan.de>
    PR:             279568

 audio/sayonara/Makefile                              |  4 +++-
 .../sayonara/files/patch-src_DBus_sayonara-ctl (new) | 20 ++++++++++++++++++++
 .../files/patch-src_DBus_sayonara-query (new)        | 20 ++++++++++++++++++++
 3 files changed, 43 insertions(+), 1 deletion(-)
Comment 2 Adriaan de Groot freebsd_committer freebsd_triage 2024-06-11 22:10:01 UTC 
Thanks Harald! In principle my KDE Plasma desktop on FreeBSD is PA-based, too, but I never noticed an issue with playing music with Sayonara. Anyway, your fix has landed. And then I noticed that the sayonara-ctl script didn't work at all, so I fixed that too.