Bug 279604

Summary: lang/zig: fix STATIC and no DOCS build
Product: Ports & Packages Reporter: Jeroen Ruigrok van der Werven <asmodai>
Component: Individual Port(s)Assignee: Matthias Fechner <mfechner>
Status: Closed FIXED    
Severity: Affects Some People CC: bsd, fernape, mfechner
Priority: --- Flags: bsd: maintainer-feedback+
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Patch to fix lang/zig static and no docs building on my poudriere environment
none
Update to 0.13.0, fix static compile, automatic PLIST creation mfechner: maintainer-approval?

Description Jeroen Ruigrok van der Werven freebsd_committer freebsd_triage 2024-06-09 09:09:09 UTC
Created attachment 251310 [details]
Patch to fix lang/zig static and no docs building on my poudriere environment

When you currently try to build lang/zig with the STATIC option set and DOCS unset on poudriere, it fails in two places:

- static build can't find libxml2
- tries to include documentation directory that should not when DOCS is unset
Comment 1 Fernando ApesteguĂ­a freebsd_committer freebsd_triage 2024-06-19 07:07:52 UTC
^Triage: reporter is committer, assign accordingly.
Comment 2 Matthias Fechner freebsd_committer freebsd_triage 2024-09-26 07:48:45 UTC
I will have here a look into it and will maybe combine with upgrade to 0.13.0 and automatic PLIST generation, currently build testing the modifications
Comment 3 Matthias Fechner freebsd_committer freebsd_triage 2024-09-26 12:12:33 UTC
Created attachment 253829 [details]
Update to 0.13.0, fix static compile, automatic PLIST creation
Comment 4 Matthias Fechner freebsd_committer freebsd_triage 2024-09-26 12:14:10 UTC
Please find attach a patch to simplify further upgrade as the PLIST is now generated automatically.

I test compiled it with and without DOCS option.

Please let me know if it is fine for you, then I will commit it.
Comment 5 Jeroen Ruigrok van der Werven freebsd_committer freebsd_triage 2024-09-26 13:35:32 UTC
Hi Matthias,

thanks for this. Looks good to my eyes.
Sorry for not responding sooner, was wrapping up my last job and going on vacation.
Comment 6 Matthias Fechner freebsd_committer freebsd_triage 2024-10-02 04:10:09 UTC
(In reply to Jeroen Ruigrok van der Werven from comment #5)
no problem that can happen, I hope the maintainer will understand it.

Lets wait till we get the approval from the maintainer.
Comment 7 bsd 2024-10-02 16:21:31 UTC
I've tested it on 14.1-RELEASE and it seems OK (compiles zls).
Sorry for the late reply, I somehow missed mails in June.
Thanks for the diff!
Comment 8 commit-hook freebsd_committer freebsd_triage 2024-10-03 04:53:58 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=b2b3906286ed84b2b9961c10230e0c3ccde6f751

commit b2b3906286ed84b2b9961c10230e0c3ccde6f751
Author:     Matthias Fechner <mfechner@FreeBSD.org>
AuthorDate: 2024-09-26 12:07:25 +0000
Commit:     Matthias Fechner <mfechner@FreeBSD.org>
CommitDate: 2024-10-03 04:52:49 +0000

    lang/zig: update to 0.13.0

    - include static compile fix by asmodai@ (see PR 279604)
    - automatically generate the PLIST

    PR:             279604
    Reported by:    asmodai@
    Approved by:    bsd@orsolic.org (maintainer)

 lang/zig/Makefile                          |    20 +-
 lang/zig/distinfo                          |     6 +-
 lang/zig/files/patch-CMakeLists.txt (gone) |    10 -
 lang/zig/pkg-plist (gone)                  | 15196 ---------------------------
 4 files changed, 21 insertions(+), 15211 deletions(-)
Comment 9 Matthias Fechner freebsd_committer freebsd_triage 2024-10-03 04:58:29 UTC
(In reply to bsd from comment #7)
Thanks for checking it.
Comment 10 commit-hook freebsd_committer freebsd_triage 2024-10-03 14:44:26 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=5a6285a01f5db5d166346d065cedbba7343ce11d

commit 5a6285a01f5db5d166346d065cedbba7343ce11d
Author:     Jan Beich <jbeich@FreeBSD.org>
AuthorDate: 2024-10-03 14:01:41 +0000
Commit:     Jan Beich <jbeich@FreeBSD.org>
CommitDate: 2024-10-03 14:42:32 +0000

    x11-wm/river: update to 0.3.4 after b2b3906286ed

    river-0.3.2/build.zig:151:61: error: no field named 'path' in union 'Build.LazyPath'
    /usr/local/lib/zig/std/Build.zig:2171:22: note: union declared here

    PR:             279604
    Changes:        https://codeberg.org/river/river/releases/tag/v0.3.3
    Changes:        https://codeberg.org/river/river/releases/tag/v0.3.4
    Reported by:    Repology

 x11-wm/river/Makefile | 13 ++++++-------
 x11-wm/river/distinfo | 22 +++++++++++-----------
 2 files changed, 17 insertions(+), 18 deletions(-)
Comment 11 commit-hook freebsd_committer freebsd_triage 2024-10-03 14:44:27 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=66728bd2c742c32d05a009e45e2e2212718ba80c

commit 66728bd2c742c32d05a009e45e2e2212718ba80c
Author:     Jan Beich <jbeich@FreeBSD.org>
AuthorDate: 2024-09-15 12:31:06 +0000
Commit:     Jan Beich <jbeich@FreeBSD.org>
CommitDate: 2024-10-03 14:42:31 +0000

    x11/waylock: update to 1.2.1 after b2b3906286ed

    waylock-1.1.0/build.zig:39:30: error: no field named 'path' in union 'Build.LazyPath'
    /usr/local/lib/zig/std/Build.zig:2171:22: note: union declared here

    PR:             279604
    Changes:        https://codeberg.org/ifreund/waylock/releases/tag/v1.2.0
    Changes:        https://codeberg.org/ifreund/waylock/releases/tag/v1.2.1
    Reported by:    Repology

 x11/waylock/Makefile |  9 ++++-----
 x11/waylock/distinfo | 14 +++++++-------
 2 files changed, 11 insertions(+), 12 deletions(-)
Comment 12 commit-hook freebsd_committer freebsd_triage 2024-10-03 14:44:28 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=6eff6ca626fabfee345dc6f9122c425de17023bd

commit 6eff6ca626fabfee345dc6f9122c425de17023bd
Author:     Jan Beich <jbeich@FreeBSD.org>
AuthorDate: 2024-06-09 00:05:07 +0000
Commit:     Jan Beich <jbeich@FreeBSD.org>
CommitDate: 2024-10-03 14:42:29 +0000

    devel/zls: update to 0.13.0 after b2b3906286ed

    zls-0.12.0/build.zig:496:9: error:
    Your Zig version does not meet the minimum build requirement:
      required Zig version: 0.12.0
      actual   Zig version: 0.13.0

    PR:             279604
    Changes:        https://github.com/zigtools/zls/releases/tag/0.13.0
    Reported by:    GitHub (watch releases)

 devel/zls/Makefile |  9 ++++-----
 devel/zls/distinfo | 18 +++++++++---------
 2 files changed, 13 insertions(+), 14 deletions(-)
Comment 13 commit-hook freebsd_committer freebsd_triage 2024-10-03 14:44:30 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=d518dc142c460f151b2a4c9897bdd14b19977433

commit d518dc142c460f151b2a4c9897bdd14b19977433
Author:     Jan Beich <jbeich@FreeBSD.org>
AuthorDate: 2024-10-03 13:30:43 +0000
Commit:     Jan Beich <jbeich@FreeBSD.org>
CommitDate: 2024-10-03 14:42:25 +0000

    sysutils/ncdu2: unbreak after b2b3906286ed

    ===>   ncdu2-2.4_1 depends on package: zig>=0.12.0<0.12.1_99 - not found
    *** Error code 1

    PR:             279604

 sysutils/ncdu2/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 14 commit-hook freebsd_committer freebsd_triage 2024-10-03 14:44:31 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=dc00effdc453557c969eabfaa3f17bd1ff3a6c24

commit dc00effdc453557c969eabfaa3f17bd1ff3a6c24
Author:     Jan Beich <jbeich@FreeBSD.org>
AuthorDate: 2024-10-03 14:22:25 +0000
Commit:     Jan Beich <jbeich@FreeBSD.org>
CommitDate: 2024-10-03 14:42:23 +0000

    audio/linuxwave: unbreak build after b2b3906286ed

    /wrkdirs/usr/ports/audio/linuxwave/work/linuxwave-0.1.5/build.zig:44:33: error: no field named 'path' in union 'Build.LazyPath'
    /usr/local/lib/zig/std/Build.zig:2171:22: note: union declared here

    PR:             279604

 audio/linuxwave/Makefile | 2 +-
 audio/linuxwave/distinfo | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)
Comment 15 commit-hook freebsd_committer freebsd_triage 2024-10-03 14:44:32 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=672d44b702622dc0f3ca5d0ace702a6b49820cb2

commit 672d44b702622dc0f3ca5d0ace702a6b49820cb2
Author:     Jan Beich <jbeich@FreeBSD.org>
AuthorDate: 2024-09-16 20:34:52 +0000
Commit:     Jan Beich <jbeich@FreeBSD.org>
CommitDate: 2024-10-03 14:42:27 +0000

    astro/mepo: update to 1.3.3 after b2b3906286ed

    mepo-1.2.1/build.zig:14:27: error: no field named 'path' in union 'Build.LazyPath'
    /usr/local/lib/zig/std/Build.zig:2171:22: note: union declared here

    PR:             279604
    Changes:        https://git.sr.ht/~mil/mepo/refs/1.3.0
    Changes:        https://git.sr.ht/~mil/mepo/refs/1.3.1
    Changes:        https://git.sr.ht/~mil/mepo/refs/1.3.2
    Changes:        https://git.sr.ht/~mil/mepo/refs/1.3.3
    Reported by:    Repology

 astro/mepo/Makefile  | 9 ++-------
 astro/mepo/distinfo  | 6 +++---
 astro/mepo/pkg-plist | 8 +++++---
 3 files changed, 10 insertions(+), 13 deletions(-)
Comment 16 Jan Beich freebsd_committer freebsd_triage 2024-10-03 14:45:21 UTC
Next time, please, make sure to test consumers and/or look how previous updates were done. Depending on time some consumers may not be ready, have blocking build/runtime issues unrelated to Zig or lack of time by port maintainer.