Bug 279775

Summary: [MAINTAINER] ftp/rexx-curl: Fix build failure for curl >= 8.8.0
Product: Ports & Packages Reporter: Bob Eager <bob>
Component: Individual Port(s)Assignee: Zsolt Udvari <uzsolt>
Status: Closed FIXED    
Severity: Affects Some People CC: bob, uzsolt
Priority: --- Flags: bob: maintainer-feedback+
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Patches for files in port directory
none
update to 2.1.1 (v1) none

Description Bob Eager 2024-06-15 22:00:58 UTC
Created attachment 251481 [details]
Patches for files in port directory

curl 8.8.0 removes a feature that supplies a symbol for rexx-curl builds. This is a deprecated and non-functional feature, so this patch removes it entirely from rexx-curl.

Files modified:
Makefile
failes/patch-rexxcurl.c

No files are added or removed.

Patch attached. I was told off last time for supplying a simple diff, so I have prodiced one with git. I hope that it is acceptable!
Comment 1 Zsolt Udvari freebsd_committer freebsd_triage 2024-07-01 04:11:05 UTC
Hi Bob,
do you want to update 2.1.1?
Comment 2 Zsolt Udvari freebsd_committer freebsd_triage 2024-09-02 18:46:51 UTC
Friendly ping.
Comment 3 Bob Eager 2024-09-03 12:28:52 UTC
(In reply to Zsolt Udvari from comment #1)

I will do that separately as I have other work to do. I apologise for the delay - I missed the notification!
Comment 4 Zsolt Udvari freebsd_committer freebsd_triage 2024-09-03 20:15:00 UTC
Created attachment 253306 [details]
update to 2.1.1 (v1)

I think doesn't need patch the 2.1.1 - at least I can build it (delete patch-Makefile.in and patch-rexxcurl.c patches, add pkgconfig to USES).

If we simply update to 2.1.1 doesn't need add your patch - and remove it after update to 2.1.1.

Could you please test this patch? I don't use this program and if it works can commit it.
Comment 5 Bob Eager 2024-09-04 09:05:36 UTC
Comment on attachment 253306 [details]
update to 2.1.1 (v1)

That seems fine. Please commit.
Comment 6 commit-hook freebsd_committer freebsd_triage 2024-09-04 16:45:33 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=e22464596af2f6f91fff511c3552103fdb0d510e

commit e22464596af2f6f91fff511c3552103fdb0d510e
Author:     Zsolt Udvari <uzsolt@FreeBSD.org>
AuthorDate: 2024-09-04 16:35:29 +0000
Commit:     Zsolt Udvari <uzsolt@FreeBSD.org>
CommitDate: 2024-09-04 16:44:53 +0000

    ftp/rexx-curl: Update to 2.1.1

    Add pkgconfig to USES.
    Switch to DISTVERSION.
    Remove obsolote patches.
    Pet portfmt.

    PR:             279775
    Approved by:    Bob Eager <bob@eager.cx> (maintainer)

 ftp/rexx-curl/Makefile                       | 14 ++---
 ftp/rexx-curl/distinfo                       |  6 +--
 ftp/rexx-curl/files/patch-Makefile.in (gone) | 78 ----------------------------
 ftp/rexx-curl/files/patch-rexxcurl.c (gone)  | 52 -------------------
 4 files changed, 10 insertions(+), 140 deletions(-)
Comment 7 Zsolt Udvari freebsd_committer freebsd_triage 2024-09-04 16:47:49 UTC
Committed, thanks!