Bug 279846

Summary: Update graphics/openshadinglanguage to v1.13.10.0
Product: Ports & Packages Reporter: Shane <FreeBSD>
Component: Individual Port(s)Assignee: Vladimir Druzenko <vvd>
Status: Closed FIXED    
Severity: Affects Only Me CC: vvd
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
URL: https://github.com/AcademySoftwareFoundation/OpenShadingLanguage/blob/main/CHANGES.md#release-113----beta-1-december-20-2023-compared-to-112
Bug Depends on:    
Bug Blocks: 279847    
Attachments:
Description Flags
maintainer update for graphics/openshadinglanguage
FreeBSD: maintainer-approval+
+ some tweaks
none
+ some tweaks
none
+ some tweaks vvd: maintainer-approval?

Description Shane 2024-06-19 01:07:59 UTC
Created attachment 251556 [details]
maintainer update for graphics/openshadinglanguage

Update graphics/openshadinglanguage to v1.13.10.0

assert fails on 32bit, so mark for 64bit arches only
Comment 1 Vladimir Druzenko freebsd_committer freebsd_triage 2024-06-19 03:19:27 UTC
graphics/py-openshadinglanguage/Makefile:
-PORTREVISION=   1
+PORTREVISION=   0
Comment 2 Shane 2024-06-19 09:35:49 UTC
yes the python slave should have the portrevision reset
Comment 3 Vladimir Druzenko freebsd_committer freebsd_triage 2024-06-20 02:49:37 UTC
Is llvm:max=15,lib still required?
Comment 4 Shane 2024-06-20 10:08:10 UTC
I don't know why it was added, and I haven't tested a variety of llvm versions for some time.

It was added in this commit - https://cgit.freebsd.org/ports/commit/graphics/openshadinglanguage/Makefile?id=45ac64aba3574207dcbaafd4d4edeffa090f72d1
Comment 5 Vladimir Druzenko freebsd_committer freebsd_triage 2024-06-25 22:51:17 UTC
It require llvm-config during configure stage.
We can remove max=15 if add -DCMAKE_CXX_STANDARD:INTEGER=17 - already tested.
I'll attach patch after finish testing.
Comment 6 Vladimir Druzenko freebsd_committer freebsd_triage 2024-06-27 11:28:11 UTC
Created attachment 251721 [details]
+ some tweaks
Comment 7 Vladimir Druzenko freebsd_committer freebsd_triage 2024-06-27 11:29:54 UTC
Created attachment 251722 [details]
+ some tweaks
Comment 8 Vladimir Druzenko freebsd_committer freebsd_triage 2024-06-27 11:30:35 UTC
It can build with LLVM from base now.
Comment 9 Vladimir Druzenko freebsd_committer freebsd_triage 2024-06-27 15:07:25 UTC
Created attachment 251726 [details]
+ some tweaks

Lost file graphics/openshadinglanguage/files/patch-CMakeLists.txt.
Comment 10 Shane 2024-06-28 02:57:17 UTC
Comment on attachment 251726 [details]
+ some tweaks

looks ok to me
Comment 11 commit-hook freebsd_committer freebsd_triage 2024-07-02 13:25:49 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=cfcb40e24056ca55e12b2b79fb7a78b112ccf6df

commit cfcb40e24056ca55e12b2b79fb7a78b112ccf6df
Author:     Shane <FreeBSD@ShaneWare.Biz>
AuthorDate: 2024-07-02 13:13:53 +0000
Commit:     Vladimir Druzenko <vvd@FreeBSD.org>
CommitDate: 2024-07-02 13:13:53 +0000

    graphics/{,py-}openshadinglanguage: update 1.12.14.0 → 1.13.10.0

    Changelog:
    https://github.com/AcademySoftwareFoundation/OpenShadingLanguage/releases/tag/v1.13.6.0-beta1
    https://github.com/AcademySoftwareFoundation/OpenShadingLanguage/releases/tag/v1.13.6.1
    https://github.com/AcademySoftwareFoundation/OpenShadingLanguage/releases/tag/v1.13.7.0
    https://github.com/AcademySoftwareFoundation/OpenShadingLanguage/releases/tag/v1.13.8.0
    https://github.com/AcademySoftwareFoundation/OpenShadingLanguage/releases/tag/v1.13.9.0
    https://github.com/AcademySoftwareFoundation/OpenShadingLanguage/releases/tag/v1.13.10.0

    PR:     279846

 graphics/openshadinglanguage/Makefile                  | 18 +++++++++++++-----
 graphics/openshadinglanguage/distinfo                  |  6 +++---
 .../files/patch-CMakeLists.txt (new)                   | 18 ++++++++++++++++++
 .../files/patch-src_liboslexec_CMakeLists.txt (gone)   | 11 -----------
 graphics/openshadinglanguage/pkg-plist                 |  7 +++++++
 graphics/py-openshadinglanguage/Makefile               |  2 +-
 6 files changed, 42 insertions(+), 20 deletions(-)
Comment 12 commit-hook freebsd_committer freebsd_triage 2024-07-04 17:24:53 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=38034248fe1b1dbd5fe4ff687b71b646612e9140

commit 38034248fe1b1dbd5fe4ff687b71b646612e9140
Author:     Vladimir Druzenko <vvd@FreeBSD.org>
AuthorDate: 2024-07-04 17:20:31 +0000
Commit:     Vladimir Druzenko <vvd@FreeBSD.org>
CommitDate: 2024-07-04 17:20:31 +0000

    graphics/openshadinglanguage: return accidentally deleted USES=llvm:lib

    PR:             279846
    Reported by:    fluffy (via IRC)
    Fixes:          cfcb40e24056 (update 1.12.14.0 → 1.13.10.0)
    MFH:            2024Q3

 graphics/openshadinglanguage/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 13 commit-hook freebsd_committer freebsd_triage 2024-07-04 17:26:55 UTC
A commit in branch 2024Q3 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=7ec92a0bbfd9be800103f39db0b3e71f6927f9af

commit 7ec92a0bbfd9be800103f39db0b3e71f6927f9af
Author:     Vladimir Druzenko <vvd@FreeBSD.org>
AuthorDate: 2024-07-04 17:20:31 +0000
Commit:     Vladimir Druzenko <vvd@FreeBSD.org>
CommitDate: 2024-07-04 17:25:28 +0000

    graphics/openshadinglanguage: return accidentally deleted USES=llvm:lib

    PR:             279846
    Reported by:    fluffy (via IRC)
    Fixes:          cfcb40e24056 (update 1.12.14.0 → 1.13.10.0)
    MFH:            2024Q3

    (cherry picked from commit 38034248fe1b1dbd5fe4ff687b71b646612e9140)

 graphics/openshadinglanguage/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)