Bug 279853

Summary: security/globalprotect-openconnect: taking over maintainer of this port
Product: Ports & Packages Reporter: Matthias Apitz <guru>
Component: Individual Port(s)Assignee: Olivier Cochard <olivier>
Status: Closed FIXED    
Severity: Affects Only Me CC: guru, olivier
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
patch with git-format-patch(1) for Makefile
none
corrected new patch none

Description Matthias Apitz 2024-06-19 09:13:32 UTC
Created attachment 251562 [details]
patch with git-format-patch(1) for Makefile

I'm willing to take over maintainer of security/globalprotect-openconnect .
Patch is attached.
Comment 1 Olivier Cochard freebsd_committer freebsd_triage 2024-06-21 08:05:12 UTC
Hi, the patch wasn’t in the correct form:
- The commit comment section contains data from the Makefile and doesn’t respect the expected layout;
- You don’t need to update PORTREVISION (because you don’t need to trigger a new build just for changing the maintainer name). Cf Chapter "5.2.3.1. PORTREVISION" in https://docs.freebsd.org/en/books/porters-handbook/book/

Could you submit a fixed patch ?
Thanks
Comment 2 Matthias Apitz 2024-06-21 16:23:46 UTC
Created attachment 251604 [details]
corrected new patch
Comment 3 commit-hook freebsd_committer freebsd_triage 2024-06-21 16:37:03 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=468c5e34ab61f841beedd91f0e620956b517d642

commit 468c5e34ab61f841beedd91f0e620956b517d642
Author:     Matthias Apitz <guru@unixarea.de>
AuthorDate: 2024-06-21 16:10:32 +0000
Commit:     Olivier Cochard <olivier@FreeBSD.org>
CommitDate: 2024-06-21 16:35:23 +0000

    security/globalprotect-openconnect: set maintainership

    PR:             279853

 security/globalprotect-openconnect/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)