Bug 279874
| Summary: | sysutils/eza: update to 0.18.19 | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Ken DEGUCHI <kdeguchi> | ||||||
| Component: | Individual Port(s) | Assignee: | Zsolt Udvari <uzsolt> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Only Me | CC: | uzsolt | ||||||
| Priority: | --- | ||||||||
| Version: | Latest | ||||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| URL: | https://github.com/eza-community/eza/releases/tag/v0.18.19 | ||||||||
| Attachments: |
|
||||||||
Hi Ken, thanks for patching. I suggest some modifications: Shell completion: doesn't need option and should always be installed. If you use option should enable it in OPTIONS_DEFAULT. Now they are disabled (doesn't install any completions). IMHO would be the best if you remove those options and install the completion files. https://docs.freebsd.org/en/books/porters-handbook/book/#shell-completion Manual page: if can download them and doesn't need huge depends IMHO can install them always (they aren't too big) so can remove the MANPAGE option too. The install of manual pages: can copy every file ("*") from source directory and can add to plist (without for-loop). If a new manpage will appear in a future release the testport will warn about orphaned file. Created attachment 251659 [details] Update to eza-0.18.19 (Removed OPTIONS_*) (In reply to Zsolt Udvari from comment #1) I have removed OPTIONS_* in Makefile. Thanks for your suggestion. Great work! Committed, thanks! A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=18026a7080a62e67e507bae20d0b0139121ab3f7 commit 18026a7080a62e67e507bae20d0b0139121ab3f7 Author: Ken DEGUCHI <kdeguchi@sz.tokoha-u.ac.jp> AuthorDate: 2024-06-24 13:03:29 +0000 Commit: Zsolt Udvari <uzsolt@FreeBSD.org> CommitDate: 2024-06-24 13:12:28 +0000 sysutils/eza: Update to 0.18.19 Remove shell completion options, install completions. Use shipped manual page instead of generating with pandoc, remove MANPAGES option. Use DIST_SUBDIR. Changelog: https://github.com/eza-community/eza/releases/tag/v0.18.19 PR: 279874 Approved by: Submitter is maintainer sysutils/eza/Makefile | 50 +-- sysutils/eza/Makefile.crates | 4 +- sysutils/eza/distinfo | 736 ++++++++++++++++++++++--------------------- 3 files changed, 385 insertions(+), 405 deletions(-) |
Created attachment 251589 [details] Update to eza-0.18.19 eza-0.18.19 has released. I have created a patch. -Cleaned up Makefile with portclippy. -Stopped generating man pages with pandoc and just downloaded them. -Since there are many files involved, they are collected in DIST_SUBDIR. If there are any problems, I will fix them. Thanks.