Bug 279905

Summary: www/gitlab: Fails to build at build-depends check, because of the dependency rubygem-grape>=2.0.0<2.1
Product: Ports & Packages Reporter: Yasuhito FUTATSUKI <freebsd-bug-report-yf>
Component: Individual Port(s)Assignee: Matthias Fechner <mfechner>
Status: Closed FIXED    
Severity: Affects Only Me CC: jontheil, laurent
Priority: --- Flags: bugzilla: maintainer-feedback? (mfechner)
Version: Latest   
Hardware: Any   
OS: Any   
Bug Depends on: 279980, 279984    
Bug Blocks:    

Description Yasuhito FUTATSUKI 2024-06-22 11:01:25 UTC 
The commit on devel/rubygem-grape

(https://cgit.freebsd.org/ports/commit/?id=656f3fb43c1edac1b2ba32fce8a36a35f62d6daa)
> commit 656f3fb43c1edac1b2ba32fce8a36a35f62d6daa
> Author: Po-Chuan Hsieh <sunpoet@FreeBSD.org>
> Date:   Tue Jun 18 22:26:23 2024 +0800
> 
>     devel/rubygem-grape: Update to 2.1.0
>     
>     - Update WWW
>     
>     Changes:        https://github.com/ruby-grape/grape/blob/master/CHANGELOG.md
> 

broke the dependency on www/gitlab.
Comment 1 Matthias Fechner freebsd_committer freebsd_triage 2024-06-22 16:55:07 UTC 
I currently test a fix for this.
Comment 2 Matthias Fechner freebsd_committer freebsd_triage 2024-06-22 17:03:34 UTC 
My tests showed another problem:
==> /usr/local/www/gitlab/log/puma.stderr.log <==
ld-elf.so.1: /usr/local/lib/libgrpc.so.39: Undefined symbol "_ZN4absl12lts_202301254CordC1INSt3__112basic_stringIcNS3_11char_traitsIcEENS3_9allocatorIcEEEETnNS3_9enable_ifIXsr3std7is_sameIT_S9_EE5valueEiE4typeELi0EEEOSB_"

This will require more time to find the reason why that fails.
Comment 3 commit-hook freebsd_committer freebsd_triage 2024-06-27 04:50:15 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=dab7167fbf684a5b578354cde054cfb4126bfd70

commit dab7167fbf684a5b578354cde054cfb4126bfd70
Author:     Matthias Fechner <mfechner@FreeBSD.org>
AuthorDate: 2024-06-22 16:06:12 +0000
Commit:     Matthias Fechner <mfechner@FreeBSD.org>
CommitDate: 2024-06-27 04:38:59 +0000

    devel/rubygem-grape20: fix regression from 656f3fb43c1edac1b2ba32fce8a36a35f62d6daa

    Make version 2.0 available that is required by gitlab.

    PR:             279905

 devel/Makefile                        |  1 +
 devel/rubygem-grape20/Makefile (new)  | 28 ++++++++++++++++++++++++++++
 devel/rubygem-grape20/distinfo (new)  |  3 +++
 devel/rubygem-grape20/pkg-descr (new) |  1 +
 4 files changed, 33 insertions(+)
Comment 4 commit-hook freebsd_committer freebsd_triage 2024-06-27 04:50:18 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=ec44878c022040ea2a2d19a0f02ee72fbdce5811

commit ec44878c022040ea2a2d19a0f02ee72fbdce5811
Author:     Matthias Fechner <mfechner@FreeBSD.org>
AuthorDate: 2024-06-22 16:09:47 +0000
Commit:     Matthias Fechner <mfechner@FreeBSD.org>
CommitDate: 2024-06-27 04:38:59 +0000

    www/gitlab: fix regression from 656f3fb43c1edac1b2ba32fce8a36a35f62d6daa

    Use grape 2.0

    PR:             279905

 www/gitlab/Makefile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Comment 5 Matthias Fechner freebsd_committer freebsd_triage 2024-06-27 12:10:58 UTC 
It seem(In reply to Matthias Fechner from comment #2)
If you see this problem, I was able to fix it by upgrading abseil from here:
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=275887
Comment 6 Laurent Daverio 2024-06-28 11:26:40 UTC 
(In reply to Matthias Fechner from comment #5)

Hi Matthias,

I also had the `libgrpc.so.39` error message after updating to Gitlab CE 17.0.3.

Following your suggestion, I've just reinstalled abseil (version abseil-20230125.3), it seems to have fixed it.

Thanks for the tip,

Laurent.
Comment 7 Yasuhito FUTATSUKI 2024-06-30 10:51:37 UTC 
(In reply to Laurent Daverio from comment #6)
I also confirmed that gitlab-ce 17.0.3 on FreeBSD 14.1-RELEASE-p1 can run with abseil-20230125.3 (but newly built on FreeBSD 14.1-RELEASE-p1).
Comment 8 Matthias Fechner freebsd_committer freebsd_triage 2024-07-04 06:56:55 UTC 
(In reply to Yasuhito FUTATSUKI from comment #7)
I will close the issue for now.
I think the source of the problem is related to abseil and it maybe needs a PORTREVISION bump to fix the problem I found with the error message:
==> /usr/local/www/gitlab/log/puma.stderr.log <==
ld-elf.so.1: /usr/local/lib/libgrpc.so.39: Undefined symbol "_ZN4absl12lts_202301254CordC1INSt3__112basic_stringIcNS3_11char_traitsIcEENS3_9allocatorIcEEEETnNS3_9enable_ifIXsr3std7is_sameIT_S9_EE5valueEiE4typeELi0EEEOSB_"

But this is not directly related to this topic here.
Comment 9 Yasuhito FUTATSUKI 2024-07-04 07:38:22 UTC 
(In reply to Matthias Fechner from comment #8)
Sure, it is.

Anyways, thank you for the resolution of this problem.