Bug 280143
| Summary: | multimedia/kodi: Fix fallout caused by taglib | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | yzrh <yzrh> | ||||||||
| Component: | Individual Port(s) | Assignee: | Bernhard Froehlich <decke> | ||||||||
| Status: | Closed FIXED | ||||||||||
| Severity: | Affects Only Me | CC: | decke | ||||||||
| Priority: | --- | ||||||||||
| Version: | Latest | ||||||||||
| Hardware: | Any | ||||||||||
| OS: | Any | ||||||||||
| Attachments: |
|
||||||||||
Created attachment 251888 [details]
testport log (bzip2), on a 64 bit platform
I'll take it Build works on amd64 but still fails on i386. Is this expected? https://ports.bluelife.at/builds/20240719-19:46:31.98948/ Created attachment 252196 [details]
Fix data type
Ah, I forgot the other part. I really need a 32 bit test environment.
I am not confident without some runtime testing.
The patch builds fine. https://ports.bluelife.at/builds/20240804-20:10:49.43982/ Is it okay to commit it or do you want to perform some runtime test first? Let's get it in. It builds and seems to work. Thanks again. A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=8d205087923f2b58fed8801c2681a41f074c4368 commit 8d205087923f2b58fed8801c2681a41f074c4368 Author: yzrh <yzrh@noema.org> AuthorDate: 2024-08-06 07:59:40 +0000 Commit: Bernhard Froehlich <decke@FreeBSD.org> CommitDate: 2024-08-06 07:59:40 +0000 multimedia/kodi: Fix fallout caused by recent taglib update PR: 280143 Submitted by: yzrh@noema.org (maintainer) multimedia/kodi/Makefile | 2 +- ...patch-xbmc_music_tags_TagLibVFSStream.cpp (new) | 47 ++++++++++++++++++++++ .../patch-xbmc_music_tags_TagLibVFSStream.h (new) | 41 +++++++++++++++++++ 3 files changed, 89 insertions(+), 1 deletion(-) Committed and merged to quarterly branch. Thanks! A commit in branch 2024Q3 references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=d6df94a68f4185bb5ffb1116988bc0a6d64b83e5 commit d6df94a68f4185bb5ffb1116988bc0a6d64b83e5 Author: yzrh <yzrh@noema.org> AuthorDate: 2024-08-06 07:59:40 +0000 Commit: Bernhard Froehlich <decke@FreeBSD.org> CommitDate: 2024-08-06 08:11:14 +0000 multimedia/kodi: Fix fallout caused by recent taglib update PR: 280143 Submitted by: yzrh@noema.org (maintainer) (cherry picked from commit 8d205087923f2b58fed8801c2681a41f074c4368) multimedia/kodi/Makefile | 2 +- ...patch-xbmc_music_tags_TagLibVFSStream.cpp (new) | 47 ++++++++++++++++++++++ .../patch-xbmc_music_tags_TagLibVFSStream.h (new) | 41 +++++++++++++++++++ 3 files changed, 89 insertions(+), 1 deletion(-) |
Created attachment 251887 [details] Match taglib's data type Taglib has changed some data types in 2.0, making some platform dependent (size_t). This breaks Kodi on i386 and perhaps other 32 bit platforms.