Bug 280144
| Summary: | audio/alsa-plugins: update 1.2.7.1 → 1.2.12 | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Vladimir Druzenko <vvd> | ||||
| Component: | Individual Port(s) | Assignee: | Vladimir Druzenko <vvd> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Some People | CC: | pmc, rodrigo | ||||
| Priority: | --- | Flags: | vvd:
maintainer-feedback?
(rodrigo) |
||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| URL: | https://github.com/alsa-project/alsa-plugins/releases/tag/v1.2.12 | ||||||
| Attachments: |
|
||||||
|
Description
Vladimir Druzenko
2024-07-05 21:34:24 UTC
Rodrigo, ping. (-: I'll commit it soon. If rodrigo@ is against changing the maintainer, then I will return the old value ports@. A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=1a782b3157860d35e79a7b9dceb50bee7a7b7684 commit 1a782b3157860d35e79a7b9dceb50bee7a7b7684 Author: Vladimir Druzenko <vvd@FreeBSD.org> AuthorDate: 2024-07-25 18:45:39 +0000 Commit: Vladimir Druzenko <vvd@FreeBSD.org> CommitDate: 2024-07-25 18:50:52 +0000 audio/alsa-plugins: update 1.2.7.1 → 1.2.12 Also: * refresh patches; * change maintainer from ports@ to rodrigo@ - maintainer other alsa ports: audio/alsa-lib audio/alsa-utils (if he is against changing the maintainer, then I will return the old value ports@). PR: 280144 Approved by: rodrigo (maintainer, timeout > 2 weeks) audio/alsa-plugins/Makefile | 5 ++- audio/alsa-plugins/distinfo | 6 ++-- .../alsa-plugins/files/patch-arcam-av_arcam__av.c | 18 +++------- audio/alsa-plugins/files/patch-configure | 40 +++++++++++----------- .../files/patch-jack_pcm__jack.c (gone) | 11 ------ audio/alsa-plugins/files/patch-oss_ctl__oss.c | 20 +++-------- audio/alsa-plugins/files/patch-oss_pcm__oss.c | 34 +++++++++--------- .../files/patch-usb__stream_pcm__usb__stream.c | 8 ++--- 8 files changed, 54 insertions(+), 88 deletions(-) A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=c22f1829dc74ce7c1488b4e4269ff42726be96aa commit c22f1829dc74ce7c1488b4e4269ff42726be96aa Author: Vladimir Druzenko <vvd@FreeBSD.org> AuthorDate: 2024-07-26 12:17:13 +0000 Commit: Vladimir Druzenko <vvd@FreeBSD.org> CommitDate: 2024-07-26 12:21:43 +0000 audio/alsa-plugins: return maintainer to ports@ PR: 280144 Reported by: diizzy (via email) Fixes: 1a782b315786 (update 1.2.7.1 → 1.2.12) audio/alsa-plugins/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Sorry, this doesn't seem to work. With JACK enabled, I get this error:
pcm_jack.c:606:23: error: use of undeclared identifier 'program_invocation_short_name'
606 | const char *pname = program_invocation_short_name;
| ^
1 error generated.
*** [pcm_jack.lo] Error code 1
make[2]: stopped in /usr/ports/audio/alsa-plugins/work/alsa-plugins-1.2.12/jack
1 error
Formerly there was a patch 'patch-jack_pcm__jack.c', now there is a compile conditional '_GNU_SOURCE', but that appears to be always set in line #23.
(In reply to Peter Much from comment #5) https://www.gnu.org/software/gnulib/manual/html_node/program_005finvocation_005fshort_005fname.html https://github.com/alsa-project/alsa-plugins/pull/48 Can you test runtime with this patch (files/patch-jack_pcm__jack.c): --- jack/pcm_jack.c.orig 2024-06-10 09:18:39 UTC +++ jack/pcm_jack.c @@ -602,7 +602,7 @@ static int snd_pcm_jack_open(snd_pcm_t **pcmp, const c } if (client_name == NULL) { -#if defined(_GNU_SOURCE) +#if defined(_GNU_SOURCE) && defined(__linux__) const char *pname = program_invocation_short_name; #else const char *pname = getprogname(); Build went without errors, but I don't use jack. (In reply to Vladimir Druzenko from comment #6) Hehe, I didn't use ALSA yet. This came to me as a prereq from otter-browser -> webengine -> alsa-plugins, so I switched on JACK in the hope to get some more outputs routed into that patchbay. Now I did a dive into ALSA, and indeed it works as intended. Even chrome does now feed into JACK, I love it. Thank You! :) A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=65906cb5ed4261a7cb92f3fd08e75ee08ef159a1 commit 65906cb5ed4261a7cb92f3fd08e75ee08ef159a1 Author: Vladimir Druzenko <vvd@FreeBSD.org> AuthorDate: 2024-10-17 22:27:28 +0000 Commit: Vladimir Druzenko <vvd@FreeBSD.org> CommitDate: 2024-10-17 22:32:14 +0000 audio/alsa-plugins: Fix build with JACK option: use of undeclared identifier 'program_invocation_short_name' pcm_jack.c:606:23: error: use of undeclared identifier 'program_invocation_short_name' 606 | const char *pname = program_invocation_short_name; | ^ 1 error generated. Upstream broke build on FreeBSD in commit: https://github.com/alsa-project/alsa-plugins/commit/13a645e55a740dfa43bb3518da3f580c90be7eac Pool request: https://github.com/alsa-project/alsa-plugins/pull/48 PR: 280144 Reported by: Peter Much <pmc@citylink.dinoex.sub.org> Tested by: Peter Much <pmc@citylink.dinoex.sub.org> Fixes: 1a782b315786 (update 1.2.7.1 → 1.2.12) MFH: 2024Q4 audio/alsa-plugins/files/patch-jack_pcm__jack.c (new) | 11 +++++++++++ 1 file changed, 11 insertions(+) A commit in branch 2024Q4 references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=74ae766765f218beaee33a4dac47413d58efdf21 commit 74ae766765f218beaee33a4dac47413d58efdf21 Author: Vladimir Druzenko <vvd@FreeBSD.org> AuthorDate: 2024-10-17 22:27:28 +0000 Commit: Vladimir Druzenko <vvd@FreeBSD.org> CommitDate: 2024-10-17 22:33:38 +0000 audio/alsa-plugins: Fix build with JACK option: use of undeclared identifier 'program_invocation_short_name' pcm_jack.c:606:23: error: use of undeclared identifier 'program_invocation_short_name' 606 | const char *pname = program_invocation_short_name; | ^ 1 error generated. Upstream broke build on FreeBSD in commit: https://github.com/alsa-project/alsa-plugins/commit/13a645e55a740dfa43bb3518da3f580c90be7eac Pool request: https://github.com/alsa-project/alsa-plugins/pull/48 PR: 280144 Reported by: Peter Much <pmc@citylink.dinoex.sub.org> Tested by: Peter Much <pmc@citylink.dinoex.sub.org> Fixes: 1a782b315786 (update 1.2.7.1 → 1.2.12) MFH: 2024Q4 (cherry picked from commit 65906cb5ed4261a7cb92f3fd08e75ee08ef159a1) audio/alsa-plugins/files/patch-jack_pcm__jack.c (new) | 11 +++++++++++ 1 file changed, 11 insertions(+) |