Bug 280180

Summary: [patch] net/nrpe may fail to build for ports users
Product: Ports & Packages Reporter: Eugene Grosbein <eugen>
Component: Individual Port(s)Assignee: Muhammad Moinur Rahman <bofh>
Status: Closed FIXED    
Severity: Affects Some People Keywords: easy, patch-ready
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
fix to the problem eugen: maintainer-approval?

Description Eugene Grosbein freebsd_committer freebsd_triage 2024-07-07 14:57:16 UTC 
If net-mgmt/nrpe version 4.1.0 is built not within clean release environment but for users of FreeBSD source update path (13.2 -> 13.3-STABLE f.e.), port building process may fail:

===>  Building for nrpe-4.1.0
make: "/data/ports-work/usr/ports/net-mgmt/nrpe/work/nrpe-nrpe-4.1.0/Makefile" line 42: Invalid line type
make: "/data/ports-work/usr/ports/net-mgmt/nrpe/work/nrpe-nrpe-4.1.0/Makefile" line 43: Invalid line type
make: Fatal errors encountered -- cannot continue
make: stopped in /data/ports-work/usr/ports/net-mgmt/nrpe/work/nrpe-nrpe-4.1.0
===> Compilation failed unexpectedly.

That's because of a bug in the distfile's "configure" script that may insert garbage to generated Makefile. The problem may be worked around easily with an addition to port's CONFIGURE_ARGS: --with-inetd-type=inetd

If you approve, I can commit attached patch myself.
Comment 1 Eugene Grosbein freebsd_committer freebsd_triage 2024-07-07 14:58:13 UTC 
Created attachment 251924 [details]
fix to the problem
Comment 2 Muhammad Moinur Rahman freebsd_committer freebsd_triage 2024-07-28 16:39:35 UTC 
Sorry for the delayed response. Am looking into it.
Comment 3 commit-hook freebsd_committer freebsd_triage 2024-07-28 17:11:24 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=6eec36c45b04c6d437453378dac08171775b2825

commit 6eec36c45b04c6d437453378dac08171775b2825
Author:     Muhammad Moinur Rahman <bofh@FreeBSD.org>
AuthorDate: 2024-07-28 17:08:53 +0000
Commit:     Muhammad Moinur Rahman <bofh@FreeBSD.org>
CommitDate: 2024-07-28 17:08:53 +0000

    net-mgmt/nrpe: Fix permission on /var

    - Fix build for ports users [1]

    PR:             277704, 280180 [1]
    Reported by:    sr@genyosha.net, eugen [1]

 net-mgmt/nrpe/Makefile  | 8 +++++---
 net-mgmt/nrpe/pkg-plist | 1 -
 2 files changed, 5 insertions(+), 4 deletions(-)