Bug 280358
| Summary: | x11-fonts/fontconfig: %%LOCALBASE%% isn't replaced in pkg-message | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | sjrbulk | ||||
| Component: | Individual Port(s) | Assignee: | freebsd-desktop (Team) <desktop> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | CC: | arrowd, eduardo | ||||
| Priority: | --- | Keywords: | easy | ||||
| Version: | Latest | Flags: | arrowd:
maintainer-feedback+
eduardo: merge-quarterly+ |
||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
Created attachment 252166 [details] Fix pkg-message https://docs.freebsd.org/en/books/porters-handbook/book/#using-sub-files The file should be moved to files/pkg-message.in, I think. (In reply to Gleb Popov from comment #2) That change is included in patch: <snip> diff --git a/x11-fonts/fontconfig/pkg-message b/x11-fonts/fontconfig/files/pkg-message.in similarity index 100% rename from x11-fonts/fontconfig/pkg-message rename to x11-fonts/fontconfig/files/pkg-message.in Tested with pkg-message 'type: install' and localbase shows correctly. I think we are fine to commit. (In reply to Nuno Teixeira from comment #3) Strange, the raw patch uploaded to Bugzilla does not have this hunk: https://bz-attachments.freebsd.org/attachment.cgi?id=252166&action=diff&format=raw&headers=1 (In reply to Gleb Popov from comment #5) It shows on patch details: https://bugs.freebsd.org/bugzilla/attachment.cgi?id=252166&action=edit Hmm, indeed. Bugzilla behaves strange on that. This is good to go then, thank you. A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=0fff9ad2c85297b26e2f181b051480075015bb86 commit 0fff9ad2c85297b26e2f181b051480075015bb86 Author: Nuno Teixeira <eduardo@FreeBSD.org> AuthorDate: 2024-07-20 08:07:28 +0000 Commit: Nuno Teixeira <eduardo@FreeBSD.org> CommitDate: 2024-07-20 08:07:28 +0000 x11-fonts/fontconfig: Fix pkg-message %%LOCALBASE%% replacement PR: 280358 Reported by: sjrbulk@verizon.net Approved by: arrowd MFH: 2024Q3 x11-fonts/fontconfig/Makefile | 5 ++++- x11-fonts/fontconfig/{pkg-message => files/pkg-message.in} | 0 2 files changed, 4 insertions(+), 1 deletion(-) A commit in branch 2024Q3 references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=a87b77d09215b5e38fe5ddcbe473f1656d7cf82b commit a87b77d09215b5e38fe5ddcbe473f1656d7cf82b Author: Nuno Teixeira <eduardo@FreeBSD.org> AuthorDate: 2024-07-20 08:07:28 +0000 Commit: Nuno Teixeira <eduardo@FreeBSD.org> CommitDate: 2024-07-20 08:13:55 +0000 x11-fonts/fontconfig: Fix pkg-message %%LOCALBASE%% replacement PR: 280358 Reported by: sjrbulk@verizon.net Approved by: arrowd MFH: 2024Q3 (cherry picked from commit 0fff9ad2c85297b26e2f181b051480075015bb86) x11-fonts/fontconfig/Makefile | 5 ++++- x11-fonts/fontconfig/{pkg-message => files/pkg-message.in} | 0 2 files changed, 4 insertions(+), 1 deletion(-) Committed, thanks! |
When installing this port, the line in the pkg-message file: find %%LOCALBASE%%/share/fonts -type f -name .uuid doesn't have %%LOCALBASE%% replaced with the correct location.