Bug 280465

Summary: security/libretls: error: redefinition of 'arc4random_buf'
Product: Ports & Packages Reporter: Dan Kotowski <dan.kotowski>
Component: Individual Port(s)Assignee: Baptiste Daroussin <bapt>
Status: Closed FIXED    
Severity: Affects Only Me Flags: bugzilla: maintainer-feedback? (bapt)
Priority: ---    
Version: Latest   
Hardware: amd64   
OS: Any   
Attachments:
Description Flags
poudriere bulk -j FreeBSD:15:amd64 -p latest security/libretls none

Description Dan Kotowski 2024-07-27 09:40:53 UTC 
Created attachment 252315 [details]
poudriere bulk -j FreeBSD:15:amd64 -p latest security/libretls

port directory: /usr/ports/security/libretls
package name: libretls-3.8.1_1
building for: FreeBSD pkg1.a9development.com 15.0-CURRENT FreeBSD 15.0-CURRENT 1500021 amd64
maintained by: bapt@FreeBSD.org
Makefile datestamp: -rw-r--r--  1 root wheel 451 Jan 29 15:32 /usr/ports/security/libretls/Makefile
Ports top last git commit: c4f4e17ea7
Ports top unclean checkout: no
Port dir last git commit: 0ef221ab62
Port dir unclean checkout: no
Poudriere version: poudriere-git-3.4.1_1
Host OSVERSION: 1500021
Jail OSVERSION: 1500021



--- compat/libcompat_la-arc4random.lo ---
compat/arc4random.c:197:1: error: redefinition of 'arc4random_buf'
  197 | arc4random_buf(void *buf, size_t n)
      | ^
/usr/include/ssp/stdlib.h:38:22: note: previous definition is here
   38 | __ssp_redirect(void, arc4random_buf, (void *__buf, size_t __len),
      |                      ^
1 error generated.
*** [compat/libcompat_la-arc4random.lo] Error code 1
Comment 1 commit-hook freebsd_committer freebsd_triage 2024-09-17 07:32:39 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=7d7a24910c6abe868ee5131205f27dae10a5d1d9

commit 7d7a24910c6abe868ee5131205f27dae10a5d1d9
Author:     Baptiste Daroussin <bapt@FreeBSD.org>
AuthorDate: 2024-09-17 07:27:22 +0000
Commit:     Baptiste Daroussin <bapt@FreeBSD.org>
CommitDate: 2024-09-17 07:28:56 +0000

    security/libretls: do not use builtin arc4random_buf

    The issue upstream had with FreeBSD's arc4random_buf are not valid
    anymore.

    PR:     280465

 security/libretls/Makefile                    |  2 +-
 security/libretls/files/patch-configure (new) | 12 ++++++++++++
 2 files changed, 13 insertions(+), 1 deletion(-)