Bug 28078

Summary:	/stand/sysinstall skips distro selection after choosing "no" at final prompt
Product:	Base System	Reporter:	cynic <cynic>
Component:	conf	Assignee:	freebsd-qa (Nobody) <qa>
Status:	Closed FIXED
Severity:	Affects Only Me
Priority:	Normal
Version:	4.3-RELEASE
Hardware:	Any
OS:	Any

Description cynic 2001-06-11 18:50:00 UTC

(appended uname -a shows a custom kernel, but this happens with GENERIC, too)

"Standard install" -- when you choose "cancel" or "no" after the distro selection, /stand/sysinstall won't let you select a distro again.

How-To-Repeat: Take a 4.3-RELEASE CD, select "Standard Install", proceed all the way to the "Last chance" dialog, answer "no". Repeat the install. Distro selection is skipped.

Comment 1 Murray Stokely freebsd_committer

2001-09-05 11:33:41 UTC

State Changed
From-To: open->analyzed

A follow up has been sent.  The best solution is probably to ask the user somehow if they would like to reconfigure there distributions.

Comment 2 Murray Stokely freebsd_committer

2001-09-05 11:38:03 UTC

  Hmm, this patch is a quick fix, but I'm not certain that this does
the correct thing.  For which cases would you expect sysinstall to
remember your dists and when do you want to start over with a clean
plate?  It could be considered a feature that sysinstall remembers
your dists for you when you cancel an install in progress.  Thoughts?

      - Murray

Index: install.c
===================================================================
RCS file: /home/ncvs/src/usr.sbin/sysinstall/install.c,v
retrieving revision 1.305
diff -u -r1.305 install.c
--- install.c	2001/09/05 00:45:13	1.305
+++ install.c	2001/09/05 10:24:07
@@ -539,6 +539,14 @@
     if (DITEM_STATUS(diskLabelEditor(self)) == DITEM_FAILURE)
     return DITEM_FAILURE;
 
+    /* During a standard interactive installation, we want to be
+       prompted to make a selection of distfiles.  Without this, if we
+       go partially through an install, and then abort, we can't
+       reselect our distributions again. */
+
+    if (!variable_get(VAR_NONINTERACTIVE))
+    distReset(NULL);	
+
     if (DITEM_STATUS((i = installCommit(self))) == DITEM_FAILURE) {
     dialog_clear();
     msgConfirm("Installation completed with some errors.  You may wish to\n"

Comment 3 Murray Stokely freebsd_committer

2002-03-27 13:07:23 UTC

Responsible Changed
From-To: freebsd-bugs->freebsd-qa

Patch posted, thoughts?

Comment 4 Tom Rhodes freebsd_committer

2003-01-13 21:19:29 UTC

State Changed
From-To: analyzed->closed

I cannot reproduce this `bug'.  Closed.