Bug 280783

Summary: math/blis: fix build with clang 19
Product: Ports & Packages Reporter: Dimitry Andric <dim>
Component: Individual Port(s)Assignee: Johannes M Dieterich <jmd>
Status: Closed FIXED    
Severity: Affects Some People Flags: bugzilla: maintainer-feedback? (jmd)
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
Bug Depends on:    
Bug Blocks: 280562    
Attachments:
Description Flags
math/blis: fix build with clang 19 none

Description Dimitry Andric freebsd_committer freebsd_triage 2024-08-12 19:30:54 UTC 
Clang 19 has removed support for the -mavx512pf and -mavx512er flags,
for the Intel Xeon Phi (aka "Knights Landing"/knl or "Knights
Mill"/knm) [1] [2].

This causes fatal errors during configuration of math/blis:

    Compiling obj/x86_64/kernels/knl/1m/bli_dpackm_knl_asm_24x8.o ('knl' CFLAGS for kernels)
    cc: fatal error: unknown argument '-mavx512pf'; did you mean '-mavx512f'?
    gmake: *** [Makefile:653: obj/x86_64/kernels/knl/1m/bli_dpackm_knl_asm_24x8.o] Error 1

Add an EXTRA_PATCHES entry to deal with this situation.

Note that in the future, this may also have to be done for gcc 15 and
later. In that case, the patch might be done unconditionally.

[1] https://github.com/llvm/llvm-project/pull/75580
[2] https://github.com/llvm/llvm-project/pull/92883
Comment 1 Dimitry Andric freebsd_committer freebsd_triage 2024-08-12 19:32:54 UTC 
Created attachment 252720 [details]
math/blis: fix build with clang 19
Comment 2 commit-hook freebsd_committer freebsd_triage 2024-08-27 07:34:13 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=885ff9ed357775138732cd058046d4e00b77287d

commit 885ff9ed357775138732cd058046d4e00b77287d
Author:     Dimitry Andric <dim@FreeBSD.org>
AuthorDate: 2024-08-12 19:31:50 +0000
Commit:     Dimitry Andric <dim@FreeBSD.org>
CommitDate: 2024-08-27 07:33:02 +0000

    math/blis: fix build with clang 19

    Clang 19 has removed support for the -mavx512pf and -mavx512er flags,
    for the Intel Xeon Phi (aka "Knights Landing"/knl or "Knights
    Mill"/knm) [1] [2].

    This causes fatal errors during configuration of math/blis:

        Compiling obj/x86_64/kernels/knl/1m/bli_dpackm_knl_asm_24x8.o ('knl' CFLAGS for kernels)
        cc: fatal error: unknown argument '-mavx512pf'; did you mean '-mavx512f'?
        gmake: *** [Makefile:653: obj/x86_64/kernels/knl/1m/bli_dpackm_knl_asm_24x8.o] Error 1

    Add an EXTRA_PATCHES entry to deal with this situation.

    Note that in the future, this may also have to be done for gcc 15 and
    later. In that case, the patch might be done unconditionally.

    [1] https://github.com/llvm/llvm-project/pull/75580
    [2] https://github.com/llvm/llvm-project/pull/92883

    PR:             280783
    Approved by:    maintainer timeout (2 weeks)
    MFH:            2024Q3

 math/blis/Makefile                                   |  4 ++++
 .../files/extra-patch-config_knl_make__defs.mk (new) | 20 ++++++++++++++++++++
 2 files changed, 24 insertions(+)
Comment 3 commit-hook freebsd_committer freebsd_triage 2024-08-27 07:40:15 UTC 
A commit in branch 2024Q3 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=37d0117bb4ca5b6e25c9575688b56258362bfdb4

commit 37d0117bb4ca5b6e25c9575688b56258362bfdb4
Author:     Dimitry Andric <dim@FreeBSD.org>
AuthorDate: 2024-08-12 19:31:50 +0000
Commit:     Dimitry Andric <dim@FreeBSD.org>
CommitDate: 2024-08-27 07:39:04 +0000

    math/blis: fix build with clang 19

    Clang 19 has removed support for the -mavx512pf and -mavx512er flags,
    for the Intel Xeon Phi (aka "Knights Landing"/knl or "Knights
    Mill"/knm) [1] [2].

    This causes fatal errors during configuration of math/blis:

        Compiling obj/x86_64/kernels/knl/1m/bli_dpackm_knl_asm_24x8.o ('knl' CFLAGS for kernels)
        cc: fatal error: unknown argument '-mavx512pf'; did you mean '-mavx512f'?
        gmake: *** [Makefile:653: obj/x86_64/kernels/knl/1m/bli_dpackm_knl_asm_24x8.o] Error 1

    Add an EXTRA_PATCHES entry to deal with this situation.

    Note that in the future, this may also have to be done for gcc 15 and
    later. In that case, the patch might be done unconditionally.

    [1] https://github.com/llvm/llvm-project/pull/75580
    [2] https://github.com/llvm/llvm-project/pull/92883

    PR:             280783
    Approved by:    maintainer timeout (2 weeks)
    MFH:            2024Q3

    (cherry picked from commit 885ff9ed357775138732cd058046d4e00b77287d)

 math/blis/Makefile                                   |  4 ++++
 .../files/extra-patch-config_knl_make__defs.mk (new) | 20 ++++++++++++++++++++
 2 files changed, 24 insertions(+)