Bug 280791
| Summary: | textproc/zxing-cpp: fix build with libc++ 19 | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Dimitry Andric <dim> | ||||
| Component: | Individual Port(s) | Assignee: | freebsd-kde (group) <kde> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Some People | CC: | tcberner | ||||
| Priority: | --- | Flags: | tcberner:
maintainer-feedback+
|
||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 280562 | ||||||
| Attachments: |
|
||||||
Created attachment 252726 [details]
textproc/zxing-cpp: fix build with libc++ 19
Comment on attachment 252726 [details]
textproc/zxing-cpp: fix build with libc++ 19
Moin moin
Please feel free to just directly push compiler related fixes to the tree.
Thanks for your work!
mfg Tobias
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=43d0c7131e80e98445045b1d17a6054db1c6369d commit 43d0c7131e80e98445045b1d17a6054db1c6369d Author: Dimitry Andric <dim@FreeBSD.org> AuthorDate: 2024-08-13 10:01:40 +0000 Commit: Dimitry Andric <dim@FreeBSD.org> CommitDate: 2024-08-16 15:35:26 +0000 textproc/zxing-cpp: fix build with libc++ 19 As noted in the libc++ 19 release notes [1], std::char_traits<> is now only provided for char, char8_t, char16_t, char32_t and wchar_t, and any instantiation for other types will fail. This causes textproc/zxing-cpp to fail to compile with clang 19 and libc++ 19, resulting in errors similar to: /usr/include/c++/v1/string_view:300:42: error: implicit instantiation of undefined template 'std::char_traits<unsigned char>' 300 | static_assert(is_same<_CharT, typename traits_type::char_type>::value, | ^ /wrkdirs/usr/ports/textproc/zxing-cpp/work/zxing-cpp-2.2.1/core/src/Utf.cpp:72:42: note: in instantiation of template class 'std::basic_string_view<unsigned char>' requested here 72 | static size_t Utf8CountCodePoints(utf8_t utf8) | ^ /usr/include/c++/v1/__string/char_traits.h:45:8: note: template is declared here 45 | struct char_traits; | ^ `utf8_t` is effectively defined as `std::basic_string<uint8_t>`, which is no longer possible. So redefine it as a `std::vector<uint8_t>` instead. This requires only a small adjustment in one other place: replacing the initializer list in the `AppendFromUtf8` call in `FromUtf8`. [1] https://libcxx.llvm.org/ReleaseNotes/19.html#deprecations-and-removals PR: 280791 Approved by: tcberner (maintainer) MFH: 2024Q3 .../zxing-cpp/files/patch-core_src_Utf.cpp (new) | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) A commit in branch 2024Q3 references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=459baf8a44da4f346e7e9a2160f82fe4ccf6631e commit 459baf8a44da4f346e7e9a2160f82fe4ccf6631e Author: Dimitry Andric <dim@FreeBSD.org> AuthorDate: 2024-08-13 10:01:40 +0000 Commit: Dimitry Andric <dim@FreeBSD.org> CommitDate: 2024-08-16 15:44:18 +0000 textproc/zxing-cpp: fix build with libc++ 19 As noted in the libc++ 19 release notes [1], std::char_traits<> is now only provided for char, char8_t, char16_t, char32_t and wchar_t, and any instantiation for other types will fail. This causes textproc/zxing-cpp to fail to compile with clang 19 and libc++ 19, resulting in errors similar to: /usr/include/c++/v1/string_view:300:42: error: implicit instantiation of undefined template 'std::char_traits<unsigned char>' 300 | static_assert(is_same<_CharT, typename traits_type::char_type>::value, | ^ /wrkdirs/usr/ports/textproc/zxing-cpp/work/zxing-cpp-2.2.1/core/src/Utf.cpp:72:42: note: in instantiation of template class 'std::basic_string_view<unsigned char>' requested here 72 | static size_t Utf8CountCodePoints(utf8_t utf8) | ^ /usr/include/c++/v1/__string/char_traits.h:45:8: note: template is declared here 45 | struct char_traits; | ^ `utf8_t` is effectively defined as `std::basic_string<uint8_t>`, which is no longer possible. So redefine it as a `std::vector<uint8_t>` instead. This requires only a small adjustment in one other place: replacing the initializer list in the `AppendFromUtf8` call in `FromUtf8`. [1] https://libcxx.llvm.org/ReleaseNotes/19.html#deprecations-and-removals PR: 280791 Approved by: tcberner (maintainer) MFH: 2024Q3 (cherry picked from commit 43d0c7131e80e98445045b1d17a6054db1c6369d) .../zxing-cpp/files/patch-core_src_Utf.cpp (new) | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) |
As noted in the libc++ 19 release notes [1], std::char_traits<> is now only provided for char, char8_t, char16_t, char32_t and wchar_t, and any instantiation for other types will fail. This causes textproc/zxing-cpp to fail to compile with clang 19 and libc++ 19, resulting in errors similar to: /usr/include/c++/v1/string_view:300:42: error: implicit instantiation of undefined template 'std::char_traits<unsigned char>' 300 | static_assert(is_same<_CharT, typename traits_type::char_type>::value, | ^ /wrkdirs/usr/ports/textproc/zxing-cpp/work/zxing-cpp-2.2.1/core/src/Utf.cpp:72:42: note: in instantiation of template class 'std::basic_string_view<unsigned char>' requested here 72 | static size_t Utf8CountCodePoints(utf8_t utf8) | ^ /usr/include/c++/v1/__string/char_traits.h:45:8: note: template is declared here 45 | struct char_traits; | ^ `utf8_t` is effectively defined as `std::basic_string<uint8_t>`, which is no longer possible. So redefine it as a `std::vector<uint8_t>` instead. This requires only a small adjustment in one other place: replacing the initializer list in the `AppendFromUtf8` call in `FromUtf8`. [1] https://libcxx.llvm.org/ReleaseNotes/19.html#deprecations-and-removals