Bug 280818

Summary: multimedia/mplayer from latest failed to build WITH_DEBUG
Product: Ports & Packages Reporter: crypt47 <cryptogranny>
Component: Individual Port(s)Assignee: Thomas Zander <riggs>
Status: Closed FIXED    
Severity: Affects Only Me CC: riggs
Priority: --- Flags: riggs: maintainer-feedback+
Version: Latest   
Hardware: amd64   
OS: Any   
Attachments:
Description Flags
options file none

Description crypt47 2024-08-14 17:53:14 UTC 
Hello, I've built mplayer and ffmpeg from latest,

MPLAYER_PORT_VERSION=	1.5.0
MPLAYER_SNAPSHOT_DATE=	2024-01-06

and ffmpeg 4.4.4

and got a crash on a flac file, which I couldn't debug, apparently because the port is not tested with all the options.

Address not mapped to object.
ff_seek_frame_binary (s=s@entry=0x80953b000, stream_index=stream_index@entry=0, target_ts=target_ts@entry=2243584, flags=flags@entry=0) at libavformat/utils.c:2190
warning: 2190	libavformat/utils.c: No such file or directory
(gdb) bt
#0  ff_seek_frame_binary (s=s@entry=0x80953b000, stream_index=stream_index@entry=0, target_ts=target_ts@entry=2243584, flags=flags@entry=0) at libavformat/utils.c:2190
#1  0x000000080191db33 in seek_frame_internal (s=0x80953b000, stream_index=0, timestamp=2243584, flags=0) at libavformat/utils.c:2481
#2  av_seek_frame (s=0x80953b000, stream_index=<optimized out>, timestamp=<optimized out>, flags=0) at libavformat/utils.c:2504
#3  0x00000000012824c9 in ?? ()
#4  0x41200000012c36d0 in ?? ()
#5  0x00000008094fa800 in ?? ()
#6  0x0000000000000000 in ?? ()

The trace incomplete, but when I tried to build with debug, I've got another error:

cc -MMD -MP -W -Wall -D_ISOC99_SOURCE -I. -Iffmpeg -O2 -march=x86-64 -mcpu=generic -pipe -g3 -fno-asynchronous-unwind-tables -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -I/usr/local/include -I/usr/local/include -DLIBICONV_PLUG -fpie -DPIC -I/usr/local/include -I/usr/local/include/freetype2 -I/usr/local/include -DZLIB_CONST -I/usr/local/ffmpeg4/include -I/usr/local/ffmpeg4/include -c -o pnm_loader.o pnm_loader.c
cc: error: unsupported option '-mcpu=' for target 'x86_64-unknown-freebsd14.1'
cc -MMD -MP -W -Wall -D_ISOC99_SOURCE -I. -Iffmpeg -O2 -march=x86-64 -mcpu=generic -pipe -g3 -fno-asynchronous-unwind-tables -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -I/usr/local/include -I/usr/local/include -DLIBICONV_PLUG -fpie -DPIC -I/usr/local/include -I/usr/local/include/freetype2 -I/usr/local/include -DZLIB_CONST -I/usr/local/ffmpeg4/include -I/usr/local/ffmpeg4/include -c -o input/input.o input/input.c
cc: error: unsupported option '-mcpu=' for target 'x86_64-unknown-freebsd14.1'
gmake: *** [Makefile:730: command.o] Error 1
gmake: *** Waiting for unfinished jobs....
gmake: *** [Makefile:730: m_property.o] Error 1
cc: error: unsupported option '-mcpu=' for target 'x86_64-unknown-freebsd14.1'
gmake: *** [Makefile:730: mixer.o] Error 1
gmake: *** [Makefile:730: mp_fifo.o] Error 1
cc: error: unsupported option '-mcpu=' for target 'x86_64-unknown-freebsd14.1'
cc: error: unsupported option '-mcpu=' for target 'x86_64-unknown-freebsd14.1'
gmake: *** [Makefile:730: mplayer.o] Error 1
cc: error: unsupported option '-mcpu=' for target 'x86_64-unknown-freebsd14.1'
gmake: *** [Makefile:730: parser-mpcmd.o] Error 1
cc: error: unsupported option '-mcpu=' for target 'x86_64-unknown-freebsd14.1'
gmake: *** [Makefile:730: pnm_loader.o] Error 1
gmake: *** [Makefile:730: input/input.o] Error 1
===> Compilation failed unexpectedly.
Try to set MAKE_JOBS_UNSAFE=yes and rebuild before reporting the failure to
the maintainer.
*** Error code 1

I know it's because LLVM is stricked, but I'm not a programmer to fix this.

Can't check mplayer crash on binary builds because there aren't. Tried to build the version of mplayer 20220924 that worked, but now it fails with the same file. ffmpeg changes from 4.4.3 to 4.4.4 doesn't affect libavformat/utils.c
Comment 1 crypt47 2024-08-14 17:57:46 UTC 
I also tried to use old LLVM 14, it compiles with debug enabled, but the binary for some reason is stripped.:(
Comment 2 crypt47 2024-08-14 18:11:34 UTC 
checked the binary package from latest. crashes on my flac too.
Comment 3 crypt47 2024-08-14 18:25:43 UTC 
Created attachment 252761 [details]
options file
Comment 4 commit-hook freebsd_committer freebsd_triage 2024-10-19 15:41:24 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=d78f92cabfc61e61fa5f13705134f6b0e0e2f599

commit d78f92cabfc61e61fa5f13705134f6b0e0e2f599
Author:     Thomas Zander <riggs@FreeBSD.org>
AuthorDate: 2024-10-19 15:32:01 +0000
Commit:     Thomas Zander <riggs@FreeBSD.org>
CommitDate: 2024-10-19 15:40:53 +0000

    multimedia/{mplayer|mencoder}: Fix WITH_DEBUG build

    Newer clang versions are not happy when passing -mcpu=<something> on
    i386 and amd64. This fixes the construction of CFLAGS during configure
    in the WITH_DEBUG case.
    Also, as it turns out, there was a const ptr issue in
    libmpcodecs/ad_spdif.c whith also needed to be fixed.

    PR:             280818
    Reported by:    cryptogranny@gmail.com

 multimedia/mencoder/Makefile                       |  1 +
 multimedia/mplayer/Makefile                        |  1 +
 multimedia/mplayer/files/patch-configure           | 39 ++++++++++++++--------
 .../files/patch-libmpcodecs_ad__spdif.c (new)      | 11 ++++++
 4 files changed, 39 insertions(+), 13 deletions(-)