Bug 280879
| Summary: | net/openmpi: Fix shortfloat support | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Laurent Chardon <laurent.chardon> | ||||
| Component: | Individual Port(s) | Assignee: | Vladimir Druzenko <vvd> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Some People | CC: | uzsolt, vvd | ||||
| Priority: | --- | Flags: | uzsolt:
maintainer-feedback+
|
||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 280883 | ||||||
| Attachments: |
|
||||||
^Triage: if you're the maintainer please set maintainer-feedback to plus! (In reply to Zsolt Udvari from comment #1) Will do, thanks. 1. PORTVERSION => DISTVERSION
2. Removed ${COMPILER_VERSION} >= 170
14.0 still supported and have llvm 16 in base - is it ok?
(In reply to Vladimir Druzenko from comment #3) 1. Good catch. It's been like this since 2015. Do you need me to produce a new patch? 2. Yes, I've tested on 14.0. In fact, it's to fix openmpi on 14.0 that I'm making this change. (In reply to Laurent Chardon from comment #4) 1. I changed it already locally. 2. ok. Committing. Do you want merge-quarterly? No need to merge quarterly. Thank you for the commit! A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=595a5d5fa099770ebece23deb61fa364eba955db commit 595a5d5fa099770ebece23deb61fa364eba955db Author: Laurent Chardon <laurent.chardon@gmail.com> AuthorDate: 2024-08-18 11:42:14 +0000 Commit: Vladimir Druzenko <vvd@FreeBSD.org> CommitDate: 2024-08-18 11:42:14 +0000 net/openmpi: Fix shortfloat support - Improve the test for half precision support. The old test gave incorrect results, in particular for older compilers. The test is now compiler independent since both gcc and clang have supported __Float16 for a long while. - Remove unused code for plist substitution of NO_MCA_PATCHER_OVERWRITE PR: 280879 net/openmpi/Makefile | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) Thanks. |
Created attachment 252843 [details] net/openmpi: Fix shortfloat support - Improve the test for half precision support. The old test gave incorrect results, in particular for older compilers. The test is now compiler independent since both gcc and clang have supported __Float16 for a long while. - Remove unused code for plist substitution of NO_MCA_PATCHER_OVERWRITE QA portlit: OK poudriere: OK