Bug 280993
| Summary: | [NEW-PORT] net-mgmt/netbox-agent: Netbox Agent | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Xavier Beaudouin <kiwi> | ||||||
| Component: | Individual Port(s) | Assignee: | Mateusz Piotrowski <0mp> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Only Me | CC: | 0mp, vvd | ||||||
| Priority: | --- | ||||||||
| Version: | Latest | ||||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| Attachments: |
|
||||||||
Hey! Could you run portclippy on the patch? It looks like the order of some variables is off. Also, since this is basically version 0.7.2 with some unreleased upstream patches and a bunch of FreeBSD-specific patches applied, I think it would be a good idea to do the following: DISTVERSIONPREFIX=v DISTVERSION=0.7.2-77 DISTVERSIONSUFFIX=-g6ae055c (cf. "Example 14. Using USE_GITHUB to Access a Commit Between Two Versions", Porter's Handbook). You won't need to specify "GH_TAGNAME= 6ae055c" then and also it would give the users a better idea what this version actually is. Also, I do not understand the comment "# PyPi sdist do not have tests". What does it mean? The last thing would be the COMMENT. Something more descriptive would be better. Maybe even: COMMENT=Agent for the NetBox network automation (In reply to Mateusz Piotrowski from comment #3) This is a commit I forgot to remove. Sorry.. Created attachment 253013 [details]
git format-patch for netbox-agent
This is updated git format-patch for netbox-agent with suggested changes from Mateusz.
Kind regards
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=28b399b1ec5e8a830cc2e8e12abc941233e83d01 commit 28b399b1ec5e8a830cc2e8e12abc941233e83d01 Author: Xavier Beaudouin <kiwi@oav.net> AuthorDate: 2024-08-22 12:29:08 +0000 Commit: Mateusz Piotrowski <0mp@FreeBSD.org> CommitDate: 2024-08-22 16:09:45 +0000 net-mgmt/netbox-agent: Agent for the Netbox network automation PR: 280993 Sponsored by: Bell Tower Integration Sponsored by: Klara, Inc. net-mgmt/Makefile | 1 + net-mgmt/netbox-agent/Makefile (new) | 35 +++++++++++++++++++++++++++++++++++ net-mgmt/netbox-agent/distinfo (new) | 3 +++ net-mgmt/netbox-agent/pkg-descr (new) | 4 ++++ 4 files changed, 43 insertions(+) Committed! Thanks! |
Created attachment 253010 [details] git format-patch for netbox-agent This port is a port for Netbox Agent, adapted for FreeBSD (the original code runs only on Linux). It permits to push hardware information into netbox like memory, harddisk, ipmi information like power supplies, motherboard serial numbers etc... Has been tested on poudriere with 14.0 and 14.1, portfmt used to check the Makefile. Kind regards PS: bugzilla always think the git format-patch is a mbox... as usual.