Bug 281016

Summary: www/domoticz-devel: Improve port
Product: Ports & Packages Reporter: Daniel Engberg <diizzy>
Component: Individual Port(s)Assignee: Daniel Engberg <diizzy>
Status: Closed FIXED    
Severity: Affects Only Me CC: kiwi
Priority: --- Flags: kiwi: maintainer-feedback+
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Patch for domoticz none

Description Daniel Engberg freebsd_committer freebsd_triage 2024-08-23 21:11:33 UTC 
Created attachment 253045 [details]
Patch for domoticz

Reword and modernize port to follow Porters Handbook more closely (no functional change)

* Add --no-same-owner --no-same-permissions to EXTRACT_AFTER_ARGS
  https://cgit.freebsd.org/ports/tree/Mk/bsd.port.mk#n705

* Rework and sort OPTIONS 
  See https://docs.freebsd.org/en/books/porters-handbook/book/#options-cmake_bool

* Remove variables in CMAKE_OFF that are already disabled by default

TELLDUS was removed in 2023
https://cgit.freebsd.org/ports/commit/?id=55660d2e5466486b38bd437a94f5ce5d089a1e2f

Other considerations,

I would suggest to drop PRECOMP and always generate headers, there's less than 1 minute in difference on my rather slow laptop in terms of compile time.

Stage QA complains about REINPLACE_CMD not modifying files

I would also suggest that you follow "Example 18. Using USE_GITHUB to Access a Commit Between Two Versions" for versioning
Comment 1 Daniel Engberg freebsd_committer freebsd_triage 2024-08-23 21:12:07 UTC 
The CMAKE_INSTALL_PREFIX hack also looks a bit odd
Comment 2 Xavier Beaudouin 2024-08-24 08:40:47 UTC 
Thanks Daniel, this exactly what I wanted to do during next week. 

I agree with this changes !

Kind regards
Xavier
Comment 3 commit-hook freebsd_committer freebsd_triage 2024-08-31 08:51:47 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=571995f2f6780ce6b4bca86b3fb711c1f626ce94

commit 571995f2f6780ce6b4bca86b3fb711c1f626ce94
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2024-08-30 22:29:13 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2024-08-31 08:50:47 +0000

    www/domoticz-devel: Improve port

    * Add --no-same-owner --no-same-permissions to EXTRACT_AFTER_ARGS
      https://cgit.freebsd.org/ports/tree/Mk/bsd.port.mk#n705

    * Rework and sort OPTIONS
      See https://docs.freebsd.org/en/books/porters-handbook/book/#options-cmake_bool

    * Remove variables in CMAKE_OFF that are already disabled by default

    * Remove TELLDUS which was removed in 2023

    Reference:
    https://cgit.freebsd.org/ports/commit/?id=55660d2e5466486b38bd437a94f5ce5d089a1e2f

    PR:             281016
    Reviewed by:    Xavier Beaudouin <kiwi@oav.net> (maintainer)

 www/domoticz-devel/Makefile | 62 +++++++++++++++++++--------------------------
 1 file changed, 26 insertions(+), 36 deletions(-)
Comment 4 Daniel Engberg freebsd_committer freebsd_triage 2024-08-31 08:53:06 UTC 
Committed, thanks

Please have a look at the other remarks when you have time