Bug 281125
| Summary: | ixl: fix multicast filters handling regression | ||
|---|---|---|---|
| Product: | Base System | Reporter: | Franco Fichtner <franco> |
| Component: | kern | Assignee: | Intel FreeBSD <freebsd> |
| Status: | Closed FIXED | ||
| Severity: | Affects Only Me | CC: | erj, krzysztof.galazka, markj, pfsensemp, pi, rakuco |
| Priority: | --- | Keywords: | IntelNetworking, regression, vendor |
| Version: | 14.0-RELEASE | ||
| Hardware: | Any | ||
| OS: | Any | ||
| URL: | https://github.com/opnsense/src/issues/212 | ||
| See Also: | https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=283820 | ||
|
Description
Franco Fichtner
2024-08-29 13:02:57 UTC
^Triage: over to committer of potential regression. Sorry, I'm neither employed to work on those drivers anymore nor can I have relevant hardware to fix this in my spare time. Would it be possible to revert this commit to fix this issue ? This is a problem for pfSense with intel X710 cards, which makes multicast unusable. Reverting appears sensible. We did the same in OPNsense being faced with the regression. The revert hasn't caused any other visible side effect. Cheers, Franco Patch was ported from the out-of-tree driver, which uses separate handlers for SIOCADDMULTI and SIOCDELMULTI ioctls, and in iflib it's combined. Maybe this is related, but TBH I see no clear reason why. We started looking into that, but didn't make much progress yet. I'm not a committer, so I can't do it myself, but I'm okay with reverting this patch until we came out with better solution. Thanks, added a GitHub PR here https://github.com/freebsd/freebsd-src/pull/1545 Thanks for your patch ! Any idea if this patch could be merged shortly ? Because it would be great if it could be implemented to pfSense 2.8 wich I think is not far from now A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=38663adb61440bd659fb457909782b71ba8806fa commit 38663adb61440bd659fb457909782b71ba8806fa Author: Franco Fichtner <franco@opnsense.org> AuthorDate: 2024-12-11 14:08:40 +0000 Commit: Mark Johnston <markj@FreeBSD.org> CommitDate: 2024-12-19 13:49:30 +0000 Revert "ixl: fix multicast filters handling" This reverts commit 89e73359424a338a7900a4854ad7439f5848ebb8. PR: 281125 Reviewed by: Krzysztof Galazka <krzysztof.galazka@intel.com> MFC after: 3 days Pull Request: https://github.com/freebsd/freebsd-src/pull/1545 sys/dev/ixl/ixl_pf_main.c | 97 +++++------------------------------------------ 1 file changed, 10 insertions(+), 87 deletions(-) A commit in branch stable/14 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=5c15d499c23a09655931ea2ccf5b94dd39cdae76 commit 5c15d499c23a09655931ea2ccf5b94dd39cdae76 Author: Franco Fichtner <franco@opnsense.org> AuthorDate: 2024-12-11 14:08:40 +0000 Commit: Mark Johnston <markj@FreeBSD.org> CommitDate: 2024-12-23 16:51:33 +0000 Revert "ixl: fix multicast filters handling" This reverts commit 89e73359424a338a7900a4854ad7439f5848ebb8. PR: 281125 Reviewed by: Krzysztof Galazka <krzysztof.galazka@intel.com> MFC after: 3 days Pull Request: https://github.com/freebsd/freebsd-src/pull/1545 (cherry picked from commit 38663adb61440bd659fb457909782b71ba8806fa) sys/dev/ixl/ixl_pf_main.c | 97 +++++------------------------------------------ 1 file changed, 10 insertions(+), 87 deletions(-) The revert has been merged now, but we still don't understand the root cause of the problem. Shall we keep this bug report open until that's solved? (In reply to Mark Johnston from comment #10) Problems, which D40860 tried to address, are still there. We can track them with this PR or open a new one with more detailed description. Either way is fine for me. (In reply to Krzysztof Galazka from comment #11) If you don't mind, let's track those in a new bug? I'll submit one now. |
