Bug 281188

Summary: java/openjdk8 java/openjdk11 java/openjdk17 java/openjdk18 java/openjdk19 java/openjdk20 java/openjdk21 java/openjdk22: disable warnings as errors
Product: Ports & Packages Reporter: Dimitry Andric <dim>
Component: Individual Port(s)Assignee: freebsd-java (Nobody) <java>
Status: Closed FIXED    
Severity: Affects Some People Flags: bugzilla: maintainer-feedback? (java)
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
Bug Depends on:    
Bug Blocks: 280562    
Attachments:
Description Flags
java/openjdk8 java/openjdk11 java/openjdk17 java/openjdk18 java/openjdk19 java/openjdk20 java/openjdk21 java/openjdk22: disable warnings as errors none

Description Dimitry Andric freebsd_committer freebsd_triage 2024-09-01 13:16:33 UTC 
I propose to generally disable warnings-as-errors for all openjdk ports,
removing all the conditionals we have now for particular architectures
and/or compilers. It does not make sense to have this on by default,
unless you are an upstream maintainer.
Comment 1 Dimitry Andric freebsd_committer freebsd_triage 2024-09-01 13:16:55 UTC 
Created attachment 253242 [details]
java/openjdk8 java/openjdk11 java/openjdk17 java/openjdk18 java/openjdk19 java/openjdk20 java/openjdk21 java/openjdk22: disable warnings as errors
Comment 2 commit-hook freebsd_committer freebsd_triage 2024-09-15 11:38:34 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=3378cc494de65725a36e8ff5aaa205273521ba52

commit 3378cc494de65725a36e8ff5aaa205273521ba52
Author:     Dimitry Andric <dim@FreeBSD.org>
AuthorDate: 2024-08-29 07:46:12 +0000
Commit:     Dimitry Andric <dim@FreeBSD.org>
CommitDate: 2024-09-15 11:36:13 +0000

    java/openjdk8 java/openjdk11 java/openjdk17 java/openjdk18 java/openjdk19 java/openjdk20 java/openjdk21 java/openjdk22: disable warnings as errors

    Generally disable warnings-as-errors for all openjdk ports, removing all
    the conditionals we have now for particular architectures and/or
    compilers. It does not make sense to have this on by default, unless you
    are an upstream maintainer.

    PR:             281188
    Approved by:    maintainer timeout (2 weeks)
    MFH:            2024Q3

 java/openjdk11/Makefile | 4 +---
 java/openjdk17/Makefile | 5 +----
 java/openjdk18/Makefile | 4 +---
 java/openjdk19/Makefile | 4 +---
 java/openjdk20/Makefile | 4 +---
 java/openjdk21/Makefile | 4 +---
 java/openjdk22/Makefile | 4 +---
 java/openjdk8/Makefile  | 2 +-
 8 files changed, 8 insertions(+), 23 deletions(-)
Comment 3 commit-hook freebsd_committer freebsd_triage 2024-09-15 11:40:36 UTC 
A commit in branch 2024Q3 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=b56109991d7a20f8c343c0397d6eb01073972374

commit b56109991d7a20f8c343c0397d6eb01073972374
Author:     Dimitry Andric <dim@FreeBSD.org>
AuthorDate: 2024-08-29 07:46:12 +0000
Commit:     Dimitry Andric <dim@FreeBSD.org>
CommitDate: 2024-09-15 11:39:30 +0000

    java/openjdk8 java/openjdk11 java/openjdk17 java/openjdk18 java/openjdk19 java/openjdk20 java/openjdk21 java/openjdk22: disable warnings as errors

    Generally disable warnings-as-errors for all openjdk ports, removing all
    the conditionals we have now for particular architectures and/or
    compilers. It does not make sense to have this on by default, unless you
    are an upstream maintainer.

    PR:             281188
    Approved by:    maintainer timeout (2 weeks)
    MFH:            2024Q3

    (cherry picked from commit 3378cc494de65725a36e8ff5aaa205273521ba52)

 java/openjdk11/Makefile | 4 +---
 java/openjdk17/Makefile | 5 +----
 java/openjdk18/Makefile | 4 +---
 java/openjdk19/Makefile | 4 +---
 java/openjdk20/Makefile | 4 +---
 java/openjdk21/Makefile | 4 +---
 java/openjdk22/Makefile | 4 +---
 java/openjdk8/Makefile  | 2 +-
 8 files changed, 8 insertions(+), 23 deletions(-)