Bug 281363
| Summary: | audio/libvgm: Improve port | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Daniel Engberg <diizzy> | ||||||
| Component: | Individual Port(s) | Assignee: | Hiroki Tagato <tagattie> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Only Me | CC: | diizzy | ||||||
| Priority: | --- | Flags: | bugzilla:
maintainer-feedback?
(tagattie) |
||||||
| Version: | Latest | ||||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| Attachments: |
|
||||||||
I have a crude patch for vgmplay-libvgm here: https://projects.pyret.net/files/freebsd-patches/vgmplay-libvgm.patch This is also so we can build it with audio/fooyin Created attachment 253496 [details] Revised patch (In reply to Daniel Engberg from comment #0) Hi Daniel, Thanks for the patch. Instead of disabling player and vgm2wav commands altogether, I have introduced options to control building/installing them. The options are ON by default so that users already installed the port aren't surprised by sudden removal of the commands. I personally find vgm2wav command useful and sometimes use it. If the revision is acceptable to you, I will commit the changes. (In reply to Daniel Engberg from comment #1) audio/vgmplay is already based on (currently static) libvgm :-) I will later update the port to use shared version of the library. Ahh, I overlooked it as upstream refers to it differently. As for the utils, vgmplay -w ? If you want to keep the bundled legacy player I would at least recommend that you prefix it as "player" is way too generic and can cause filename clashes. Best regards, Daniel (In reply to Daniel Engberg from comment #5) > If you want to keep the bundled legacy player I would at least recommend that you prefix it as "player" is way too generic and can cause filename clashes. Thanks for the suggestion. I agree. I will change the command name to "libvgm-player". A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=36f408ce8fb5f6eb47c1eb3438620817a33076ea commit 36f408ce8fb5f6eb47c1eb3438620817a33076ea Author: Hiroki Tagato <tagattie@FreeBSD.org> AuthorDate: 2024-09-12 11:40:35 +0000 Commit: Hiroki Tagato <tagattie@FreeBSD.org> CommitDate: 2024-09-12 11:45:18 +0000 audio/libvgm: update to latest GitHub commit and improve port Improvements include: - switch to build shared libraries so that they are usable for other apps - optionize bundled commands (ON by default) - rename "player" command to "libvgm-player" (player is too generic name and can cause filename clashes) Co-authored-by: Daniel Engberg <diizzy@FreeBSD.org> PR: 281363 Reported by: diizzy audio/libvgm/Makefile | 28 +++++++++++++++++++++++----- audio/libvgm/distinfo | 6 +++--- audio/libvgm/pkg-plist | 12 ++++++------ 3 files changed, 32 insertions(+), 14 deletions(-) Committed, thanks! Thanks, audio/fooyin now also features libvgm support :-) |
Created attachment 253422 [details] Patch for libvgm * Build it as a shared library so it's usable for other applications * Ddo not bundle anything else * While at it update to latest upstream commit Compile and tested on FreeBSD 14.1-RELEASE (amd64) (make, make check-plist) Poudriere testport OK 13.3-RELEASE (amd64) Poudriere testport OK 14.0-RELEASE (i386) Poudriere testport OK 14.0-RELEASE (amd64) Poudriere testport OK 14.1-RELEASE (amd64)