Bug 281374

Summary: games/mizuma: Update to 2024.09
Product: Ports & Packages Reporter: Alexander Vereeken <Alexander88207>
Component: Individual Port(s)Assignee: Vladimir Druzenko <vvd>
Status: Closed FIXED    
Severity: Affects Some People CC: vvd
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Patch to Update games/mizuma to 2024.09 Alexander88207: maintainer-approval+

Description Alexander Vereeken freebsd_triage 2024-09-08 21:12:16 UTC 
Changes:

- Restrict usage of ExtractTo to $ProjectPath.

- Fixed correct PCM device info when 10+ PCM devices are present.

- Delete also *.rar files when cleaning up cache.

Changes to the port:

- Changed runtime to regular wine as it is fully functional again.

Thank you in advance!
Comment 1 Alexander Vereeken freebsd_triage 2024-09-08 21:17:15 UTC 
Created attachment 253437 [details]
Patch to Update games/mizuma to 2024.09
Comment 2 Vladimir Druzenko freebsd_committer freebsd_triage 2024-09-09 17:31:54 UTC 
1. Add NO_ARCH=yes

2. portclippy warnings:
# WRKSRC block
+WRKSRC

# Packaging list block
+PLIST_FILES

# Options definitions
-OPTIONS_SUB
OPTIONS_DEFAULT
OPTIONS_RADIO
OPTIONS_RADIO_GLXINFO
+OPTIONS_SUB

# Options descriptions
GLX-UTILS_DESC
MESA-DEMOS_DESC

# Options helpers
GLX-UTILS_RUN_DEPENDS
MESA-DEMOS_RUN_DEPENDS

-WRKSRC

-PLIST_FILES

3. IMHO, better use '_' instead of '-' in variable names (options GLX-UTILS, MESA-DEMOS).

Can I fix?
Comment 3 Alexander Vereeken freebsd_triage 2024-09-09 17:34:45 UTC 
Sure go ahead.
Comment 4 commit-hook freebsd_committer freebsd_triage 2024-09-09 17:56:18 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=5b3354a080c304c1366ca410701014cceb4a9a3f

commit 5b3354a080c304c1366ca410701014cceb4a9a3f
Author:     Alexander Vereeken <Alexander88207@protonmail.com>
AuthorDate: 2024-09-09 17:52:06 +0000
Commit:     Vladimir Druzenko <vvd@FreeBSD.org>
CommitDate: 2024-09-09 17:52:06 +0000

    games/mizuma: Update 2024.04 → 2024.09

    Changelog:
    - Restrict usage of ExtractTo to $ProjectPath.
    - Fixed correct PCM device info when 10+ PCM devices are present.
    - Delete also *.rar files when cleaning up cache.
    https://codeberg.org/Alexander88207/Mizutamari/releases/tag/2024.09

    Changes to the port:
    - Changed runtime to regular wine as it is fully functional again.
    - Add NO_ARCH - "no architecture specific files found" (port installs 2
      bash scripts only).
    - Repalce '-' with '_' in options names.
    - Pet portclippy.

    PR:     281374

 games/mizuma/Makefile                  | 27 ++++++++++++++-------------
 games/mizuma/distinfo                  |  6 +++---
 games/mizuma/files/patch-Mizuma (gone) | 14 --------------
 3 files changed, 17 insertions(+), 30 deletions(-)
Comment 5 Vladimir Druzenko freebsd_committer freebsd_triage 2024-09-09 17:56:46 UTC 
Thanks.