Bug 281387

Summary: security/fprintd: Update to version 1.94.4
Product: Ports & Packages Reporter: Harald Eilertsen <haraldei-freebsdbugz>
Component: Individual Port(s)Assignee: Mateusz Piotrowski <0mp>
Status: Closed FIXED    
Severity: Affects Only Me CC: 0mp, cy
Priority: --- Flags: bugzilla: maintainer-feedback? (danfe)
Version: Latest   
Hardware: Any   
OS: Any   
See Also: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=280749
Bug Depends on: 281386    
Bug Blocks: 282008    
Attachments:
Description Flags
Patch updating security/fprintd to version 1.94.4 (including pam module)
none
Patch replacing security/pam_fprint with security/fprintd
none
Update libfprint to 1.94.8. none

Description Harald Eilertsen 2024-09-09 10:38:29 UTC
Created attachment 253454 [details]
Patch updating security/fprintd to version 1.94.4 (including pam module)

Update security/fprintd to version 1.94.4. Upstream has changed to use devel/basu as a systemd/dbus alternative which makes it almost build cleanly. A small patch is included in the port to make the last remaining build issue disappear.

This new port also includes the pam module that previously was a separate port.
Comment 1 Harald Eilertsen 2024-09-10 11:00:00 UTC
Created attachment 253483 [details]
Patch replacing security/pam_fprint with security/fprintd

The pam_fprint upstream project is discontinued, and replaced with the pam_fprintd module built as part of fprintd.

Unsure if this should have bee submitted as a separate issue, but including it here as it's related to the updated fprintd port.
Comment 2 Mateusz Piotrowski freebsd_committer freebsd_triage 2024-09-12 11:27:01 UTC
Thanks for the patches!
Comment 3 Cy Schubert freebsd_committer freebsd_triage 2024-09-13 15:25:06 UTC
Created attachment 253543 [details]
Update libfprint to 1.94.8.

This also requires updating libfprint to 1.94.8.
Comment 4 Cy Schubert freebsd_committer freebsd_triage 2024-09-13 15:27:45 UTC
(In reply to Cy Schubert from comment #3)

Never mind. I found the other PR. I should have looked here first before putting any work into this. :(
Comment 5 Cy Schubert freebsd_committer freebsd_triage 2024-09-13 15:28:30 UTC
Comment on attachment 253543 [details]
Update libfprint to 1.94.8.

Not for this PR.
Comment 6 commit-hook freebsd_committer freebsd_triage 2024-10-11 10:44:54 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=406cda4aff0da933aadfa169c3d2ac13c0b858dc

commit 406cda4aff0da933aadfa169c3d2ac13c0b858dc
Author:     Harald Eilertsen <haraldei-freebsdbugz@anduin.net>
AuthorDate: 2024-10-10 12:50:58 +0000
Commit:     Mateusz Piotrowski <0mp@FreeBSD.org>
CommitDate: 2024-10-11 10:42:18 +0000

    security/fprintd: Update to 1.94.4

    Upstream has changed to use devel/basu as a systemd/dbus alternative
    which makes it almost build cleanly. A small patch is included in the
    port to make the last remaining build issue disappear.

    This new port also includes the PAM module that previously was a
    separate port.

    PR:             281387
    Reviewed by:    0mp
    Tested by:      Eirik Øverby <ltning@anduin.net>
    Approved by:    maintainer timeout
    Sponsored by:   Entersekt (previously Modirum MDpay)

 security/fprintd/Makefile                      |  38 ++-----
 security/fprintd/distinfo                      |   6 +-
 security/fprintd/files/patch-git_06bab8 (gone) |  46 --------
 security/fprintd/pkg-plist                     | 152 +++++++++++++------------
 4 files changed, 91 insertions(+), 151 deletions(-)
Comment 7 Mateusz Piotrowski freebsd_committer freebsd_triage 2024-10-11 10:54:25 UTC
Thanks to Eirik Øverby for doing the extra testing of the patch.

I've committed the slightly modified version of the update for fprintd and I opened a separate PR for the removal of pam_fprint. The removal should go through the standard deprecation procedure.