Bug 281388

Summary: misc/nnn Update to 5.0 and take over maintainership
Product: Ports & Packages Reporter: Bartek Jasicki <thindil>
Component: Individual Port(s)Assignee: Kurt Jaeger <pi>
Status: Closed FIXED    
Severity: Affects Only Me CC: diizzy, pi, thindil
Priority: --- Flags: pi: maintainer-feedback-
Version: Latest   
Hardware: Any   
OS: Any   
URL: https://github.com/jarun/nnn/releases/tag/v5.0
Attachments:
Description Flags
Update to 5.0
none
Update to 5.0 second try
none
Patch for nnn none

Description Bartek Jasicki 2024-09-09 11:21:32 UTC 
Created attachment 253455 [details]
Update to 5.0

Update the port to version 5.0.

Additionally, I want to take over maintainership of the package. Two previous updates of the port were done due to the maintainer's timeout: bug #273512 and bug #272061. I was trying to contact with the maintainer before this update, unfortunately I had no answer. I'm using the port on my daily basis, so I can maintain it too. ;)

If the maintainer can read this, please, send a sign, then I will remove take over request from the patch and leave only the update of version.
Comment 1 Daniel Engberg freebsd_committer freebsd_triage 2024-12-05 23:45:13 UTC 
Hi,

Please use upstream release archive, https://github.com/jarun/nnn/releases/download/v5.0/nnn-v5.0.tar.gz (remove USE_GITHUB etc) and use MASTER_SITES instead.
https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-master_sites-github

I would also recommend letting the framework handling stripping so pass STRIP_CMD to MAKE_ARGS

Best regards,
Daniel
Comment 2 Bartek Jasicki 2024-12-06 08:21:30 UTC 
Created attachment 255658 [details]
Update to 5.0 second try

(In reply to Daniel Engberg from comment #1)

Hello,

Thank you very much for checking it. Here is the new version of the patch, with, I think, all suggested changes. I didn't remove USE_GITHUB, etc. because they are needed for MASTER_SITES_GH macro. If something is still wrong, please tell. :)

Have a nice day,
Bartek
Comment 3 Kurt Jaeger freebsd_committer freebsd_triage 2024-12-06 17:41:13 UTC 
Committed, thanks!
Comment 4 commit-hook freebsd_committer freebsd_triage 2024-12-06 17:41:57 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=66afe3539a304907ff653c52011d3b9d227bf305

commit 66afe3539a304907ff653c52011d3b9d227bf305
Author:     Bartek Jasicki <thindil@laeran.pl.eu.org>
AuthorDate: 2024-12-06 17:39:37 +0000
Commit:     Kurt Jaeger <pi@FreeBSD.org>
CommitDate: 2024-12-06 17:39:37 +0000

    misc/nnn: update 4.9 -> 5.0, submitter becomes maintainer

    PR:             281388
    Reviewed:       diizzy
    Changes:        https://github.com/jarun/nnn/releases/tag/v5.0

 misc/nnn/Makefile | 9 +++++----
 misc/nnn/distinfo | 6 +++---
 2 files changed, 8 insertions(+), 7 deletions(-)
Comment 5 Daniel Engberg freebsd_committer freebsd_triage 2024-12-06 19:58:37 UTC 
Created attachment 255672 [details]
Patch for nnn

Use upstream release archive
Comment 6 Daniel Engberg freebsd_committer freebsd_triage 2024-12-06 19:58:55 UTC 
This is how it should look ;-)
Comment 7 Bartek Jasicki 2024-12-06 20:28:58 UTC 
(In reply to Daniel Engberg from comment #6)

Ah, thank you very much, noted. ;)
I will use it with the next release.