Bug 281423

Summary: devel/mm: LICENSE= BSD4CLAUSE, isn't.
Product: Ports & Packages Reporter: наб <nabijaczleweli>
Component: Individual Port(s)Assignee: Rodrigo Osorio <rodrigo>
Status: Closed FIXED    
Severity: Affects Only Me CC: nabijaczleweli
Priority: --- Flags: bugzilla: maintainer-feedback? (rodrigo)
Version: Latest   
Hardware: Any   
OS: Any   

Description наб 2024-09-10 21:07:53 UTC
ossp-mm/LICENSE says:
    ====================================================================
    Copyright (c) 1999-2007 Ralf S. Engelschall <rse@engelschall.com>
    Copyright (c) 1999-2007 The OSSP Project <http://www.ossp.org/>

    Redistribution and use in source and binary forms, with or without
    modification, are permitted provided that the following conditions
    are met:

    1. Redistributions of source code must retain the above copyright
       notice, this list of conditions and the following disclaimer.

    2. Redistributions in binary form must reproduce the above copyright
       notice, this list of conditions and the following disclaimer in
       the documentation and/or other materials provided with the
       distribution.

    3. All advertising materials mentioning features or use of this
       software must display the following acknowledgment:
       "This product includes software developed by
        Ralf S. Engelschall <rse@engelschall.com>."

    4. Redistributions of any form whatsoever must retain the following
       acknowledgment:
       "This product includes software developed by
        Ralf S. Engelschall <rse@engelschall.com>."

    THIS SOFTWARE IS PROVIDED BY RALF S. ENGELSCHALL ``AS IS'' AND ANY
    EXPRESSED OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
    IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
    PURPOSE ARE DISCLAIMED.  IN NO EVENT SHALL RALF S. ENGELSCHALL OR
    ITS CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
    SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT
    NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
    LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
    HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT,
    STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
    ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED
    OF THE POSSIBILITY OF SUCH DAMAGE.
    ====================================================================
point 4 is different from BSD-4-Clause.

(Cf. https://lists.sr.ht/~nabijaczleweli/ossp/%3Cbyjcsfzkijbtq6gsttwtffbnmtxureozobxd3xyrbgig5qsio2@tarta.nabijaczleweli.xyz%3E)
Comment 1 Rodrigo Osorio freebsd_committer freebsd_triage 2024-09-10 21:41:17 UTC
Hi,

I found the changes made by Vasil Dimov (vd)[1] totally acceptable and if OSSP
project owner agree on that I can do the require changes on the ports and close
this PR asap.

The license section looks like something like this

LICENSE=	UNKNOWN
LICENSE_NAME=	unknown
LICENSE_FILE=	${WRKSRC}/LICENSE
LICENSE_PERMS=	dist-mirror dist-sell pkg-mirror pkg-sell auto-accept

[1] https://cgit.freebsd.org/ports/commit/?id=f83fcbc0e3b88be7c6b0d3d1bb5e838df746a391
Comment 2 Rodrigo Osorio freebsd_committer freebsd_triage 2024-09-10 21:46:59 UTC
(In reply to Rodrigo Osorio from comment #1)

Another option is to submit a new license type with the same permissions.
Comment 3 наб 2024-09-10 22:06:19 UTC
Do note that ossp-uuid uses a different (ISC/0BSD-style) licence than ossp-mm, so I'm not sure if that changes your LICENSE_PERMS vocabulary. ossp-mm is /like/ BSD-4-Clause, but the fourth clause is replaced with basically the exact opposite (BSD-4-Clause says "no advertising the author", rse says "you must advertise me").
Comment 4 наб 2024-09-10 22:09:34 UTC
whoops enter too soon

...But if you keep this in mind then yeah that looks fine.

Also note that ossp-mm's licence is unique, so it makes little sense to lift it out.
OTOH ossp-uuid's licence is used more widely across FreeBSD ports (#281426).
Comment 5 commit-hook freebsd_committer freebsd_triage 2024-10-29 13:23:05 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=ab6304e314b6d17d5103606e138cf4b9d2a6e24b

commit ab6304e314b6d17d5103606e138cf4b9d2a6e24b
Author:     Rodrigo Osorio <rodrigo@FreeBSD.org>
AuthorDate: 2024-10-29 12:59:05 +0000
Commit:     Rodrigo Osorio <rodrigo@FreeBSD.org>
CommitDate: 2024-10-29 13:14:39 +0000

    devel/mm: Update license

    The OSSP project uses a customized version of the BSD-4-Clause
    license making the use of this license pattern irrelevant.

    Update it to keep the correct permissions granted by the OSSP
    license without confusing the user pretending this is a BSD one.

    PR:             281423
    Reported by:    <nabijaczleweli@nabijaczleweli.xyz>

 devel/mm/Makefile | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)
Comment 6 Rodrigo Osorio freebsd_committer freebsd_triage 2024-10-29 13:23:30 UTC
Committed, thanks