Bug 281441

Summary: devel/efl: fix build with clang 19
Product: Ports & Packages Reporter: Dimitry Andric <dim>
Component: Individual Port(s)Assignee: freebsd-enlightenment (Nobody) <enlightenment>
Status: Closed FIXED    
Severity: Affects Some People CC: arrowd, peter
Priority: --- Flags: arrowd: maintainer-feedback+
Version: Latest   
Hardware: Any   
OS: Any   
Bug Depends on:    
Bug Blocks: 280562    
Attachments:
Description Flags
devel/efl: fix build with clang 19 none

Description Dimitry Andric freebsd_committer freebsd_triage 2024-09-11 14:12:37 UTC
Clang 19 is more strict about errors in member functions, which results
in:

  ../src/bindings/cxx/eina_cxx/eina_string_view.hh:184:77: error: no member named 'lenght' in 'basic_string_view<CharT, Traits>'; did you mean 'length'?
    184 |       return iter == crend() ? npos : reverse_distance(crbegin(), iter) - s.lenght();
        |                                                                             ^~~~~~
        |                                                                             length
  ../src/bindings/cxx/eina_cxx/eina_string_view.hh:90:14: note: 'length' declared here
     90 |    size_type length() const noexcept { return _len; }
        |              ^
  ../src/bindings/cxx/eina_cxx/eina_string_view.hh:192:77: error: no member named 'lenght' in 'basic_string_view<CharT, Traits>'; did you mean 'length'?
    192 |       return iter == crend() ? npos : reverse_distance(crbegin(), iter) - s.lenght();
        |                                                                             ^~~~~~
        |                                                                             length
  ../src/bindings/cxx/eina_cxx/eina_string_view.hh:90:14: note: 'length' declared here
     90 |    size_type length() const noexcept { return _len; }
        |              ^

This is an obvious typo, fixed by upstream in
<https://git.enlightenment.org/enlightenment/efl/commit/6c3630ffda>.
Comment 1 Dimitry Andric freebsd_committer freebsd_triage 2024-09-11 14:16:01 UTC
Created attachment 253499 [details]
devel/efl: fix build with clang 19
Comment 2 Peter TKATCHENKO 2024-09-11 14:23:51 UTC
@Gleb Popov

Please, commit the upstream patch.
Comment 3 commit-hook freebsd_committer freebsd_triage 2024-09-14 18:22:51 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=6a761d8e124fcf267d598d38f484717419fc00bf

commit 6a761d8e124fcf267d598d38f484717419fc00bf
Author:     Dimitry Andric <dim@FreeBSD.org>
AuthorDate: 2024-09-14 18:21:53 +0000
Commit:     Gleb Popov <arrowd@FreeBSD.org>
CommitDate: 2024-09-14 18:22:18 +0000

    devel/efl: fix build with clang 19

    PR:             281441

 devel/efl/Makefile | 3 +++
 devel/efl/distinfo | 4 +++-
 2 files changed, 6 insertions(+), 1 deletion(-)