Bug 281709

Summary: devel/py-subversion{,-lts}: swig-py: Fix `none_dealloc` error (one-off patch)
Product: Ports & Packages Reporter: Lapo Luchini <lapo>
Component: Individual Port(s)Assignee: Michael Osipov <michaelo>
Status: Closed FIXED    
Severity: Affects Some People CC: michaelo
Priority: --- Flags: bugzilla: maintainer-feedback?
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
files/patch-subversion_bindings_swig_python_libsvn__swig__py_swigutil__py.c none

Description Lapo Luchini 2024-09-25 12:24:30 UTC
www/trac `trac-admin` is failing "resync" with subversion-1.14.3 (it works fine with 1.14.2), maliling lists suggests an upstream commit as a fix:

https://www.mail-archive.com/trac-users@googlegroups.com/msg31973.html
Comment 1 Lapo Luchini 2024-09-25 12:50:53 UTC
Created attachment 253810 [details]
files/patch-subversion_bindings_swig_python_libsvn__swig__py_swigutil__py.c
Comment 2 Michael Osipov freebsd_committer freebsd_triage 2024-09-26 07:19:23 UTC
This is ugly, I am still waiting for 1.14.4...
Comment 3 Lapo Luchini 2024-09-26 12:49:05 UTC
Well, it is an official commit to fix the specific bug by the project authors, and it is a few lines of patch… as that I'm not sure that qualifies as "ugly"… also, it seems to be that subversion release are quite far apart from one to the next and I have no idea when to expect 1.14.4.

Anyways… it was a show-stopper for me (and I guess many other tracd users) as rolling back yo 1.14.2 needed some compilations anyways (or a huge number of old ports from the 14.0 release pkgs) so I built the patch for my own poudriere and put it out here just in case someone else needs this. 😇
Comment 4 Michael Osipov freebsd_committer freebsd_triage 2024-09-26 17:44:36 UTC
(In reply to Lapo Luchini from comment #3)

Ugly because I have been approached by other people that they need other upstream patches as well.

See: https://www.mail-archive.com/dev@subversion.apache.org/msg43178.html
Comment 5 Oleksii Samorukov freebsd_committer freebsd_triage 2024-09-27 07:13:57 UTC
Hi, i am not a maintainer of this port, so not able to help here. As a trac/www maintaiener i would like to see the patch merged.
Comment 6 Michael Osipov freebsd_committer freebsd_triage 2024-09-27 07:15:11 UTC
(In reply to Oleksii Samorukov from comment #5)
I am the maintainer, this is why I was confused why it already assigned. Can I take over?
Comment 7 Oleksii Samorukov freebsd_committer freebsd_triage 2024-09-27 07:17:02 UTC
Yes, please
Comment 8 Michael Osipov freebsd_committer freebsd_triage 2024-09-27 07:33:16 UTC
I just want to make sure that we are taking about devel/py-subversion, correct?
Comment 9 Michael Osipov freebsd_committer freebsd_triage 2024-09-27 08:06:57 UTC
This is the actual backport: https://github.com/apache/subversion/commit/eae531008b3454d2709b8aaf766b08e37160668a

Apply objections to apply it straight from GitHub?
Comment 10 Michael Osipov freebsd_committer freebsd_triage 2024-09-27 08:34:17 UTC
(In reply to Michael Osipov from comment #9)

The patch does not apply due to the STATUS file :-( Will need to add a manual patch.
Comment 11 Michael Osipov freebsd_committer freebsd_triage 2024-09-27 08:51:07 UTC
Please test: https://reviews.freebsd.org/D46807
Comment 12 commit-hook freebsd_committer freebsd_triage 2024-09-28 08:44:07 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=fdad3e1b5329ce582c89c6bb71d0d83272622bc1

commit fdad3e1b5329ce582c89c6bb71d0d83272622bc1
Author:     Michael Osipov <michaelo@FreeBSD.org>
AuthorDate: 2024-09-27 08:17:33 +0000
Commit:     Michael Osipov <michaelo@FreeBSD.org>
CommitDate: 2024-09-28 08:43:28 +0000

    devel/py-subversion{,-lts}: swig-py: Fix `none_dealloc` error (one-off patch)

    PR:             281709
    Approved by:    jrm (mentor), otis (mentor)
    Differential Revision:  https://reviews.freebsd.org/D46807

 devel/py-subversion/Makefile                       |  4 +-
 ...-eae531008b3454d2709b8aaf766b08e37160668a (new) | 44 ++++++++++++++++++++++
 2 files changed, 46 insertions(+), 2 deletions(-)
Comment 13 Michael Osipov freebsd_committer freebsd_triage 2024-09-28 08:44:44 UTC
Patch will be removed with Subversion 1.14.4.