Bug 281812

Summary: www/nextcloud fails to package
Product: Ports & Packages Reporter: Dima Panov <fluffy>
Component: Individual Port(s)Assignee: Bernard Spil <brnrd>
Status: Closed FIXED    
Severity: Affects Only Me Flags: bugzilla: maintainer-feedback? (brnrd)
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   

Description Dima Panov freebsd_committer freebsd_triage 2024-10-02 08:21:57 UTC 
poudriere bulk -t claims a lot orphaned license files for latest www/nextcloud port
is it an expected behavior or extra handling is missed?


===> Checking for items in STAGEDIR missing from pkg-plist
Error: Orphaned: %%WWWDIR%%/apps-pkg/files_pdfviewer/js/files_pdfviewer-main.js.map.license
Error: Orphaned: %%WWWDIR%%/apps-pkg/files_pdfviewer/js/files_pdfviewer-node_modules_nextcloud_dialogs_dist_chunks_index-CWnkpNim_mjs.js.map.license
Error: Orphaned: %%WWWDIR%%/apps-pkg/files_pdfviewer/js/files_pdfviewer-public.js.map.license
Error: Orphaned: %%WWWDIR%%/apps-pkg/files_pdfviewer/js/files_pdfviewer-vendors-node_modules_nextcloud_dialogs_dist_chunks_FilePicker-kaHdQqaz_mjs.js.map.license
Error: Orphaned: %%WWWDIR%%/apps-pkg/files_pdfviewer/js/files_pdfviewer-workersrc.js.map.license
Error: Orphaned: %%WWWDIR%%/apps-pkg/photos/js/photos-dashboard.js.map.license
Error: Orphaned: %%WWWDIR%%/apps-pkg/photos/js/photos-main.js.map.license
Error: Orphaned: %%WWWDIR%%/apps-pkg/photos/js/photos-node_modules_blurhash_dist_esm_index_js-node_modules_vue-material-design-icons_ArrowLeft_vue--996eaf.js.map.license
Error: Orphaned: %%WWWDIR%%/apps-pkg/photos/js/photos-node_modules_blurhash_dist_esm_index_js-node_modules_vue-material-design-icons_ArrowLeft_vue--f24de2.js.map.license
Error: Orphaned: %%WWWDIR%%/apps-pkg/photos/js/photos-node_modules_blurhash_dist_esm_index_js-node_modules_vue-material-design-icons_PackageVariant-6bf9ec.js.map.license
Error: Orphaned: %%WWWDIR%%/apps-pkg/photos/js/photos-node_modules_blurhash_dist_esm_index_js-node_modules_vue-material-design-icons_PackageVariant-bff37a.js.map.license
Error: Orphaned: %%WWWDIR%%/apps-pkg/photos/js/photos-node_modules_moment_locale_sync_recursive_-src_views_PhotosTab_vue.js.map.license
Error: Orphaned: %%WWWDIR%%/apps-pkg/photos/js/photos-node_modules_nextcloud_upload_node_modules_nextcloud_dialogs_dist_chunks_index-c0bccfab_mjs.js.map.license
Error: Orphaned: %%WWWDIR%%/apps-pkg/photos/js/photos-node_modules_vue-material-design-icons_ArrowLeft_vue-src_views_Timeline_vue.js.map.license
Error: Orphaned: %%WWWDIR%%/apps-pkg/photos/js/photos-node_modules_vue-material-design-icons_FolderMultipleImage_vue-src_views_AlbumContent_vue.js.map.license
Comment 1 Bernard Spil freebsd_committer freebsd_triage 2024-11-10 12:01:01 UTC 
Cannot reproduce.

All the port does is extract, move some stuff about, use extracted folder to generate pkg-plist. Can't see how you'd have differences between extract and the ` find` output.

Can you reproduce?
Comment 2 Dima Panov freebsd_committer freebsd_triage 2024-11-10 14:51:37 UTC 
(In reply to Bernard Spil from comment #1)

poudriere log
https://people.freebsd.org/~fluffy/-log/141amd64/nextcloud-php82-30.0.1.log


all *.license files are present in original tarball, extracted and moved to stage dir by framework, without MITM presence.
Comment 3 Dima Panov freebsd_committer freebsd_triage 2024-11-28 09:00:30 UTC 
(In reply to Dima Panov from comment #2)
Holy moly!

Houston, we have a problem!


All orphaned *.license mentions are real symlinks (not files) since nextcloud-30.0.0 and not covered by do-install script.


diff --git a/www/nextcloud/Makefile b/www/nextcloud/Makefile
index 8d0935d0a192..1fc1b2c20b60 100644
--- a/www/nextcloud/Makefile
+++ b/www/nextcloud/Makefile
@@ -81,7 +81,7 @@ do-install:
                ${STAGEDIR}${WWWDIR}/config/config.sample.php
        @${MKDIR} ${STAGEDIR}${WWWDIR}/data ${STAGEDIR}${WWWDIR}/apps \
                ${STAGEDIR}/var/log/${PORTNAME}
-       (cd ${WRKSRC}; ${FIND} . -type f) | ${SORT} | \
+       (cd ${WRKSRC}; ${FIND} . \(-type f -o -type l\)) | ${SORT} | \
                ${SED} -Ee '/^\.\/\.(htaccess\.dist|user\.ini)/d' \
                        -e '/^\.\/config\/config\.sample\.php/d' \
                        -e 's,^\.,${WWWDIR_REL},' >> ${TMPPLIST}
Comment 4 Dima Panov freebsd_committer freebsd_triage 2024-11-28 09:05:13 UTC 
(In reply to Dima Panov from comment #3)
Oh, wrong version of diff with extra parenthesis :(



-       (cd ${WRKSRC}; ${FIND} . -type f) | ${SORT} | \
+       (cd ${WRKSRC}; ${FIND} . -type f -o -type l) | ${SORT} | \
Comment 5 commit-hook freebsd_committer freebsd_triage 2024-12-18 18:41:09 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=c1674a4175adeb653d04f21c80956163b45b4eb7

commit c1674a4175adeb653d04f21c80956163b45b4eb7
Author:     Bernard Spil <brnrd@FreeBSD.org>
AuthorDate: 2024-12-18 18:39:13 +0000
Commit:     Bernard Spil <brnrd@FreeBSD.org>
CommitDate: 2024-12-18 18:39:13 +0000

    www/nextcloud: Update to 30.0.5

    * And fix package failure [1]

    PR:             281812 [1]
    Reported by:    fluffy [1]

 www/nextcloud/Makefile | 4 ++--
 www/nextcloud/distinfo | 6 +++---
 2 files changed, 5 insertions(+), 5 deletions(-)