Bug 281852

Summary: games/0ad does not build after libboost update
Product: Ports & Packages Reporter: Lars Henrik Ørn <larshenrikoern>
Component: Individual Port(s)Assignee: Guido Falsi <madpilot>
Status: Closed FIXED    
Severity: Affects Only Me CC: agh
Priority: --- Flags: madpilot: maintainer-feedback+
Version: Latest   
Hardware: Any   
OS: Any   
URL: https://gitea.wildfiregames.com/0ad/0ad/commit/0831f5d3ce214970fed1b3a55817e7246acd58db

Description Lars Henrik Ørn 2024-10-04 15:58:18 UTC
0ad

0ad does not build on poudriere. Possible reason. Does not work with boost-1.85+

Last part of build log:


c++ -O2 -pipe -march=native -DLIBICONV_PLUG -fstack-protector-strong -fno-strict-aliasing  -DLIBICONV_PLUG  -DU_USING_ICU_NAMESPACE=1 -DLIBICONV_PLUG -MMD -MP -DNDEBUG -DCONFIG_FINAL=1 -DINSTALLED_BINDIR=/usr/local/bin -DINSTALLED_DATADIR=/usr/local/share/0ad -DINSTALLED_LIBDIR=/usr/local/lib/0ad -DCONFIG_ENABLE_PCH=1 -DNVTT_SHARED=1 -I../../../source/pch/graphics -I../../../source -isystem ../../../libraries/source/glad/include -isystem /usr/local/include/SDL2 -isystem ../../../libraries/source/spidermonkey/include-unix-release -isystem /usr/local/include/freetype2 -isystem /usr/local/include/libpng16 -isystem /usr/local/include -isystem ../../../libraries/source/nvtt/include -O3 -g -Wall -Wextra -fno-rtti -std=c++17 -Wno-switch -Wno-reorder -Wno-invalid-offsetof -Wextra -Wno-missing-field-initializers -Wunused-parameter -Wredundant-decls -Wnon-virtual-dtor -Wundef -fstack-protector-all -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstrict-aliasing -fno-omit-frame-pointer -fpch-preprocess -fPIC -fvisibility=hidden -D_REENTRANT -D_THREAD_SAFE -include obj/graphics_Release/precompiled.h -o "obj/graphics_Release/UnitManager.o" -MF "obj/graphics_Release/UnitManager.d" -c "../../../source/graphics/UnitManager.cpp"
JSInterface_GameView.cpp
c++ -O2 -pipe -march=native -DLIBICONV_PLUG -fstack-protector-strong -fno-strict-aliasing  -DLIBICONV_PLUG  -DU_USING_ICU_NAMESPACE=1 -DLIBICONV_PLUG -MMD -MP -DNDEBUG -DCONFIG_FINAL=1 -DINSTALLED_BINDIR=/usr/local/bin -DINSTALLED_DATADIR=/usr/local/share/0ad -DINSTALLED_LIBDIR=/usr/local/lib/0ad -DCONFIG_ENABLE_PCH=1 -DNVTT_SHARED=1 -I../../../source/pch/graphics -I../../../source -isystem ../../../libraries/source/glad/include -isystem /usr/local/include/SDL2 -isystem ../../../libraries/source/spidermonkey/include-unix-release -isystem /usr/local/include/freetype2 -isystem /usr/local/include/libpng16 -isystem /usr/local/include -isystem ../../../libraries/source/nvtt/include -O3 -g -Wall -Wextra -fno-rtti -std=c++17 -Wno-switch -Wno-reorder -Wno-invalid-offsetof -Wextra -Wno-missing-field-initializers -Wunused-parameter -Wredundant-decls -Wnon-virtual-dtor -Wundef -fstack-protector-all -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstrict-aliasing -fno-omit-frame-pointer -fpch-preprocess -fPIC -fvisibility=hidden -D_REENTRANT -D_THREAD_SAFE -include obj/graphics_Release/precompiled.h -o "obj/graphics_Release/JSInterface_GameView.o" -MF "obj/graphics_Release/JSInterface_GameView.d" -c "../../../source/graphics/scripting/JSInterface_GameView.cpp"
../../../source/graphics/TextureManager.cpp:788:73: error: no member named 'leaf' in 'boost::filesystem::path'
  788 |                 return m_TextureConverter.ComputeSettings(GetWstringFromWpath(srcPath.leaf()), files);
      |                                                                               ~~~~~~~ ^
precompiled.cpp
c++ -O2 -pipe -march=native -DLIBICONV_PLUG -fstack-protector-strong -fno-strict-aliasing  -DLIBICONV_PLUG  -DU_USING_ICU_NAMESPACE=1 -DLIBICONV_PLUG -MMD -MP -DNDEBUG -DCONFIG_FINAL=1 -DINSTALLED_BINDIR=/usr/local/bin -DINSTALLED_DATADIR=/usr/local/share/0ad -DINSTALLED_LIBDIR=/usr/local/lib/0ad -DCONFIG_ENABLE_PCH=1 -DNVTT_SHARED=1 -I../../../source/pch/graphics -I../../../source -isystem ../../../libraries/source/glad/include -isystem /usr/local/include/SDL2 -isystem ../../../libraries/source/spidermonkey/include-unix-release -isystem /usr/local/include/freetype2 -isystem /usr/local/include/libpng16 -isystem /usr/local/include -isystem ../../../libraries/source/nvtt/include -O3 -g -Wall -Wextra -fno-rtti -std=c++17 -Wno-switch -Wno-reorder -Wno-invalid-offsetof -Wextra -Wno-missing-field-initializers -Wunused-parameter -Wredundant-decls -Wnon-virtual-dtor -Wundef -fstack-protector-all -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstrict-aliasing -fno-omit-frame-pointer -fpch-preprocess -fPIC -fvisibility=hidden -D_REENTRANT -D_THREAD_SAFE -include obj/graphics_Release/precompiled.h -o "obj/graphics_Release/precompiled.o" -MF "obj/graphics_Release/precompiled.d" -c "../../../source/pch/graphics/precompiled.cpp"
AlphaMapCalculator.cpp
c++ -O2 -pipe -march=native -DLIBICONV_PLUG -fstack-protector-strong -fno-strict-aliasing  -DLIBICONV_PLUG  -DU_USING_ICU_NAMESPACE=1 -DLIBICONV_PLUG -MMD -MP -DNDEBUG -DCONFIG_FINAL=1 -DINSTALLED_BINDIR=/usr/local/bin -DINSTALLED_DATADIR=/usr/local/share/0ad -DINSTALLED_LIBDIR=/usr/local/lib/0ad -DCONFIG_ENABLE_PCH=1 -DNVTT_SHARED=1 -I../../../source/pch/graphics -I../../../source -isystem ../../../libraries/source/glad/include -isystem /usr/local/include/SDL2 -isystem ../../../libraries/source/spidermonkey/include-unix-release -isystem /usr/local/include/freetype2 -isystem /usr/local/include/libpng16 -isystem /usr/local/include -isystem ../../../libraries/source/nvtt/include -O3 -g -Wall -Wextra -fno-rtti -std=c++17 -Wno-switch -Wno-reorder -Wno-invalid-offsetof -Wextra -Wno-missing-field-initializers -Wunused-parameter -Wredundant-decls -Wnon-virtual-dtor -Wundef -fstack-protector-all -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstrict-aliasing -fno-omit-frame-pointer -fpch-preprocess -fPIC -fvisibility=hidden -D_REENTRANT -D_THREAD_SAFE -include obj/graphics_Release/precompiled.h -o "obj/graphics_Release/AlphaMapCalculator.o" -MF "obj/graphics_Release/AlphaMapCalculator.d" -c "../../../source/renderer/AlphaMapCalculator.cpp"
DebugRenderer.cpp
c++ -O2 -pipe -march=native -DLIBICONV_PLUG -fstack-protector-strong -fno-strict-aliasing  -DLIBICONV_PLUG  -DU_USING_ICU_NAMESPACE=1 -DLIBICONV_PLUG -MMD -MP -DNDEBUG -DCONFIG_FINAL=1 -DINSTALLED_BINDIR=/usr/local/bin -DINSTALLED_DATADIR=/usr/local/share/0ad -DINSTALLED_LIBDIR=/usr/local/lib/0ad -DCONFIG_ENABLE_PCH=1 -DNVTT_SHARED=1 -I../../../source/pch/graphics -I../../../source -isystem ../../../libraries/source/glad/include -isystem /usr/local/include/SDL2 -isystem ../../../libraries/source/spidermonkey/include-unix-release -isystem /usr/local/include/freetype2 -isystem /usr/local/include/libpng16 -isystem /usr/local/include -isystem ../../../libraries/source/nvtt/include -O3 -g -Wall -Wextra -fno-rtti -std=c++17 -Wno-switch -Wno-reorder -Wno-invalid-offsetof -Wextra -Wno-missing-field-initializers -Wunused-parameter -Wredundant-decls -Wnon-virtual-dtor -Wundef -fstack-protector-all -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstrict-aliasing -fno-omit-frame-pointer -fpch-preprocess -fPIC -fvisibility=hidden -D_REENTRANT -D_THREAD_SAFE -include obj/graphics_Release/precompiled.h -o "obj/graphics_Release/DebugRenderer.o" -MF "obj/graphics_Release/DebugRenderer.d" -c "../../../source/renderer/DebugRenderer.cpp"
1 error generated.
gmake[1]: *** [graphics.make:394: obj/graphics_Release/TextureManager.o] Error 1
gmake[1]: *** Waiting for unfinished jobs....
gmake: *** [Makefile:127: graphics] Error 2
===> Compilation failed unexpectedly.
Try to set MAKE_JOBS_UNSAFE=yes and rebuild before reporting the failure to
the maintainer.
*** Error code 1

Stop.
make: stopped in /usr/ports/games/0ad
=>> Cleaning up wrkdir
===>  Cleaning for 0ad-0.0.26_30
build of games/0ad | 0ad-0.0.26_30 ended at Fri Oct  4 17:38:20 CEST 2024
build time: 00:04:57
!!! build failure encountered !!!
Comment 1 Guido Falsi freebsd_committer freebsd_triage 2024-10-05 09:02:50 UTC
Hi!

Thanks for reporting.

Looks like upstream has already fixed this issue, so I need to import the patch, which I will do in the next few days at most.

Link to upstream fix: https://trac.wildfiregames.com/changeset/28176/
Comment 2 Guido Falsi freebsd_committer freebsd_triage 2024-10-05 09:13:08 UTC
Better link (upstream changed repo software):

https://gitea.wildfiregames.com/0ad/0ad/commit/0831f5d3ce214970fed1b3a55817e7246acd58db
Comment 3 commit-hook freebsd_committer freebsd_triage 2024-10-06 08:42:13 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=8cdf9918b1af79f3a1bfc510eb457bc3947ce206

commit 8cdf9918b1af79f3a1bfc510eb457bc3947ce206
Author:     Guido Falsi <madpilot@FreeBSD.org>
AuthorDate: 2024-10-06 08:40:42 +0000
Commit:     Guido Falsi <madpilot@FreeBSD.org>
CommitDate: 2024-10-06 08:40:42 +0000

    games/0ad: Fix buyild with new boost 1.85

    PR:             281852
    Obtained from:  https://gitea.wildfiregames.com/0ad/0ad/commit/0831f5d3ce214970fed1b3a55817e7246acd58db

 games/0ad/files/patch-boost-1.85 (new) | 49 ++++++++++++++++++++++++++++++++++
 1 file changed, 49 insertions(+)
Comment 4 Guido Falsi freebsd_committer freebsd_triage 2024-10-06 08:43:05 UTC
Imported upstream fix, should now compile and run fine.

Thanks for reporting the issue again!
Comment 5 Lars Henrik Ørn 2024-10-06 10:44:37 UTC
Hi

You are most welcome

And thank you for maintaining and fixing this :-)

Best wishes

Lars H