Bug 282093

Summary: devel/gitqlient: Improve port
Product: Ports & Packages Reporter: Daniel Engberg <diizzy>
Component: Individual Port(s)Assignee: Daniel Engberg <diizzy>
Status: Closed FIXED    
Severity: Affects Only Me Flags: adridg: maintainer-feedback+
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Patch for gitqlient none

Description Daniel Engberg freebsd_committer freebsd_triage 2024-10-14 22:57:19 UTC
Created attachment 254235 [details]
Patch for gitqlient

* Use upstream release archive as recommended by Porters Handbook and simplifies port
* Fix usage of USE_GL helper
* Add missing dependency USE_QT= network
* Remove usage of git during build
* Define version and sha checksum for build

Poudriere testport OK 14.1-RELEASE (amd64)
Comment 1 Daniel Engberg freebsd_committer freebsd_triage 2024-10-22 18:57:34 UTC
Friendly ping
Comment 2 Adriaan de Groot freebsd_committer freebsd_triage 2024-10-22 20:06:36 UTC
Go ahead, @diizzy . I guess I just hadn't spotted that there even were release tarballs.
Comment 3 commit-hook freebsd_committer freebsd_triage 2024-10-22 20:16:51 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=352476893ff7eb64bdf145c60a3561ab5fc392e3

commit 352476893ff7eb64bdf145c60a3561ab5fc392e3
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2024-10-22 20:14:59 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2024-10-22 20:16:17 +0000

    devel/gitqlient: Improve port

    * Use upstream release archive as recommended by Porters Handbook and simplifies port
    * Fix usage of USE_GL helper
    * Add missing dependency USE_QT= network
    * Remove usage of git during build
    * Define version and sha checksum for build

    PR:     282093
    Reviewed by:    adridg (maintainer)

 devel/gitqlient/Makefile                        | 32 +++++++++-------------
 devel/gitqlient/distinfo                        | 14 +++-------
 devel/gitqlient/files/patch-GitQlient.pro (new) | 36 +++++++++++++++++++++++++
 3 files changed, 51 insertions(+), 31 deletions(-)
Comment 4 Daniel Engberg freebsd_committer freebsd_triage 2024-10-22 20:26:44 UTC
Thanks!