Bug 282151

Summary: textproc/ripgrep-all: Require ripgrep (Github pull request for fix included)
Product: Ports & Packages Reporter: Robert William Vesterman <bob>
Component: Individual Port(s)Assignee: Robert Clausecker <fuz>
Status: Closed FIXED    
Severity: Affects Only Me CC: fuz
Priority: --- Flags: bob: maintainer-feedback-
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
patch none

Description Robert William Vesterman 2024-10-17 00:34:02 UTC
Created attachment 254302 [details]
patch

textproc/ripgrep-all will exit with a failure message when invoked if ripgrep is not also installed. This commit changes the Makefile so that textproc/ripgrep is listed as a runtime dependency, and therefore will be automatically built and installed along with textproc/ripgrep-all.
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2024-10-17 00:34:02 UTC
Maintainer informed via mail
Comment 2 Robert William Vesterman 2024-10-17 00:35:16 UTC
GitHub pull request here: https://github.com/freebsd/freebsd-ports/pull/313
Comment 3 Robert William Vesterman 2024-11-08 19:42:34 UTC
Maintainer timeout. Could someone please take a look at it? Thanks.
Comment 4 Robert Clausecker freebsd_committer freebsd_triage 2024-11-12 13:42:29 UTC
git says your patch is defective, idk how this happened.

I managed to make it work anyway.

Would you like to take over maintainership of this port?  It would like to be updated to the most recent version, too.
Comment 5 Robert William Vesterman 2024-11-12 19:57:31 UTC
(In reply to Robert Clausecker from comment #4)

Thanks.

Sorry, no, I can't in good conscience take ownership of this port. I know nothing of its internals, have only just started using it, and don't know all that much about the guts of FreeBSD's ports system (from a maintainer's point of view) anyway. I just installed it and noticed it didn't work.
Comment 6 Robert Clausecker freebsd_committer freebsd_triage 2024-11-12 19:59:05 UTC
Thank you for your submission.
I will then not enter you as maintainer.
Your patch will be committed with my next batch.
Comment 7 commit-hook freebsd_committer freebsd_triage 2024-11-14 08:45:41 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=2346138457bf6dd604b1b050e2dbb8c61eeb97a8

commit 2346138457bf6dd604b1b050e2dbb8c61eeb97a8
Author:     Robert William Vesterman <bob@vesterman.com>
AuthorDate: 2024-11-12 13:41:33 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2024-11-14 08:43:26 +0000

    textproc/ripgrep-all: depends on textproc/ripgrep

    textproc/ripgrep-all will exit with a failure message when invoked if
    ripgrep is not also installed. This commit changes the Makefile so that
    textproc/ripgrep is listed as a runtime dependency, and therefore will
    be automatically built and installed along with textproc/ripgrep-all.

    PR:             282151
    Approved by:    alexis.praga@free.fr (maintainer timeout)

 textproc/ripgrep-all/Makefile | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
Comment 8 Robert Clausecker freebsd_committer freebsd_triage 2024-11-14 08:58:09 UTC
Thank you for your contribution.