Bug 282357

Summary: sysutils/fusefs-bindfs: Simplify port
Product: Ports & Packages Reporter: Daniel Engberg <diizzy>
Component: Individual Port(s)Assignee: Daniel Engberg <diizzy>
Status: Closed FIXED    
Severity: Affects Only Me CC: doralitze
Priority: --- Flags: bugzilla: maintainer-feedback? (doralitze)
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Patch for fusefs-bindfs
none
Patch for fusefs-bindfs none

Description Daniel Engberg freebsd_committer freebsd_triage 2024-10-27 14:28:09 UTC
Created attachment 254567 [details]
Patch for fusefs-bindfs

* GNU_CONFIGURE_MANPREFIX
* Remove unncessary FUSE 3.x hacks

Compile tested on FreeBSD 14.1-RELEASE (amd64) (make, make check-plist)

Poudriere testport OK 13.3-RELEASE (amd64)
Poudriere testport OK 14.1-RELEASE (amd64)
Comment 1 Leon Dietrich 2024-10-27 14:43:32 UTC
The included hacks to support fuse 3 do not seam to be necessary any more. However, In my understanding one should stick with threading support as that library provides mutex support which is required for thread safety in fuse 3 environments.

Regarding the installation directory of make files, I have no preference regarding this, but the corresponding change was not introduced by me. Therefore I should figure out the implications first before I can comment on that.
Comment 2 Daniel Engberg freebsd_committer freebsd_triage 2024-10-27 16:09:40 UTC
Created attachment 254571 [details]
Patch for fusefs-bindfs

Force usage of (lib)thr instead of -pthread
Comment 3 Leon Dietrich 2024-10-27 16:31:26 UTC
LGTM
Comment 4 commit-hook freebsd_committer freebsd_triage 2024-10-27 17:07:14 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=7c64c77187f0c564aef90c73482a5cc4af0a27e9

commit 7c64c77187f0c564aef90c73482a5cc4af0a27e9
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2024-10-27 17:02:31 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2024-10-27 17:02:35 +0000

    sysutils/fusefs-bindfs: Simplify port

    * Remove GNU_CONFIGURE_MANPREFIX
    * Remove if segment and rework Makefile

    PR:             282357
    Reviewed by:    Leon Dietrich <doralitze@chaotikum.org> (maintainer)

 sysutils/fusefs-bindfs/Makefile | 20 +++++++-------------
 1 file changed, 7 insertions(+), 13 deletions(-)
Comment 5 Daniel Engberg freebsd_committer freebsd_triage 2024-10-27 17:20:50 UTC
Committed, thanks!