Bug 282358

Summary: sysutils/fusefs-curlftpfs: Switch to fork?
Product: Ports & Packages Reporter: Daniel Engberg <diizzy>
Component: Individual Port(s)Assignee: Rodrigo Osorio <rodrigo>
Status: Closed FIXED    
Severity: Affects Only Me Flags: bugzilla: maintainer-feedback? (rodrigo)
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   

Description Daniel Engberg freebsd_committer freebsd_triage 2024-10-27 14:41:40 UTC 
Upstream seems dead and there are two forks that are more recent at least and seems to contain some fixes for various issues.

https://github.com/ikn/curlftpfs-ng/
https://github.com/JackSlateur/curlftpfs/
Comment 1 commit-hook freebsd_committer freebsd_triage 2024-11-01 14:17:02 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=049f13bc6a60bd458d82a1aedebdcc4ebbaf1436

commit 049f13bc6a60bd458d82a1aedebdcc4ebbaf1436
Author:     Rodrigo Osorio <rodrigo@FreeBSD.org>
AuthorDate: 2024-11-01 13:24:13 +0000
Commit:     Rodrigo Osorio <rodrigo@FreeBSD.org>
CommitDate: 2024-11-01 14:14:38 +0000

    sysutils/fusefs-curlftpfs: Add debian patches

    Update curlftpfs code by integration additional debian
    patches who provide multiple fixes.

    Major changes:
     * fix-CURLOPT_INFILESIZE : Fix an unsupported curl value (-1)
       for CURLOPT_INFILESIZE option.
     * free_ftpfs_file-memleak-fix: Fix a memory leak.
       https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=587250
     * nocache-memleak-fix : Fix a memory leak when cache is disabled.
       https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=614347
     * curlftpfs__no_verify_hostname : Fix no_verify_hostname option with
       recent versions of curl
     * consistent feature flag : ensure consistent use of _XOPEN_SOURCE
     * getpass prototype : add getpass() prototype
     * Fix a typo in one of our patches who does an urlencode of paths.

    Bump portrevision

    PR:             282358
    Reported by:    diizzy

 sysutils/fusefs-curlftpfs/Makefile                  | 11 ++++++++++-
 sysutils/fusefs-curlftpfs/distinfo                  | 15 +++++++++++++--
 sysutils/fusefs-curlftpfs/files/patch-path__utils.c |  2 +-
 3 files changed, 24 insertions(+), 4 deletions(-)
Comment 2 Rodrigo Osorio freebsd_committer freebsd_triage 2024-11-01 14:17:21 UTC 
Thanks for the heads-up but after close analyze I feel that the forks doesn't
bring too much improvements or long term support

curlftpfs-ng bump the release version by importing half part of a debian patch
and stop all activities 4 years ago.

curlftpfs was more active (last commit was 9 months ago), import debian patches
but don't apply them, integrate some changes such the move from getpass to
readpassphrase, and add a custom version of urlencode to build local paths.
Additionally, this they don't produce any release versions number.

Instead, I do some cleanup on the existing port by integrating all existing
Debian patches and fix one of our patched who implements (again) the urlencode
feature.