Bug 282365

Summary: devel/valgrind 3.23.0,1 fails to build on Poudriere at Configure stage
Product: Ports & Packages Reporter: ddrinnon
Component: Individual Port(s)Assignee: Robert Clausecker <fuz>
Status: Closed FIXED    
Severity: Affects Only Me CC: fuz, pjfloyd, sergey.koupreyenko
Priority: --- Flags: pjfloyd: maintainer-feedback+
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Valgrind 3.23.0.1 build log
none
Patch for 3.24 release pjfloyd: maintainer-approval+

Description ddrinnon 2024-10-27 18:28:17 UTC 
devel/valgrind 3.23.0,1 fails to build on Poudriere with FreeBSD 13.4-RELEASE-p1 at Configure stage with message that the kernel version is unsupported.

build log snippet:
...
checking for a supported OS... ok (freebsd13.4)
checking for the kernel version... unsupported (13.4-RELEASE-p1)
configure: error: Valgrind works on FreeBSD 10.x to 15.x
===>  Script "configure" failed unexpectedly.
Please report the problem to pjfloyd@wanadoo.fr [maintainer] and attach the
"/wrkdirs/usr/ports/devel/valgrind/work/valgrind-3.23.0/config.log" including
the output of the failure of your make command. Also, it might be a good idea
to provide an overview of all packages installed on your system (e.g. a
/usr/local/sbin/pkg-static info -g -Ea).
*** Error code 1

Stop.
make: stopped in /usr/ports/devel/valgrind
=>> Cleaning up wrkdir
===>  Cleaning for valgrind-3.23.0,1
build of devel/valgrind | valgrind-3.23.0,1 ended at Sun Oct 27 11:25:44 EDT 2024
build time: 00:00:22
!!! build failure encountered !!!

Complete build log attached.
Comment 1 ddrinnon 2024-10-27 18:29:55 UTC 
Created attachment 254574 [details]
Valgrind 3.23.0.1 build log
Comment 2 Paul Floyd 2024-10-27 18:59:29 UTC 
Thanks. I'm aware of the issue, but I'm a bit busy preparing for the release of Valgrind 3.24 in the next few days. I'm not going to update devel/valgrind so close to the release. This also affects devel/valgrind-devel.

If you really need Valgrind I suggest building from sourceware git.
Comment 3 Paul Floyd 2024-11-01 07:14:06 UTC 
Created attachment 254840 [details]
Patch for 3.24 release

Change log
202770  open fd at exit --log-socket=127.0.0.1:1500 with --track-fds=yes
276780  An instruction in fftw (Fast Fourier Transform) is unhandled by
        valgrind: vex x86->IR: unhandled instruction bytes:
        0x66 0xF 0x3A 0x2
311655  --log-file=FILE leads to apparent fd leak
317127  Fedora18/x86_64 --sanity-level=3 : aspacem segment mismatch
337388  fcntl works on Valgrind's own file descriptors
377966  arm64 unhandled instruction dc zva392146  aarch64: unhandled
        instruction 0xD5380001 (MRS rT, midr_el1)
391148  Unhandled AVX instruction vmovq %xmm9,%xmm1
392146  aarch64: unhandled instruction 0xD5380001 (MRS rT, midr_el1)
412377  SIGILL on cache flushes on arm64
417572  vex amd64->IR: unhandled instruction bytes: 0xC5 0x79 0xD6 0xED 0xC5
440180  s390x: Failed assertion in disassembler
444781  MIPS: wrong syscall numbers used
447989  Support Armv8.2 SHA-512 instructions
445235  Java/Ada/D demangling is probably broken
453044  gbserver_tests failures in aarch64
479661  Valgrind leaks file descriptors
486180  [Valgrind][MIPS] 'VexGuestArchState' has no member named
        'guest_IP_AT_SYSCALL'
486293  memccpy false positives
486569  linux inotify_init syscall wrapper missing POST entry in syscall_table
487439  SIGILL in JDK11, JDK17
487993  Alignment error when using Eigen with Valgrind and -m32
488026  Use of `sizeof` instead of `strlen
488379  --track-fds=yes errors that cannot be suppressed with --xml-file=
488441  Add tests for --track-fds=yes --xml=yes and fd suppression tests
489040  massif trace change to show the location increasing the stack
489088  Valgrind throws unhandled instruction bytes: 0xC5 0x79 0xD6 0xE0 0xC5
489338  arm64: Instruction fcvtas should round 322.5 to 323, but result is 322.
489676  vgdb handle EINTR and EAGAIN more consistently
490651  Stop using -flto-partition=one
491394  (vgModuleLocal_addDiCfSI): Assertion 'di->fsm.have_rx_map &&
        di->fsm.rw_map_count' failed
492210  False positive on x86/amd64 with ZF taken directly from addition
492214  statx(fd, NULL, AT_EMPTY_PATH) is supported since Linux 6.11
        but not supported in valgrind
492422  Please support DRM_IOCTL_SYNCOBJ_HANDLE_TO_FD
492663  Valgrind ignores debug info for some binaries
493418  Add bad fd usage errors for --track-fds in ML_(fd_allowed)
493454  Missing FUSE_COMPATIBLE_MAY_BLOCK markers
493507  direct readlink syscall from PRE handler is incompatible with
        FUSE_COMPATIBLE_MAY_BLOCK
493959  s390x: Fix regtest failure for none/tests/s390x/op00
493970  s390x: Store/restore FPC upon helper call causes slowdown
494252  s390x: incorrect disassembly for LOCHI and friends
494960  Fixes and tweaks for gsl19test
495278  PowerPC instruction dcbf should allow the L field values of 4, 6 on
        ISA 3.0 and earlier, just ignore the value
495469  aligned_alloc and posix_memalign missing MALLOC_TRACE with returned
        pointer
495470  s390x: 3.24.0.RC1 missing file and regtest failure
n-i-bz  Improve messages for sigaltstack errors, use specific
        stack_t member names
Comment 4 Paul Floyd 2024-11-01 07:16:20 UTC 
I just want to add the new getrlimitusage and then I'll also bump up devel/valgrind-devel.
Comment 5 Paul Floyd 2024-11-10 15:52:17 UTC 
One thing missing from changelist:
494218  Remove FREEBSD_VERS from configure and build

This means that autoconf no longer detects the FreeBSD version and there is no longer a build time dependency.
Comment 6 Mark Linimon freebsd_committer freebsd_triage 2024-11-11 02:42:30 UTC 
*** Bug 282671 has been marked as a duplicate of this bug. ***
Comment 7 commit-hook freebsd_committer freebsd_triage 2024-11-14 08:45:33 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=a2c8708362621b024f39f0268824e2e49734df5f

commit a2c8708362621b024f39f0268824e2e49734df5f
Author:     Paul Floyd <pjfloyd@wanadoo.fr>
AuthorDate: 2024-11-11 12:55:12 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2024-11-14 08:43:21 +0000

    devel/valgrind: update to 3.24.0

    Change log
    202770  open fd at exit --log-socket=127.0.0.1:1500 with --track-fds=yes
    276780  An instruction in fftw (Fast Fourier Transform) is unhandled by
            valgrind: vex x86->IR: unhandled instruction bytes:
            0x66 0xF 0x3A 0x2
    311655  --log-file=FILE leads to apparent fd leak
    317127  Fedora18/x86_64 --sanity-level=3 : aspacem segment mismatch
    337388  fcntl works on Valgrind's own file descriptors
    377966  arm64 unhandled instruction dc zva392146  aarch64: unhandled
            instruction 0xD5380001 (MRS rT, midr_el1)
    391148  Unhandled AVX instruction vmovq %xmm9,%xmm1
    392146  aarch64: unhandled instruction 0xD5380001 (MRS rT, midr_el1)
    412377  SIGILL on cache flushes on arm64
    417572  vex amd64->IR: unhandled instruction bytes: 0xC5 0x79 0xD6 0xED 0xC5
    440180  s390x: Failed assertion in disassembler
    444781  MIPS: wrong syscall numbers used
    447989  Support Armv8.2 SHA-512 instructions
    445235  Java/Ada/D demangling is probably broken
    453044  gbserver_tests failures in aarch64
    479661  Valgrind leaks file descriptors
    486180  [Valgrind][MIPS] 'VexGuestArchState' has no member named
            'guest_IP_AT_SYSCALL'
    486293  memccpy false positives
    486569  linux inotify_init syscall wrapper missing POST entry in syscall_table
    487439  SIGILL in JDK11, JDK17
    487993  Alignment error when using Eigen with Valgrind and -m32
    488026  Use of `sizeof` instead of `strlen
    488379  --track-fds=yes errors that cannot be suppressed with --xml-file=
    488441  Add tests for --track-fds=yes --xml=yes and fd suppression tests
    489040  massif trace change to show the location increasing the stack
    489088  Valgrind throws unhandled instruction bytes: 0xC5 0x79 0xD6 0xE0 0xC5
    489338  arm64: Instruction fcvtas should round 322.5 to 323, but result is 322.
    489676  vgdb handle EINTR and EAGAIN more consistently
    490651  Stop using -flto-partition=one
    491394  (vgModuleLocal_addDiCfSI): Assertion 'di->fsm.have_rx_map &&
            di->fsm.rw_map_count' failed
    492210  False positive on x86/amd64 with ZF taken directly from addition
    492214  statx(fd, NULL, AT_EMPTY_PATH) is supported since Linux 6.11
            but not supported in valgrind
    492422  Please support DRM_IOCTL_SYNCOBJ_HANDLE_TO_FD
    492663  Valgrind ignores debug info for some binaries
    493418  Add bad fd usage errors for --track-fds in ML_(fd_allowed)
    493454  Missing FUSE_COMPATIBLE_MAY_BLOCK markers
    493507  direct readlink syscall from PRE handler is incompatible with
            FUSE_COMPATIBLE_MAY_BLOCK
    493959  s390x: Fix regtest failure for none/tests/s390x/op00
    493970  s390x: Store/restore FPC upon helper call causes slowdown
    494252  s390x: incorrect disassembly for LOCHI and friends
    494960  Fixes and tweaks for gsl19test
    495278  PowerPC instruction dcbf should allow the L field values of 4, 6 on
            ISA 3.0 and earlier, just ignore the value
    495469  aligned_alloc and posix_memalign missing MALLOC_TRACE with returned
            pointer
    495470  s390x: 3.24.0.RC1 missing file and regtest failure
    n-i-bz  Improve messages for sigaltstack errors, use specific
            stack_t member names

    PR:             282365
    Reported by:    ddrinnon@cdor.net

 devel/valgrind/Makefile | 2 +-
 devel/valgrind/distinfo | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)
Comment 8 Robert Clausecker freebsd_committer freebsd_triage 2024-11-14 08:54:24 UTC 
Thank you for your contribution.