Bug 282381

Summary: emulators/dosbox-staging: fix bug in build scripts
Product: Ports & Packages Reporter: Eirik Oeverby <ltning-freebsd>
Component: Individual Port(s)Assignee: Max Brazhnikov <makc>
Status: Closed FIXED    
Severity: Affects Some People Flags: bugzilla: maintainer-feedback? (makc)
Priority: ---    
Version: Latest   
Hardware: amd64   
OS: Any   
Attachments:
Description Flags
Patch to emulators/dosbox-staging/Makefile none

Description Eirik Oeverby 2024-10-28 11:47:48 UTC 
Created attachment 254591 [details]
Patch to emulators/dosbox-staging/Makefile

For some time, dosbox-staging has failed with SIGILL when installed from the FreeBSD package repositories. Building locally results in a working binary.

After discussing with dosbox-staging developers on GitHub, this has been flagged as a bug in their meson build scripts causing `march=native` to be set. See
https://github.com/dosbox-staging/dosbox-staging/issues/4020

Suggested workaround in attached patch: Pass the same MESON_ARGS as dosbox-staging uses in their own official builds until upstream has fixed the build scripts.
Comment 1 Eirik Oeverby 2024-10-28 17:32:06 UTC 
Sorry Mark, dunno what I was doing there (no description).
Comment 2 commit-hook freebsd_committer freebsd_triage 2024-10-29 20:49:18 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=d7d4e43aebc2bf74335fd425cbc7f2d8045a16be

commit d7d4e43aebc2bf74335fd425cbc7f2d8045a16be
Author:     Max Brazhnikov <makc@FreeBSD.org>
AuthorDate: 2024-10-29 20:47:31 +0000
Commit:     Max Brazhnikov <makc@FreeBSD.org>
CommitDate: 2024-10-29 20:47:31 +0000

    emulators/dosbox-staging: Disable SIMD autodetection

    Disable SIMD autodetection when building official package.

    PR:             282381
    Reported by:    Eirik Oeverby

 emulators/dosbox-staging/Makefile | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)
Comment 3 Max Brazhnikov freebsd_committer freebsd_triage 2024-10-29 20:53:04 UTC 
Should be fixed for newer packages. Thanks for report!
Comment 4 Eirik Oeverby 2024-10-29 21:01:33 UTC 
I forgot to bump the revision in my patch.. :(
Comment 5 Max Brazhnikov freebsd_committer freebsd_triage 2024-10-29 21:10:52 UTC 
(In reply to Eirik Oeverby from comment #4)
> I forgot to bump the revision in my patch.. :(

Not to worry, I have committed different patch and updated the port to latest version.
Comment 6 commit-hook freebsd_committer freebsd_triage 2024-10-31 10:34:50 UTC 
A commit in branch 2024Q4 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=a0b5fd06395afc496d330fb44586496093b080a2

commit a0b5fd06395afc496d330fb44586496093b080a2
Author:     Max Brazhnikov <makc@FreeBSD.org>
AuthorDate: 2024-10-29 20:47:31 +0000
Commit:     Max Brazhnikov <makc@FreeBSD.org>
CommitDate: 2024-10-31 10:33:33 +0000

    emulators/dosbox-staging: Disable SIMD autodetection

    Disable SIMD autodetection when building official package.

    PR:             282381
    Reported by:    Eirik Oeverby

    (cherry picked from commit d7d4e43aebc2bf74335fd425cbc7f2d8045a16be)

 emulators/dosbox-staging/Makefile | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)