Bug 282448
| Summary: | [NEW PORT] games/lgogdownloader: Unofficial downloader for GOG.com | ||
|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Alexander Vereeken <Alexander88207> |
| Component: | Individual Port(s) | Assignee: | Vladimir Druzenko <vvd> |
| Status: | Closed FIXED | ||
| Severity: | Affects Some People | CC: | agh, bsdcode, diizzy, uzsolt, vvd |
| Priority: | --- | ||
| Version: | Latest | ||
| Hardware: | Any | ||
| OS: | Any | ||
| Attachments: | |||
|
Description
Alexander Vereeken
2024-10-31 17:59:50 UTC
Created attachment 254823 [details]
0001-New-games-lgogdownloader-Unofficial-downloader-for-G.patch
Created attachment 254824 [details]
0001-New-games-lgogdownloader-Unofficial-downloader-for-G.patch
Remove LD_CONFIG
1. Use: MASTER_SITES= https://github.com/Sude-/${PORTNAME}/releases/download/v${DISTVERSION}/ instead of: DISTVERSIONPREFIX= v USE_GITHUB= yes GH_ACCOUNT= Sude- 2. If pkg-plist have less than 6 files use: PLIST_FILES= bin/${PORTNAME} \ share/man/man1/${PORTNAME}.1.gz in Makefile. 3. Warning: 'bin/lgogdownloader' is not stripped consider trying INSTALL_TARGET=install-strip or using ${STRIP_CMD} Add: post-install: ${STRIP_CMD} ${STAGEDIR}${PREFIX}/bin/${PORTNAME} 4. Add all boost libs to LIB_DEPENDS" LIB_DEPENDS= libboost_date_time.so:devel/boost-libs \ libboost_filesystem.so:devel/boost-libs \ libboost_iostreams.so:devel/boost-libs \ libboost_program_options.so:devel/boost-libs \ libboost_regex.so:devel/boost-libs \ libboost_system.so:devel/boost-libs \ 5. What do you think about non-default option GUI (or QT_GUI, or WEBENGINE) with dependency: "qtwebengine if build with -DUSE_QT_GUI=ON"? Created attachment 254920 [details]
0001-New-Port-games-lgogdownloader-Unofficial-downloader-.patch
Hello Vladimir,
thank you for taking this PR.
Addressing the comments.
Created attachment 254921 [details]
0001-New-Port-games-lgogdownloader-Unofficial-downloader-.patch
USES= cmake pkgconfig OPTIONS_DEFINE= USE_QT_GUI USE_QT_GUI_DESC= QT GUI Support USE_QT_GUI_USES= qt:6 USE_QT_GUI_USE= QT=webengine USE_QT_GUI_CMAKE_BOOL= USE_QT_GUI OPTIONS_DEFINE= QT_GUI QT_GUI_DESC= QT GUI Support QT_GUI_BUILD_DEPENDS= vulkan-headers>0:graphics/vulkan-headers QT_GUI_USES= gl qt:6 QT_GUI_USE= GL=opengl QT=base,declarative,positioning,webchannel,webengine QT_GUI_CMAKE_BOOL= USE_QT_GUI Created attachment 254946 [details]
0001-New-Port-games-lgogdownloader-Unofficial-downloader-.patch
Thanks for the suggestions.
Poudriere is happy about it.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=0ca859ecf21bbef14bb936c0dae249c4ce4d4e6c commit 0ca859ecf21bbef14bb936c0dae249c4ce4d4e6c Author: Alexander Vereeken <Alexander88207@protonmail.com> AuthorDate: 2024-11-04 21:39:55 +0000 Commit: Vladimir Druzenko <vvd@FreeBSD.org> CommitDate: 2024-11-04 21:39:55 +0000 games/lgogdownloader: New port: unofficial downloader for GOG.com Unofficial downloader to GOG.com for Linux users. It uses the same API as the official GOG Galaxy. https://sites.google.com/site/gogdownloader PR: 282448 games/Makefile | 1 + games/lgogdownloader/Makefile (new) | 42 ++++++++++++++++++++++++++++++++++++ games/lgogdownloader/distinfo (new) | 3 +++ games/lgogdownloader/pkg-descr (new) | 3 +++ 4 files changed, 49 insertions(+) Thanks. Please use QT6 instead of a custom QT_GUI option https://cgit.freebsd.org/ports/tree/Mk/bsd.options.desc.mk#n437 There's no need to refer multiple libraries within the same package (boost) Please fix CMakeLists.txt to use targets so strip works as intended or at least report it upstream, https://gitlab.kitware.com/cmake/cmake/-/issues/23590 (In reply to Daniel Engberg from comment #12) > Please use QT6 instead of a custom QT_GUI option > https://cgit.freebsd.org/ports/tree/Mk/bsd.options.desc.mk#n437 QT_GUI for build GUI. AFAIK, without it lgogdownloader is console application. The default description doesn't say anything about this. It would be more correct to rename it to "GUI". > There's no need to refer multiple libraries within the same package (boost) I have heard the opposite "opinion" - it is necessary to list all libraries even if they are from the same port. > Please fix CMakeLists.txt to use targets so strip works as intended or at least report it upstream, > https://gitlab.kitware.com/cmake/cmake/-/issues/23590 What will the maintainer answer... |
