Summary: | graphics/openjph: Update 0.17.0 → 0.18.0 - fixed use AVX* instructions on default build on amd64 | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Vladimir Druzenko <vvd> | ||||||
Component: | Individual Port(s) | Assignee: | Po-Chuan Hsieh <sunpoet> | ||||||
Status: | Closed FIXED | ||||||||
Severity: | Affects Some People | CC: | alt2600, freebsd, robbak | ||||||
Priority: | --- | Flags: | bugzilla:
maintainer-feedback?
(sunpoet) vvd: merge-quarterly? |
||||||
Version: | Latest | ||||||||
Hardware: | amd64 | ||||||||
OS: | Any | ||||||||
URL: | https://github.com/aous72/OpenJPH/issues/157 | ||||||||
Attachments: |
|
Description
Vladimir Druzenko
2024-11-04 15:41:49 UTC
I have this same issue, also on a Core 2 Quad Q660, that is causing all plasma applications (including sddm-greeter) to fail with signal 4. Building this port using WITH_DEBUG=yes, which probably disabled optimizations, allows the apps to work. Created attachment 255044 [details]
add AVX knob enable by default
Was just about to post this patch, wish I had found this sooner then KDE just no longer worker, and going through rebuilding it assuming something introduced a binary incompatibility on my live system.
anyway, verified this resolves my issue, upstream enables all SIMD instructions by default so they have to be explicitly turned off. Not sure if it should be on or off by default, I left on as that was how the port is going to be in the repo now, and the general trend from what I've seen.
(In reply to alt2600 from comment #2) What about SSE4? Upstream fixed this issue today in version 0.18.0. Patch for update port is trivial - just change version in Makefile, run make makesum and update pkg-plist. But "I don't like" SONAME "libopenjph.so.0.18" instead "libopenjph.so.0" - bump consumers every release. The patch suggested to upstream. (In reply to Vladimir Druzenko from comment #3) in my case its only ever been AVX that is an issue running a westmere. and as you pointed out below upstream considers things to be self dispatching, so it will check runtime for supported features and not use illegal instructions on an arch. that seemed to be broken, at least with llvm possibly gcc if I read the upstream bug report correctly. but i concede, I had a patch done and was about to put in a report to add AVX knob, and given how easy it would be to add SSE even selectively I didn't change my patch. more knobs could be added, or hopefully the runtime dispatch is fixed upstream and this is all moot as your next comment suggests it should be. Created attachment 255118 [details]
Update 0.17.0 → 0.18.0 with fix using AVX
My case fixed with this patch.
Po-Chuan Hsieh, I can commit this self if you want. A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=9c6fd40d482673376f211b0e32d1747450fb7dfb commit 9c6fd40d482673376f211b0e32d1747450fb7dfb Author: Baptiste Daroussin <bapt@FreeBSD.org> AuthorDate: 2024-11-12 16:45:17 +0000 Commit: Baptiste Daroussin <bapt@FreeBSD.org> CommitDate: 2024-11-12 16:45:17 +0000 graphics/libheif: chase upgrade of openjph PR: 282543 graphics/libheif/Makefile | 1 + 1 file changed, 1 insertion(+) |