Bug 282708

Summary: x11-wm/picom: Update 12.3 -> 12.5
Product: Ports & Packages Reporter: José Maldonado <yukiteruamano>
Component: Individual Port(s)Assignee: Robert Clausecker <fuz>
Status: Closed FIXED    
Severity: Affects Some People CC: agh, fuz
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
x11-wm/picom: Update 12.3 -> 12.4
none
x11-wm/picom: Update 12.3 -> 12.5 none

Description José Maldonado 2024-11-12 04:23:18 UTC
Created attachment 255112 [details]
x11-wm/picom: Update 12.3 -> 12.4

Hi, this is a new update for x11-wm/picom to v12.4. Tested on amd64 and i386, all ok.
Comment 1 Robert Clausecker freebsd_committer freebsd_triage 2024-11-12 12:56:54 UTC
Is there a changelog for this update?
Please remember to set the "maintainer-approval" flag on patches you submit to your own ports to "+" so they get looked at quicker.
Comment 2 Robert Clausecker freebsd_committer freebsd_triage 2024-11-12 13:26:59 UTC
The port fails in the checksum stage.
Please check the integrity of the distfile and resubmit.

=> yshui-picom-v12.4_GH0.tar.gz doesn't seem to exist in /data/distfiles/.
=> Attempting to fetch https://codeload.github.com/yshui/picom/tar.gz/v12.4?dummy=/yshui-picom-v12.4_GH0.tar.gz
fetch: https://codeload.github.com/yshui/picom/tar.gz/v12.4?dummy=/yshui-picom-v12.4_GH0.tar.gz: size unknown
fetch: https://codeload.github.com/yshui/picom/tar.gz/v12.4?dummy=/yshui-picom-v12.4_GH0.tar.gz: size of remote file is not known
yshui-picom-v12.4_GH0.tar.gz                           658 kB 3913 kBps    00s
=> Fetched file size mismatch (expected 674046, actual 674051)
=> Trying next site
=> Attempting to fetch http://distcache.FreeBSD.org/ports-distfiles/yshui-picom-v12.4_GH0.tar.gz
fetch: http://distcache.FreeBSD.org/ports-distfiles/yshui-picom-v12.4_GH0.tar.gz: Not Found
=> Couldn't fetch it - please try to retrieve this
=> port manually into /data/distfiles/ and try again.
*** Error code 1
Comment 3 José Maldonado 2024-11-13 18:49:33 UTC
(In reply to Robert Clausecker from comment #2)

Hi, thanks for the feedback! 

The difference in distinfo is caused for a later commit in upstream for fix a problem detected with the version. More info in [1]

Right now, v12.5 is out, this new version fix other bug for WM, 
I suggest mark CLOSED this, and resubmit v12.5. 

[1] https://github.com/yshui/picom/issues/1387
Comment 4 Robert Clausecker freebsd_committer freebsd_triage 2024-11-13 18:52:22 UTC
Please just upload a new patch to update from 12.3 to 12.5 on this bug report.  No need to open a new one.
Comment 5 José Maldonado 2024-11-13 19:28:49 UTC
Created attachment 255144 [details]
x11-wm/picom: Update 12.3 -> 12.5

Submit new patch for v12.5 and changelog

** New in v12.4 

* Improvements

Better workaround for a NVIDIA qurik, fix high CPU usage when screen is off (#1265)
Avoid using xrender convolution in all cases, should improve shadow performance for most users. (#1349)

* Bug fixes

Fix leak of saved window images.

* Build fixes

Fix build on arm32 (#1355)

** New in v12.5 

* Bug fixes

Fix assertion failure when running with some window managers (e.g. qtile) and no window is focused (#1384)
Comment 6 commit-hook freebsd_committer freebsd_triage 2024-11-14 08:45:31 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=ce330f13df6f401e38fed729aa248195f760156d

commit ce330f13df6f401e38fed729aa248195f760156d
Author:     Jose Maldonado aka Yukiteru <yukiteruamano@volfread.xyz>
AuthorDate: 2024-11-13 19:20:56 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2024-11-14 08:43:29 +0000

    x11-wm/picom: update to v12.5

    ** New in v12.4

    * Improvements

    Better workaround for a NVIDIA qurik, fix high CPU usage when screen is off (#1265)
    Avoid using xrender convolution in all cases, should improve shadow performance for most users. (#1349)

    * Bug fixes

    Fix leak of saved window images.

    * Build fixes

    Fix build on arm32 (#1355)

    ** New in v12.5

    * Bug fixes

    Fix assertion failure when running with some window managers (e.g. qtile) and no window is focused (#1384)

    PR:             282708

 x11-wm/picom/Makefile                | 2 +-
 x11-wm/picom/distinfo                | 6 +++---
 x11-wm/picom/files/patch-meson.build | 4 ++--
 3 files changed, 6 insertions(+), 6 deletions(-)
Comment 7 Robert Clausecker freebsd_committer freebsd_triage 2024-11-14 08:59:05 UTC
Thank you for your contribution.