Bug 282724

Summary:	www/onlyoffice-documentserver documentserver-generate-allfonts.sh errors
Product:	Ports & Packages	Reporter:	Martin Waschbüsch <martin>
Component:	Individual Port(s)	Assignee:	Mikael Urankar <mikael>
Status:	Closed FIXED
Severity:	Affects Only Me	Flags:	bugzilla: maintainer-feedback? (mikael)
Priority:	---
Version:	Latest
Hardware:	Any
OS:	Any

Description Martin Waschbüsch 2024-11-13 07:39:12 UTC

With the latest 8.2.0.143 version, running /usr/local/bin/documentserver-generate-allfonts.sh results in this output:

***

root@files:~# /usr/local/bin/documentserver-generate-allfonts.sh
Generating AllFonts.js, please wait...Done
Generating presentation themes, please wait...Done
Generating js caches, please wait...Done
/usr/local/bin/documentserver-generate-allfonts.sh: /usr/local/www/onlyoffice/documentserver/sdkjs/slide/themes/themes.js.gz: not found
ds:docservice: stopped
ds:docservice: started
ds:converter: stopped
ds:converter: started
/usr/local/bin/documentserver-flush-cache.sh: cannot create /usr/local/etc/nginx/includes/ds-cache.conf: No such file or directory
sed: 1: "/usr/local/www/onlyoffi ...": extra characters at the end of l command

***

The themes.js.gz I do not understand. The script tried to remove it with rm -f, so even if it did not exist, no error should be printed?

In case of nginx, the includes directory does not exist on my system (I do not use nginx for this at all, I use apache), so maybe checking for it and perhaps creating it on the fly would be needed?

Since everything seems to work, it may all be negligible stuff? But still, better to point it out. :-)

Comment 1 Mikael Urankar freebsd_committer

2024-11-13 07:58:46 UTC

(In reply to Martin Waschbüsch from comment #0)
Yeah, that should be /usr/local/etc/onlyoffice/documentserver/nginx/includes/ds-cache.conf
I've mixed up ETCDIR and LOCALBASE.

There is an extra whitespace after $DIR/sdkjs/common/Images/*.gz \ and the shell thinks that $DIR/sdkjs/slide/themes/themes.js.gz is a command

Comment 2 Martin Waschbüsch 2024-11-13 11:30:34 UTC

(In reply to Mikael Urankar from comment #1)
Now it makes sense. :-) Thanks for the quick reply!

Comment 3 Martin Waschbüsch 2024-11-13 11:40:09 UTC

(In reply to Mikael Urankar from comment #1)
I just noticed another issue in /usr/local/bin/documentserver-flush-cache.sh
The sed command there:

sed -i "s/{{HASH_POSTFIX}}/${HASH}/g" ${API_PATH}

That is a gnu-ism. BSD sed needs to explicitly specify a backup suffix (or empty string if no backup wanted):

sed -i "" "s/{{HASH_POSTFIX}}/${HASH}/g" ${API_PATH}

Comment 4 commit-hook freebsd_committer

2024-11-13 11:57:40 UTC

A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=29abb996b4728af244f46a187d834c7154f736bc

commit 29abb996b4728af244f46a187d834c7154f736bc
Author:     Mikael Urankar <mikael@FreeBSD.org>
AuthorDate: 2024-11-13 11:52:01 +0000
Commit:     Mikael Urankar <mikael@FreeBSD.org>
CommitDate: 2024-11-13 11:57:17 +0000

    www/onlyoffice-documentserver: Various fixes

     - Fix nginx ds-cache.conf location in documentserver-flush-cache.sh
     - Fix sed invocation in documentserver-flush-cache.sh
     - Remove extra whitespace in documentserver-generate-allfonts.sh
     - Remove todo list in Makefile

    PR:             282724

 www/onlyoffice-documentserver/Makefile                        |  7 +------
 ...common_documentserver_bin_documentserver-flush-cache.sh.m4 |  5 +++--
 ..._documentserver_bin_documentserver-generate-allfonts.sh.m4 | 11 +++++++----
 3 files changed, 11 insertions(+), 12 deletions(-)

Comment 5 Mikael Urankar freebsd_committer

2024-11-13 12:03:06 UTC

(In reply to Martin Waschbüsch from comment #3)
Thanks!