Bug 282736
| Summary: | devel/rubygem-nori: Update to 2.7.1 | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Ian Valentine <ivalentine> | ||||||||
| Component: | Individual Port(s) | Assignee: | Robert Clausecker <fuz> | ||||||||
| Status: | Closed FIXED | ||||||||||
| Severity: | Affects Only Me | CC: | fuz, joe | ||||||||
| Priority: | --- | Flags: | bugzilla:
maintainer-feedback?
(joe) |
||||||||
| Version: | Latest | ||||||||||
| Hardware: | Any | ||||||||||
| OS: | Any | ||||||||||
| Attachments: |
|
||||||||||
Your patch is defective: tabs have been replaced by whitespace in it. As this patch is rather simple, I can just fix it, but for future patches, make sure the patch stays unmolested as you submit it. Most importantly, do not use the clipboard to copy/paste it and make sure line endings are preserved (i.e. don't transfer through a Windows box). Is there a changelog for this update? Created attachment 255470 [details]
devel/rubygem-nori: Update to 2.7.1
Added a missed new dependency on math/rubygem-bigdecimal
Did a bit of actual testing, found that it throws an error on import if neither textproc/rubygem-nokogiri nor textproc/rubygem-rexml are available, so I added a switch that adds in the dep.
Thank you. Is there a changelog for this update? This new patch has the same whitespace issue, sorry about that. Changelog is here: https://github.com/savonrb/nori/blob/main/CHANGELOG.md Also, your new patch is defective the same way your old one is: tabs have been expanded to spaces. Make sure your patch is unmolested! Copy the file using a file copying tool, not using the clipboard or similar. Please fix your patch and resubmit. Removing this one from my current batch until a working patch is provided. Created attachment 255472 [details]
devel/rubygem-nori: Update to 2.7.1
Properly copied the file, tabs are tabs now.
Thank you for fixing the patch. A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=a4f903b73a6d9d70c7c12bf24016943c2dc112eb commit a4f903b73a6d9d70c7c12bf24016943c2dc112eb Author: Ian Valentine <ivalentine@arizona.edu> AuthorDate: 2024-11-13 21:22:18 +0000 Commit: Robert Clausecker <fuz@FreeBSD.org> CommitDate: 2024-11-27 11:59:34 +0000 devel/rubygem-nori: Update to 2.7.1 - add missing dependencies Changelog: https://github.com/savonrb/nori/blob/main/CHANGELOG.md PR: 282736 Approved by: joe@thrallingpenguin.com (maintainer timeout) devel/rubygem-nori/Makefile | 17 +++++++++++++++-- devel/rubygem-nori/distinfo | 5 +++-- 2 files changed, 18 insertions(+), 4 deletions(-) Thank you for your contribution. |
Created attachment 255148 [details] devel/rubygem-nori: Update to 2.7 Would like to have this version for a port update I'm working on. Poudriere test build succeeds at building sysutils/rubygem-winrm and www/rubygem-savon on 13.3, 13.4, and 14.1 using this patch. I didn't test actual functionality, but the gemspecs look good.