Bug 282737

Summary:	'... \| install: symlink ../man1 -> mnt/b/tftpboot//usr/share/man/en.ISO8859-1/: No such \| file or directory \| ...'
Product:	Base System	Reporter:	tzxzan+cqw8r63qtfb5g
Component:	bin	Assignee:	freebsd-bugs (Nobody) <bugs>
Status:	Closed Works As Intended
Severity:	Affects Only Me	CC:	emaste
Priority:	---
Version:	Unspecified
Hardware:	Any
OS:	Any
See Also:	https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=282711

Description tzxzan+cqw8r63qtfb5g 2024-11-13 22:22:08 UTC

FreeBSD version 10 and earlier - VMware Workstation 16 Player (Non-commercial use only)
Player
mtree -deU -f /mnt/mnt/src/etc/mtree/BSD.sendmail.dist -p mnt/b/tftpboot//
./var/spool/clientmqueue missing (created)
install -l s usr/src/sys mnt/b/tftpboot//sys
cd mnt/b/tftpboot//usr/share/man; for mandir in man*; do install -l s ../$mand
ir mnt/b/tftpboot//usr/share/man/en.ISO8859-1/; install -l s ../$mandir mnt/b
/tftpboot//usr/share/man/en.UTF-8/; done
install: symlink ../man1 -> mnt/b/tftpboot//usr/share/man/en.ISO8859-1/: No such
file or directory
*** Error code 71 

Stop.
make[5]: stopped in /mnt/mnt/src/etc
*** Error code 1
...

Comment 1 tzxzan+cqw8r63qtfb5g 2024-11-13 22:26:41 UTC

Similar to bug 282711 it is about relative paths and this time with the 'DESTDIR' variable. Commented lines result in the above mentioned error. Using absolute paths is OK:

...
        #MAKEOBJDIRPREFIX=mnt/obj/ /usr/bin/make -C mnt/src/ DESTDIR=mnt/b/tftpboot/ installworld
        MAKEOBJDIRPREFIX=$$(realpath mnt/obj/)/ /usr/bin/make -C mnt/src/ DESTDIR=$$(realpath ./)/mnt/b/tftpboot/ installworld
        #MAKEOBJDIRPREFIX=mnt/obj/ /usr/bin/make -C mnt/src/ DESTDIR=mnt/b/tftpboot/ installkernel
        MAKEOBJDIRPREFIX=$$(realpath mnt/obj/)/ /usr/bin/make -C mnt/src/ DESTDIR=$$(realpath ./)/mnt/b/tftpboot/ installkernel
        #MAKEOBJDIRPREFIX=mnt/obj/ /usr/bin/make -C mnt/src/ DESTDIR=mnt/b/tftpboot/ distribution
        MAKEOBJDIRPREFIX=$$(realpath mnt/obj/)/ /usr/bin/make -C mnt/src/ DESTDIR=$$(realpath ./)/mnt/b/tftpboot/ distribution
...

Bug 282711 was for relative paths with 'MAKEOBJDIRPREFIX'.

Bug 282737 is for relative paths with 'DESTDIR'.

Comment 2 commit-hook freebsd_committer

2024-11-14 15:49:27 UTC

A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=02dc158215a69c6439e5a0809e5f9c79e62c5fd1

commit 02dc158215a69c6439e5a0809e5f9c79e62c5fd1
Author:     Ed Maste <emaste@FreeBSD.org>
AuthorDate: 2024-11-14 15:47:08 +0000
Commit:     Ed Maste <emaste@FreeBSD.org>
CommitDate: 2024-11-14 15:48:26 +0000

    build: note that DESTDIR must be an absolute path

    PR:             282737
    Sponsored by:   The FreeBSD Foundation

 share/man/man7/build.7 | 3 +++
 1 file changed, 3 insertions(+)

Comment 3 Ed Maste freebsd_committer

2024-11-14 15:50:08 UTC

Note added in build(7) for DESTDIR as well now

Comment 4 commit-hook freebsd_committer

2024-11-16 15:00:44 UTC

A commit in branch stable/14 references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=54efa38e255184f7f7862294666b017acb093a08

commit 54efa38e255184f7f7862294666b017acb093a08
Author:     Ed Maste <emaste@FreeBSD.org>
AuthorDate: 2024-11-13 15:13:51 +0000
Commit:     Ed Maste <emaste@FreeBSD.org>
CommitDate: 2024-11-16 14:59:22 +0000

    build: Note paths that must be absolute

    PR:             282711
    PR:             282737
    Sponsored by:   The FreeBSD Foundation

    (cherry picked from commit 75af1320f4b57fb568ec4f6df6171a0343953f4f)
    (cherry picked from commit 02dc158215a69c6439e5a0809e5f9c79e62c5fd1)

 share/man/man7/build.7 | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

Comment 5 commit-hook freebsd_committer

2024-11-16 15:02:46 UTC

A commit in branch stable/13 references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=3c113ee25c20bdfc66d310e17451d17f4c1ddb92

commit 3c113ee25c20bdfc66d310e17451d17f4c1ddb92
Author:     Ed Maste <emaste@FreeBSD.org>
AuthorDate: 2024-11-13 15:13:51 +0000
Commit:     Ed Maste <emaste@FreeBSD.org>
CommitDate: 2024-11-16 15:01:41 +0000

    build: Note paths that must be absolute

    PR:             282711
    PR:             282737
    Sponsored by:   The FreeBSD Foundation

    (cherry picked from commit 75af1320f4b57fb568ec4f6df6171a0343953f4f)
    (cherry picked from commit 02dc158215a69c6439e5a0809e5f9c79e62c5fd1)
    (cherry picked from commit 54efa38e255184f7f7862294666b017acb093a08)

 share/man/man7/build.7 | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)