Bug 282800

Summary:	sys/dev/dpaa2/dpaa2_mc_acpi.c does not compile with ACPI_DEBUG
Product:	Base System	Reporter:	Poul-Henning Kamp <phk>
Component:	arm	Assignee:	Dmitry Salychev <dsl>
Status:	Closed FIXED
Severity:	Affects Only Me	CC:	bz, dsl
Priority:	---	Flags:	linimon: mfc-stable14? linimon: mfc-stable13?
Version:	15.0-CURRENT
Hardware:	arm64
OS:	Any

Description Poul-Henning Kamp freebsd_committer

2024-11-16 16:42:47 UTC

It is missing #defines for _COMPONENT and ACPI_MODULE_NAME.

I guess ACPI_MODULE_NAME can simply be "DPAA2" but I have no idea what would be a proper value for _COMPONENT

Reproduce:

add "options ACPI_DEBUG" to sys/arm64/conf/GENERIC and build the kernel

Comment 1 Bjoern A. Zeeb freebsd_committer

2024-11-18 18:26:25 UTC

adding myself as I have changes to the code I believe

Comment 2 Dmitry Salychev freebsd_committer

2024-11-18 22:06:00 UTC

Could you try review D47666?

Comment 3 commit-hook freebsd_committer

2024-11-19 15:50:14 UTC

A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=c2dd2be344fbf59cf95f6773d4b09cc7dda0f876

commit c2dd2be344fbf59cf95f6773d4b09cc7dda0f876
Author:     Dmitry Salychev <dsl@FreeBSD.org>
AuthorDate: 2024-11-18 21:56:11 +0000
Commit:     Dmitry Salychev <dsl@FreeBSD.org>
CommitDate: 2024-11-19 15:49:04 +0000

    dpaa2: Fix kernel built with ACPI_DEBUG

    PR:                     282800
    Reported by:            phk
    Tested by:              bz
    MFC after:              3 days
    Differential Revision:  https://reviews.freebsd.org/D47666

 sys/dev/dpaa2/dpaa2_mc_acpi.c | 4 ++++
 1 file changed, 4 insertions(+)

Comment 4 commit-hook freebsd_committer

2024-12-13 20:05:06 UTC

A commit in branch stable/13 references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=05150edd1e303d47362bef5d25e2fd5e66de092b

commit 05150edd1e303d47362bef5d25e2fd5e66de092b
Author:     Dmitry Salychev <dsl@FreeBSD.org>
AuthorDate: 2024-11-18 21:56:11 +0000
Commit:     Dmitry Salychev <dsl@FreeBSD.org>
CommitDate: 2024-12-13 20:02:28 +0000

    dpaa2: Fix kernel built with ACPI_DEBUG

    PR:                     282800
    Reported by:            phk
    Tested by:              bz
    MFC after:              3 days
    Differential Revision:  https://reviews.freebsd.org/D47666

    (cherry picked from commit c2dd2be344fbf59cf95f6773d4b09cc7dda0f876)

 sys/dev/dpaa2/dpaa2_mc_acpi.c | 4 ++++
 1 file changed, 4 insertions(+)

Comment 5 commit-hook freebsd_committer

2024-12-13 20:07:07 UTC

A commit in branch stable/14 references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=795e9c9b55036ede124ac5821644477da757aa52

commit 795e9c9b55036ede124ac5821644477da757aa52
Author:     Dmitry Salychev <dsl@FreeBSD.org>
AuthorDate: 2024-11-18 21:56:11 +0000
Commit:     Dmitry Salychev <dsl@FreeBSD.org>
CommitDate: 2024-12-13 20:05:53 +0000

    dpaa2: Fix kernel built with ACPI_DEBUG

    PR:                     282800
    Reported by:            phk
    Tested by:              bz
    MFC after:              3 days
    Differential Revision:  https://reviews.freebsd.org/D47666

    (cherry picked from commit c2dd2be344fbf59cf95f6773d4b09cc7dda0f876)

 sys/dev/dpaa2/dpaa2_mc_acpi.c | 4 ++++
 1 file changed, 4 insertions(+)