Bug 282803
| Summary: | Mk/Uses/cmake.mk: Add CLICOLOR=0 when CMAKE_NOCOLOR is set | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Thibault Payet <monwarez> | ||||
| Component: | Ports Framework | Assignee: | Port Management Team <portmgr> | ||||
| Status: | New --- | ||||||
| Severity: | Affects Only Me | CC: | arrowd, ports-bugs, ziaee | ||||
| Priority: | --- | ||||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
Does this option render the line above it redundant? I tested it without the above (I think redundant) line, and this added line does fix my issue where cmake outputs a yellow warning if it can't find the CMakeList, which is incompatible with light terminals. (In reply to Alexander Ziaee from comment #1) With a quick glance at cmake code, it seems that CLICOLOR=0 does not impact how cmake will generate the Makefile (and thus add colors to it). So setting CMAKE_COLOR_MAKEFILE is still required. Thanks! |
Created attachment 255225 [details] git format-patch Currently, when CMAKE_NOCOLOR is set, cmake will still complain about color being output if for instance there is no CMakeList.txt present in the working directory. cmake will not output color if the CLICOLOR environment variable is set to 0.