Bug 282816

Summary: devel/php-composer: Update to 2.8.3
Product: Ports & Packages Reporter: Guido Falsi <madpilot>
Component: Individual Port(s)Assignee: Guido Falsi <madpilot>
Status: Closed FIXED    
Severity: Affects Only Me CC: cyberbotx, michaelo
Priority: --- Flags: cyberbotx: maintainer-feedback+
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
patch v1 none

Description Guido Falsi freebsd_committer freebsd_triage 2024-11-17 17:16:30 UTC
Created attachment 255241 [details]
patch v1

Hi,

I've created a patch to update to latest 2.8.3. Can you approve?

Thanks in advance!
Comment 1 Naram Qashat 2024-11-17 18:25:02 UTC
Looks good to me.
Comment 2 Michael Osipov 2024-11-17 18:33:10 UTC
(In reply to Guido Falsi from comment #0)

Please modify the patch to remove dep on ca_root_nss, I have fixed the code upstream to use system trust store now: https://github.com/composer/ca-bundle/pull/98#discussion_r1845441500
Comment 3 Naram Qashat 2024-11-17 18:37:09 UTC
After looking at the PR on Github, I agree that removing the dependency is fine.
Comment 4 commit-hook freebsd_committer freebsd_triage 2024-11-18 20:59:36 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=f11fef50cc988dffdd2c760c11272164acc89bfe

commit f11fef50cc988dffdd2c760c11272164acc89bfe
Author:     Guido Falsi <madpilot@FreeBSD.org>
AuthorDate: 2024-11-18 20:57:12 +0000
Commit:     Guido Falsi <madpilot@FreeBSD.org>
CommitDate: 2024-11-18 20:57:12 +0000

    devel/php-composer: Update to 2.8.3

    Also Remove dependency on ca_root_nss, upstream code now uses the system trust store. [1]

    [1] https://github.com/composer/ca-bundle/pull/98#discussion_r1845441500

    PR:             282816
    Approved by:    Naram Qashat <cyberbotx@cyberbotx.com> (maintainer)

 devel/php-composer/Makefile | 4 +---
 devel/php-composer/distinfo | 6 +++---
 2 files changed, 4 insertions(+), 6 deletions(-)
Comment 5 Guido Falsi freebsd_committer freebsd_triage 2024-11-18 21:00:31 UTC
Committed. Thanks!