Bug 282825
| Summary: | emulators/wine-devel: Enable Wayland support | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | tatarataratatan | ||||||||||
| Component: | Individual Port(s) | Assignee: | freebsd-ports-bugs (Nobody) <ports-bugs> | ||||||||||
| Status: | Closed FIXED | ||||||||||||
| Severity: | Affects Some People | CC: | Alexander88207, fluffy, gerald, jbeich, monwarez, tatarataratatan | ||||||||||
| Priority: | --- | ||||||||||||
| Version: | Latest | ||||||||||||
| Hardware: | Any | ||||||||||||
| OS: | Any | ||||||||||||
| Attachments: |
|
||||||||||||
Created attachment 255250 [details]
git diff(wayland support)
I've made git diff version manually :) .
(In reply to tatarataratatan from comment #1) Do not use PORTEPOCH to update the port version, you need to use PORTREVISION for that. Dima, this may be one for you which I believe could go in(to wine-devel) before the Wine 10.0 release even if you like. Created attachment 256483 [details]
patch git format-patch
Here is the version with PORTREVISION updated instead of PORTEPOCH.
Please make sure to credit tatarataratatan and not me since I just changed one line.
Created attachment 256484 [details]
patch git format-patch
It helps if I remove my previous patches before, sorry for the noise.
(In reply to Thibault Payet from comment #4) > Please make sure to credit tatarataratatan and not me since I just > changed one line. This is a fine note, Thibault. I added you under Reviewed by:, since this is what you actually did, and indeed spotting an issue. I made some tweaks to files/pkg-message.in and removed the new WAYLAND option from OPTIONS_DEFAULT and will commit shortly (adding the missing colon after the port's name to the subject). A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=2acb6e55988b6fc62015ce70132c885dc2d620a2 commit 2acb6e55988b6fc62015ce70132c885dc2d620a2 Author: tatarataratatan@gmail.com <tatarataratatan@gmail.com> AuthorDate: 2025-01-12 11:54:40 +0000 Commit: Gerald Pfeifer <gerald@FreeBSD.org> CommitDate: 2025-01-12 12:03:48 +0000 emulators/wine-devel: Enable Wayland support This is not on by default (yet). PR: 282825 Reviewed by: Thibault Payet <monwarez@mailoo.org> emulators/wine-devel/Makefile | 19 ++++++++++++++++--- emulators/wine-devel/files/pkg-message.in | 8 ++++++++ emulators/wine-devel/pkg-plist | 2 ++ 3 files changed, 26 insertions(+), 3 deletions(-) Note, I'm planning to push this to the main emulators/wine port a bit after an upgrade to Wine 10.0 that should happen this month or next to let this settle a bit on wine-devel and give (more experienced) users a chance to play. (In reply to Gerald Pfeifer from comment #6) > removed the new WAYLAND option from OPTIONS_DEFAULT Why not? Wayland support doesn't affect X11-on-Xorg, as pkg-message noted, still disabled at runtime by default and this is -devel port you're no longer listed as maintainer. FWIW, other ports *build* with Wayland by default (since bug 227509) per "batteries included" policy in order to make binary packages useful for as many users as possible. A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=2922123124772866f25f8e7e2ea884d5624e533f commit 2922123124772866f25f8e7e2ea884d5624e533f Author: Gerald Pfeifer <gerald@FreeBSD.org> AuthorDate: 2025-01-15 16:02:49 +0000 Commit: Gerald Pfeifer <gerald@FreeBSD.org> CommitDate: 2025-01-15 16:02:49 +0000 emulators/wine-devel: Use option helpers for WAYLAND PLIST_SUB was already active, so nothing to explicitly do regarding pkg-plist. PR: 282825 Suggested by: vvd emulators/wine-devel/Makefile | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) |
Created attachment 255249 [details] wayland support wine-devel port diff from wine-devel-9.21,1 I've attached a patch which supports Wayland in wine-devel-9.21,1 . I've tested it and it looks good to me.